Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-22 Thread psoujany
On Wed, 17 Jan 2024 16:37:37 GMT, Hannes Wallnöfer wrote: >> @hns As this PR addresses below comment. I want this PR to be contributed >> with the below proposal. >> `Move the aria-labelledby attribute from the embedded to the > role="tab-panel"> as proposed, but maintain its current default va

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-22 Thread Pavel Rappo
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `j

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v9]

2024-01-22 Thread psoujany
> Interactive component with ARIA role 'tabpanel' does not have a > programmatically associated name in javadoc which is failing Accessibility > checks. > https://bugs.openjdk.org/browse/JDK-8311893 > https://bugs.openjdk.org/browse/JDK-8311894 psoujany has updated the pull request incrementally

Re: RFR: JDK-8164094: javadoc allows to create a @link to a non-existent method [v2]

2024-01-22 Thread Pavel Rappo
On Tue, 12 Dec 2023 12:42:41 GMT, Hannes Wallnöfer wrote: >> Please review a simple fix in `JavacTrees` to only look up member references >> in the enclosing type if the reference does not contain an explicit type >> name. For example, `@see #method()` in a a doc comment of class >> `Outer.Inn

Re: RFR: JDK-8164094: javadoc allows to create a @link to a non-existent method [v2]

2024-01-22 Thread Hannes Wallnöfer
On Wed, 13 Dec 2023 10:44:43 GMT, Hannes Wallnöfer wrote: >> Should this issue have a CSR for the behavioral change? > >> Should this issue have a CSR for the behavioral change? > > My understanding of the issue is that the lookup of explicit-class member > references in enclosing classes was a

Re: RFR: 8323698: Class use page does not include extends/implements type arguments

2024-01-22 Thread Hannes Wallnöfer
On Sun, 14 Jan 2024 01:00:36 GMT, Chen Liang wrote: > Currently in the javadoc tool, the generated class use page does not track > the occurrences of a class in the type arguments of the extends or implements > list, where they can appear. (See more details on the JBS issue) For example: > > p

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v8]

2024-01-22 Thread psoujany
> Interactive component with ARIA role 'tabpanel' does not have a > programmatically associated name in javadoc which is failing Accessibility > checks. > https://bugs.openjdk.org/browse/JDK-8311893 > https://bugs.openjdk.org/browse/JDK-8311894 psoujany has updated the pull request incrementally

Re: RFR: 8242564: javadoc crashes:: class cast exeception com.sun.tools.javac.code.Symtab$6

2024-01-22 Thread Vladimir Petko
On Tue, 16 Jan 2024 02:17:10 GMT, Vladimir Petko wrote: > '--ignore-source-errors' allows generating Javadoc for the packages that > contain compilation errors. > > jdk.javadoc.internal.doclets.toolkit.util.ClassTree generates a type > hierarchy for javadoc that may include error types such a