Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 17:21:23 GMT, Joe Darcy wrote: > I just suggest double-checking on the current maintenance procedures for the > java.util.concurrent code. @jddarcy Any idea how to do that? I tried searching for JSR-166 and java.util.concurrent, but all I could find was talk about a now-del

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-02-01 Thread psoujany
On Wed, 31 Jan 2024 17:23:54 GMT, Hannes Wallnöfer wrote: >> @hns I've updated my branch and modified the failing tests. Now all tests >> seems passing with the changes. Thank you. > > @psoujany the last thing that needs to be updated is to change `script.js` to > update the `aria-labelledby` a

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v17]

2024-02-01 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Pavel Rappo
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v16]

2024-02-01 Thread Jonathan Gibbons
On Tue, 30 Jan 2024 23:07:46 GMT, Jonathan Gibbons wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java >> line 572: >> >>> 570: } >>> 571: >>> 572: case TEXT -> { >> >> I haven't looked at `SentenceBreaker` in det

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v15]

2024-02-01 Thread Jonathan Gibbons
On Thu, 1 Feb 2024 01:12:52 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `jd

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v16]

2024-02-01 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Joe Darcy
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Roger Riggs
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Alexey Ivanov
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Daniel Fuchs
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v12]

2024-02-01 Thread Hannes Wallnöfer
On Thu, 1 Feb 2024 05:25:27 GMT, psoujany wrote: >> Interactive component with ARIA role 'tabpanel' does not have a >> programmatically associated name in javadoc which is failing Accessibility >> checks. >> https://bugs.openjdk.org/browse/JDK-8311893 >> https://bugs.openjdk.org/browse/JDK-8311

RFR: 8325109: Sort method modifiers in canonical order

2024-02-01 Thread Magnus Ihse Bursie
This is a follow-up on [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the bin/blessed-modifier-order.sh on the entire code base, and manually checked the result. I have reverted all but these trivial and uncontroversial changes. Almost all of these are about moving `stat