Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v58]

2024-04-26 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v57]

2024-04-26 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Integrated: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Hannes Wallnöfer
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote: > Please review a change to print a terminal message if the documentation > generated by `HtmlDoclet` contains any diagnostic marker elements for invalid > input. The message is printed after the documentation has been generated and > b

Integrated: 8303689: javac -Xlint could/should report on "dangling" doc comments

2024-04-26 Thread Jonathan Gibbons
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote: > Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v10]

2024-04-26 Thread Phil Race
On Fri, 26 Apr 2024 16:04:09 GMT, Jonathan Gibbons wrote: >> Please review the updates to support a proposed new >> `-Xlint:dangling-doc-comments` option. >> >> The work can be thought of as in 3 parts: >> >> 1. An update to the `javac` internal class `DeferredLintHandler` so that it >> is po

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Hannes Wallnöfer
On Fri, 26 Apr 2024 18:05:14 GMT, Jonathan Gibbons wrote: > The feature is good, but I'm surprised to see it being tested in > DocLintTest.java. I admit I took a shortcut there, using `DocLintTest` for something it wasn't meant to do. The test had to be updated anyway, and it had both the inva

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Jonathan Gibbons
On Fri, 26 Apr 2024 16:40:33 GMT, Pavel Rappo wrote: > The feature is good, but I'm surprised to see it being tested in > DocLintTest.java. Yeah, good point. The message should be generated independently of any doclint settings. - PR Comment: https://git.openjdk.org/jdk/pull/189

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Jonathan Gibbons
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote: > Please review a change to print a terminal message if the documentation > generated by `HtmlDoclet` contains any diagnostic marker elements for invalid > input. The message is printed after the documentation has been generated and > b

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Pavel Rappo
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote: > Please review a change to print a terminal message if the documentation > generated by `HtmlDoclet` contains any diagnostic marker elements for invalid > input. The message is printed after the documentation has been generated and > b

Re: RFR: 8303689: javac -Xlint could/should report on "dangling" doc comments [v10]

2024-04-26 Thread Jonathan Gibbons
> Please review the updates to support a proposed new > `-Xlint:dangling-doc-comments` option. > > The work can be thought of as in 3 parts: > > 1. An update to the `javac` internal class `DeferredLintHandler` so that it > is possible to specify the appropriately configured `Lint` object when i

RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Hannes Wallnöfer
Please review a change to print a terminal message if the documentation generated by `HtmlDoclet` contains any diagnostic marker elements for invalid input. The message is printed after the documentation has been generated and before the error/warning count with the purpose to let the user know