Re: RFR: 8329718: Incorrect `@since` tags in elements in jdk.compiler and java.compiler

2024-05-07 Thread Jonathan Gibbons
On Fri, 26 Apr 2024 11:05:03 GMT, Nizar Benalla wrote: > This PR aims to add `@since` tags in elements in both `jdk.compiler` and > `java.compiler`. > A lot of these changes have to do with handling of preview features. > > The existing rules for handling of `@since` for preview elements: > - W

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Jonathan Gibbons
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by jjg (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19119#pullre

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Thanks for reviewing it Joe, I'm now delegating integration of this PR to @JesperIRL, you, or anyone who will

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v67]

2024-05-07 Thread Joe Darcy
On Tue, 7 May 2024 17:31:29 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module `jd

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v56]

2024-05-07 Thread Joe Darcy
On Wed, 1 May 2024 20:40:00 GMT, Jonathan Gibbons wrote: > > There should be some quick testing of the new default method on Elements > > using the VacuousElements implementation; see > > `test/langtools/tools/javac/processing/model/util/elements` for some > > examples. > > @jddarcy I've reor

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Joe Darcy
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by darcy (Reviewer). > This PR is standalone as opposed to dependent because the #18787 de

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v67]

2024-05-07 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8317621: --add-script should support JavaScript modules

2024-05-07 Thread Hannes Wallnöfer
On Fri, 29 Mar 2024 09:39:18 GMT, Hannes Wallnöfer wrote: > Please review an enhancement to detect [JavaScript > modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) > when added to `javadoc` with the `--add-script` option, which require a > different `type` attribut

RFR: 8317621: --add-script should support JavaScript modules

2024-05-07 Thread Hannes Wallnöfer
Please review an enhancement to detect [JavaScript modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) when added to `javadoc` with the `--add-script` option, which require a different `type` attribute in the HTML `

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. This PR is standalone as opposed to dependent because the https://github.com/openjdk/jdk/pull/18787 dependenc

RFR: 8330205: Initial troff manpage generation for JDK 24

2024-05-07 Thread Pavel Rappo
Please review this mechanical change to man pages. This PR should be integrated after https://github.com/openjdk/jdk/pull/18787. - Commit messages: - Initial commit Changes: https://git.openjdk.org/jdk/pull/19119/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19119&range=

Re: RFR: 8325168: JShell should support Markdown comments [v2]

2024-05-07 Thread Jan Lahoda
> This is an attempt to add Markdown support in documentation comments to > JShell. > > It works by converting the Markdown text to HTML during the process of > resolving `{@inheritDoc}` tags. Jan Lahoda has updated the pull request with a new target base due to a merge or a rebase. The pull r

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v20]

2024-05-07 Thread psoujany
On Tue, 30 Apr 2024 10:52:23 GMT, psoujany wrote: >> The scrollable element `` with non-interactive content is not tabbable. >> Grid columns in the javadoc stylesheet has overflow: auto, which is failing >> Accessibility checks. >> https://bugs.openjdk.org/browse/JDK-8325690 > > psoujany has up