Re: RFR: 8317621: --add-script should support JavaScript modules [v2]

2024-05-15 Thread Jonathan Gibbons
On Wed, 15 May 2024 13:08:39 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to detect [JavaScript >> modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) >> when added to `javadoc` with the `--add-script` option, which require a >> different `type`

Re: RFR: 8329617: Update stylesheet for specs and tool documentation

2024-05-15 Thread Jonathan Gibbons
On Tue, 9 Apr 2024 13:06:28 GMT, Hannes Wallnöfer wrote: > Please review an update to the `jdk-default.css` stylesheet used for > specifications and tool guides. The original purpose was to make use of the > Dejavu web fonts provided by the API docs and to update the navigation bar to > match

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v67]

2024-05-15 Thread Jonathan Gibbons
On Wed, 15 May 2024 10:08:19 GMT, Pavel Rappo wrote: > I think we should add a test to verify that if `--disable-line-doc-comments` > is specified, no `///` dangling comments are reported. Added more tests for dangling doc comments. Note we cannot currently use `-Xlint:dangling-doc-comments`

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v69]

2024-05-15 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` >

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v68]

2024-05-15 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` >

Re: RFR: 8317621: --add-script should support JavaScript modules [v2]

2024-05-15 Thread Hannes Wallnöfer
> Please review an enhancement to detect [JavaScript > modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules) > when added to `javadoc` with the `--add-script` option, which require a > different `type` attribute in the HTML

Re: RFR: 8329617: Update stylesheet for specs and tool documentation

2024-05-15 Thread Hannes Wallnöfer
On Tue, 14 May 2024 22:25:13 GMT, Jonathan Gibbons wrote: > Is there a reason to want the main font size to be different between the API > pages and spec pages? I did not want to change the font size in this patch. I started by changing the font size to 14 px, but went back to the initial 10

Integrated: 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java

2024-05-15 Thread Hannes Wallnöfer
On Thu, 18 Apr 2024 12:11:56 GMT, Hannes Wallnöfer wrote: > Please review a change to move a long-running shellsupport test from > langtools tier1 to tier2, while modifying the tier1 test to only retrieve doc > comments for members of `java.lang.StringBuilder`, which is where [the > original

Re: RFR: 8298405: Implement JEP 467: Markdown Documentation Comments [v67]

2024-05-15 Thread Pavel Rappo
On Tue, 7 May 2024 17:31:29 GMT, Jonathan Gibbons wrote: >> Please review a patch to add support for Markdown syntax in documentation >> comments, as described in the associated JEP. >> >> Notable features: >> >> * support for `///` documentation comments in `JavaTokenizer` >> * new module