Re: RFR: 8332858: References with escapes have broken positions after they are transformed

2024-05-28 Thread Jonathan Gibbons
On Tue, 28 May 2024 19:07:06 GMT, Vicente Romero wrote: >> Sorry for the belated answer. Yes, regexps are usually not very performant, >> but it is only happening when the exact match fails. And, hopefully, the >> regexp should not be too difficult to handle. I was considering writing the >>

Re: RFR: 8332858: References with escapes have broken positions after they are transformed

2024-05-28 Thread Jonathan Gibbons
On Fri, 24 May 2024 09:05:20 GMT, Jan Lahoda wrote: > If the javadoc comment contains a (Markdown) link like: > > [java.util.Arrays#asList(Object[])] > > > The transformer that converts this link into the Javadoc link will not find > the reference, as it is looking for

Re: RFR: 8331873: Improve/expand info in `New API In` on Help page

2024-05-28 Thread Jonathan Gibbons
On Fri, 24 May 2024 15:47:02 GMT, Hannes Wallnöfer wrote: >> Please review a relatively simple update to the generated Help page, as part >> of the ongoing campaign to improve the documentation around the overall use >> of `@since` tags. > >

Re: RFR: 8332858: References with escapes have broken positions after they are transformed

2024-05-28 Thread Vicente Romero
On Tue, 28 May 2024 18:27:04 GMT, Jan Lahoda wrote: >> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java >> line 858: >> >>> 856: for (char c : ref.toCharArray()) { >>> 857: if (Escaping.ESCAPABLE.indexOf(c) >= 0) { >>>

Re: RFR: 8332858: References with escapes have broken positions after they are transformed

2024-05-28 Thread Vicente Romero
On Fri, 24 May 2024 09:05:20 GMT, Jan Lahoda wrote: > If the javadoc comment contains a (Markdown) link like: > > [java.util.Arrays#asList(Object[])] > > > The transformer that converts this link into the Javadoc link will not find > the reference, as it is looking for

Re: RFR: 8332858: References with escapes have broken positions after they are transformed

2024-05-28 Thread Jan Lahoda
On Sat, 25 May 2024 11:06:51 GMT, Vicente Romero wrote: >> If the javadoc comment contains a (Markdown) link like: >> >> [java.util.Arrays#asList(Object[])] >> >> >> The transformer that converts this link into the Javadoc link will not find >> the reference, as it is looking for

RFR: 8331579: Reference to primitive type fails without error or warning

2024-05-28 Thread Hannes Wallnöfer
Please review a simple fix to make DocLint report an error when linking to non-declared types in `{@link}` or `@see` tags. This has been implemented when the Standard Doclet is running without DocLint in [JDK-8284030](https://bugs.openjdk.org/browse/JDK-8284030), but needs to be implemented in