Re: RFR: 8332039: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null

On Fri, 31 May 2024 09:20:27 GMT, Pavel Rappo wrote: >> I understand the solution and see how it logically parallels the existing >> link between `getDocTreePath` and inheritable taglets. That said, I dislike >> the solution, but also cannot propose a better one at this time. The logic >> is r

Re: RFR: 8325168: JShell should support Markdown comments [v5]

On Fri, 31 May 2024 06:28:28 GMT, Jan Lahoda wrote: >> This is an attempt to add Markdown support in documentation comments to >> JShell. >> >> It works by converting the Markdown text to HTML during the process of >> resolving `{@inheritDoc}` tags. > > Jan Lahoda has updated the pull request

Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

Michael, There is no `element-list` file for any version of JDK before JDK 9.    Before JDK 9, the appropriate information was in the `package-list` file. In JDK 9, with the introduction of modules, the format of the file was updated to include modules, and because this was an incompatible ch

Re: Missing element-list for https://docs.oracle.com/javase/8/docs/jre/api/security/jgss/spec

Adding javadoc-dev@openjdk.org , but I heard "element-list" only came in with modules in JDK 9. --Weijun > On May 31, 2024, at 5:51 AM, Osipov, Michael (IN IT IN) > wrote: > > Guys, > > can someone upload element-list for that API? Javadoc fails to link to it:

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v23]

On Mon, 27 May 2024 09:50:38 GMT, psoujany wrote: >> The scrollable element `` with non-interactive content is not tabbable. >> Grid columns in the javadoc stylesheet has overflow: auto, which is failing >> Accessibility checks. >> https://bugs.openjdk.org/browse/JDK-8325690 > > psoujany has up

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v23]

On Mon, 27 May 2024 09:50:38 GMT, psoujany wrote: >> The scrollable element `` with non-interactive content is not tabbable. >> Grid columns in the javadoc stylesheet has overflow: auto, which is failing >> Accessibility checks. >> https://bugs.openjdk.org/browse/JDK-8325690 > > psoujany has up

Integrated: 8331579: Reference to primitive type fails without error or warning

On Tue, 28 May 2024 12:28:53 GMT, Hannes Wallnöfer wrote: > Please review a simple fix to make DocLint report an error when linking to > non-declared types in `{@link}` or `@see` tags. This has been implemented > when the Standard Doclet is running without DocLint in > [JDK-8284030](https://bu

Re: RFR: 8329537: Nested and enclosing classes should be linked separately in breadcrumb navigation [v2]

> Please review a patch to change the breadcrumb sub-navigation in API docs to > display nested classes as separate links. > > The change itself is simple, I replaced the `getBreadCrumbLink` method in > `HtmlDocletWriter` which returned a link for a single element with a new > `addBreadCrumbLi

Integrated: 8329537: Nested and enclosing classes should be linked separately in breadcrumb navigation

On Wed, 29 May 2024 19:39:14 GMT, Hannes Wallnöfer wrote: > Please review a patch to change the breadcrumb sub-navigation in API docs to > display nested classes as separate links. > > The change itself is simple, I replaced the `getBreadCrumbLink` method in > `HtmlDocletWriter` which returne

Re: RFR: 8331579: Reference to primitive type fails without error or warning

On Fri, 31 May 2024 10:19:52 GMT, Pavel Rappo wrote: > Consider adding a case of a primitive array, which while relates to > primitives is also an object. Oh, sorry, I see you did it in a separate test. I don't know why I didn't notice it. Sigh. - PR Review Comment: https://git.o

Re: RFR: 8331579: Reference to primitive type fails without error or warning

On Tue, 28 May 2024 12:28:53 GMT, Hannes Wallnöfer wrote: > Please review a simple fix to make DocLint report an error when linking to > non-declared types in `{@link}` or `@see` tags. This has been implemented > when the Standard Doclet is running without DocLint in > [JDK-8284030](https://bu

Re: RFR: 8331579: Reference to primitive type fails without error or warning

On Tue, 28 May 2024 12:28:53 GMT, Hannes Wallnöfer wrote: > Please review a simple fix to make DocLint report an error when linking to > non-declared types in `{@link}` or `@see` tags. This has been implemented > when the Standard Doclet is running without DocLint in > [JDK-8284030](https://bu

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

> Please review a simple patch to exclude preview visitor classes meant to > support future preview features from the Preview API page. > > The test adds an sample element annotated with the new > `PreviewFeature.Feature.LANGUAGE_MODEL` constant (which does not have a > `@JEP` annotation) to m

Re: RFR: 8332039: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null

On Thu, 30 May 2024 18:43:28 GMT, Pavel Rappo wrote: >> Please review a patch to fix a NPE thrown when a `@since` tag inherited by a >> nested class contains a nested inline tag. The solution is to make >> `CommentHelper.getDocTreePath(DocTree)` able to handle block tags inherited >> by nested