Re: RFR: 8331947: Preview creates checkbox for JEP-less preview feature [v4]

2024-06-03 Thread Chen Liang
On Fri, 31 May 2024 10:01:17 GMT, Hannes Wallnöfer wrote: >> Please review a simple patch to exclude preview visitor classes meant to >> support future preview features from the Preview API page. >> >> The test adds an sample element annotated with the new >> `PreviewFeature.Feature.LANGUAGE_

Re: RFR: 8332039: Cannot invoke "com.sun.source.util.DocTreePath.getTreePath()" because "path" is null

2024-06-03 Thread Hannes Wallnöfer
On Fri, 31 May 2024 20:58:31 GMT, Jonathan Gibbons wrote: > > To clarify, I'm not too concerned with how we call an action whereby a > > nested class gets its `@since` tag from the enclosing class; but yes, > > "inheritance" might not be ideal. What I'm concerned with is the fact that > > the

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v29]

2024-06-03 Thread psoujany
> The scrollable element `` with non-interactive content is not tabbable. > Grid columns in the javadoc stylesheet has overflow: auto, which is failing > Accessibility checks. > https://bugs.openjdk.org/browse/JDK-8325690 psoujany has updated the pull request incrementally with one additional co

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v28]

2024-06-03 Thread psoujany
> The scrollable element `` with non-interactive content is not tabbable. > Grid columns in the javadoc stylesheet has overflow: auto, which is failing > Accessibility checks. > https://bugs.openjdk.org/browse/JDK-8325690 psoujany has updated the pull request incrementally with one additional co

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v27]

2024-06-03 Thread psoujany
> The scrollable element `` with non-interactive content is not tabbable. > Grid columns in the javadoc stylesheet has overflow: auto, which is failing > Accessibility checks. > https://bugs.openjdk.org/browse/JDK-8325690 psoujany has updated the pull request incrementally with one additional co

Re: RFR: 8325168: JShell should support Markdown comments [v6]

2024-06-03 Thread Jan Lahoda
> This is an attempt to add Markdown support in documentation comments to > JShell. > > It works by converting the Markdown text to HTML during the process of > resolving `{@inheritDoc}` tags. Jan Lahoda has updated the pull request incrementally with one additional commit since the last revis

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v26]

2024-06-03 Thread psoujany
> The scrollable element `` with non-interactive content is not tabbable. > Grid columns in the javadoc stylesheet has overflow: auto, which is failing > Accessibility checks. > https://bugs.openjdk.org/browse/JDK-8325690 psoujany has updated the pull request incrementally with one additional co

Re: RFR: 8325690: The scrollable element with non-interactive content is not tabbable [v25]

2024-06-03 Thread psoujany
> The scrollable element `` with non-interactive content is not tabbable. > Grid columns in the javadoc stylesheet has overflow: auto, which is failing > Accessibility checks. > https://bugs.openjdk.org/browse/JDK-8325690 psoujany has updated the pull request with a new target base due to a merg