Re: RFR: 8322708: Global HTML attributes are not allowed [v5]

2024-06-18 Thread Jonathan Gibbons
On Fri, 14 Jun 2024 02:32:16 GMT, Nizar Benalla wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> whitespace > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line > 695: > >> 693:

Re: RFR: 8322708: Global HTML attributes are not allowed [v5]

2024-06-18 Thread Jonathan Gibbons
On Fri, 14 Jun 2024 19:16:26 GMT, Nizar Benalla wrote: >> Can I please get a review for this change, that aims to add support for >> Global HTML tags. >> Here is the >> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalPR/pkg1/package-summary.html) >> to the generated docs. >> Thanks in adv

Re: [jdk23] RFR: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk23] Integrated: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk23] RFR: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: [jdk23] RFR: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread Pavel Rappo
On Tue, 18 Jun 2024 11:12:41 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

[jdk23] RFR: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread SendaoYan
Hi all, This pull request contains a backport of commit [472b935b](https://github.com/openjdk/jdk/commit/472b935b442f7f925b665c7de91eda77f3dcbe8b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by SendaoYan on 18 Jun 2024 and was review

Re: RFR: 8334332: TestIOException.java fails if run by root [v4]

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan wrote: >> Hi all, >> Test >> `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run >> fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root use

Integrated: 8334332: TestIOException.java fails if run by root

2024-06-18 Thread SendaoYan
On Sat, 15 Jun 2024 09:07:04 GMT, SendaoYan wrote: > Hi all, > Test > `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run > fails with root user privileged. I think it's necessary to skip this testcase > when user is root. > Why run the jtreg test by root user? It'

Re: RFR: 8334332: TestIOException.java fails if run by root [v4]

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan wrote: >> Hi all, >> Test >> `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run >> fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root use

Re: RFR: 8334332: TestIOException.java fails if run by root [v4]

2024-06-18 Thread Pavel Rappo
On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan wrote: >> Hi all, >> Test >> `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run >> fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root use

Re: RFR: 8334332: TestIOException.java fails if run by root [v4]

2024-06-18 Thread Pavel Rappo
On Tue, 18 Jun 2024 07:43:23 GMT, SendaoYan wrote: >> Hi all, >> Test >> `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run >> fails with root user privileged. I think it's necessary to skip this >> testcase when user is root. >> Why run the jtreg test by root use

Re: RFR: 8334332: TestIOException.java fails if run by root [v2]

2024-06-18 Thread SendaoYan
On Tue, 18 Jun 2024 08:32:43 GMT, Pavel Rappo wrote: > > Does the `throw new Error(f + ": " + message);` should be replaced to > > `throw new SkippedException(f + ": " + message);`, to avoid report failure > > if a directory cannot be made read-only. > > Yes, it does! That's the whole point. I

Re: RFR: 8334332: TestIOException.java fails if run by root [v2]

2024-06-18 Thread Pavel Rappo
On Tue, 18 Jun 2024 01:26:33 GMT, SendaoYan wrote: > Does the `throw new Error(f + ": " + message);` should be replaced to `throw > new SkippedException(f + ": " + message);`, to avoid report failure if a > directory cannot be made read-only. Yes, it does! That's the whole point. Ironically, I

Re: RFR: 8334332: TestIOException.java fails if run by root [v4]

2024-06-18 Thread SendaoYan
> Hi all, > Test > `test/langtools/jdk/javadoc/doclet/testIOException/TestIOException.java` run > fails with root user privileged. I think it's necessary to skip this testcase > when user is root. > Why run the jtreg test by root user? It's because during rpmbuild process > for linux distri