Re: RFR: 8336036: Record equals Javadoc is incorrect for floating-point types

2024-07-10 Thread Liam Miller-Cushon
On Wed, 10 Jul 2024 23:24:43 GMT, Chen Liang wrote: > Fixes to Javadoc's default documentation on record classes, that all > primitives are compared as if with their wrapper classes' `compare` method by > default. This looks good to me, FWIW. Thanks for the fix! - PR Comment: htt

RFR: 8336036: Record equals Javadoc is incorrect for floating-point types

2024-07-10 Thread Chen Liang
Fixes to Javadoc's default documentation on record classes, that all primitives are compared as if with their wrapper classes' `compare` method by default. - Commit messages: - Fix tests - only link tags get escaped - tests - corresponding - 8336036: Record equals Javadoc is inc

Re: RFR: 8325369: @sealedGraph: Bad link to image for tag on nested classes

2024-07-10 Thread Jonathan Gibbons
On Wed, 10 Jul 2024 18:57:22 GMT, Chen Liang wrote: > Fixes the link to the generated sealed graph svg generated by the sealed > graph taglet. > > Affected interfaces includes > [`ClassFile.Option`](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8325369-nested-sealed-svg/api/java.base/java/lan

RFR: 8325369: @sealedGraph: Bad link to image for tag on nested classes

2024-07-10 Thread Chen Liang
Fixes the link to the generated sealed graph svg generated by the sealed graph taglet. Affected interfaces includes `ClassFile.Option`, `AnnotationValue.OfConstant`, a few nested interfaces in `Signature`, and `TypeAnnotaton.TargetInfo`. - Commit messages: - 8325369: @sealedGraph: