On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote:
> Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and
> erroneous links in the doc files.
This pull request has now been integrated.
Changeset: 908d1e92
Author:Chen Liang
URL:
https://git.openjdk.org/jdk/comm
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote:
> Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and
> erroneous links in the doc files.
Marked as reviewed by prappo (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20166#pullrequestreview-217806
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote:
> Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and
> erroneous links in the doc files.
Thanks for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/20166#issuecomment-2228806864
On Thu, 11 Jul 2024 16:19:49 GMT, Chen Liang wrote:
> Please review this build-only change that fixes the link to the SVG sealed
> graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
> documentation (as shown in #20122) and thus is backported.
This pull request has now been inte
On Thu, 11 Jul 2024 16:19:49 GMT, Chen Liang wrote:
> Please review this build-only change that fixes the link to the SVG sealed
> graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
> documentation (as shown in #20122) and thus is backported.
Thanks for the reviews!
--
On Thu, 11 Jul 2024 16:19:49 GMT, Chen Liang wrote:
> Please review this build-only change that fixes the link to the SVG sealed
> graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
> documentation (as shown in #20122) and thus is backported.
Marked as reviewed by prappo (Revie
> Please review this bugfix to the way the language of a snippet is determined
> and processed.
>
> The language of a snippet affects the form of snippet markup and enables
> external syntax highlighting, such as that provided by prism.js. The language
> of a snippet is
> [determined](https://
On Tue, 9 Jul 2024 21:13:45 GMT, Jonathan Gibbons wrote:
>> General comment: while the dust on `Path.getExtension` is still settling, as
>> a matter of policy, we should try and stay compatible with that. In
>> particular, a filename like `.gitignore` is a hidden filename with no
>> extension,
On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote:
> Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and
> erroneous links in the doc files.
Confirmed identical to original PR.
-
Marked as reviewed by iris (Reviewer).
PR Review: https://git.openjdk.org/jdk/
