Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Jonathan Gibbons
On Thu, 8 Aug 2024 09:47:58 GMT, Hannes Wallnöfer wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template >> line 239: >> >>> 237: link.addEventListener("click", (e) => { >>> 238: const href = e.currentTarget.getAttribut

Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Jonathan Gibbons
On Wed, 7 Aug 2024 15:49:01 GMT, Hannes Wallnöfer wrote: >> Please review a JavaDoc change to make it possible to link to type parameter >> documentation from automatically generated signatures as well as >> user-defined `{@link ...}` and `@see ...` tags. The solution consists in >> wrapping t

Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Jonathan Gibbons
On Thu, 8 Aug 2024 09:38:57 GMT, Hannes Wallnöfer wrote: > > Just from reading that alone, (and not reading code or sample output yet) > > that seems mildly questionable, in that we otherwise generally encourage > > the provision of `@param` tags for all parameters, whether they are > > type-l

Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Hannes Wallnöfer
On Thu, 8 Aug 2024 06:28:31 GMT, Hannes Wallnöfer wrote: > > One question/suggestion, perhaps for followup work. I get that you do not > > want the visual clutter of linking to locally defined type parameters, but > > would it help to give a short tooltip (i.e. `title` attribute) in this > > s

Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Hannes Wallnöfer
On Wed, 7 Aug 2024 21:04:08 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> More post-merge cleanup > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/sc

Re: RFR: 8313931: Javadoc: links to type parameters actually generate links to classes [v3]

2024-08-08 Thread Hannes Wallnöfer
On Wed, 7 Aug 2024 20:12:18 GMT, Jonathan Gibbons wrote: > Just from reading that alone, (and not reading code or sample output yet) > that seems mildly questionable, in that we otherwise generally encourage the > provision of `@param` tags for all parameters, whether they are type-level or >