Re: RFR: 8337111: Bad HTML checker for generated documentation [v4]

2024-09-04 Thread Nizar Benalla
On Wed, 4 Sep 2024 18:39:15 GMT, Nizar Benalla wrote: >> Can I please get a review for this PR that adds 4 new html "Checkers" for >> the generated documentation. >> More details are in the JBS issues >> >> These tests were mostly inspired /converted from the existing >> [Doccheck](https://git

Re: RFR: 8337111: Bad HTML checker for generated documentation [v4]

2024-09-04 Thread Nizar Benalla
> Can I please get a review for this PR that adds 4 new html "Checkers" for the > generated documentation. > More details are in the JBS issues > > These tests were mostly inspired /converted from the existing > [Doccheck](https://github.com/openjdk/doccheck). Nizar Benalla has updated the pull

Re: RFR: 8337111: Bad HTML checker for generated documentation [v3]

2024-09-04 Thread Nizar Benalla
> Can I please get a review for this PR that adds 4 new html "Checkers" for the > generated documentation. > More details are in the JBS issues > > These tests were mostly inspired /converted from the existing > [Doccheck](https://github.com/openjdk/doccheck). Nizar Benalla has updated the pull

Re: RFR: 8338133: Cleanup direct use of `new HtmlTree` [v3]

2024-09-04 Thread Jonathan Gibbons
> Please review an update to "clean up" the direct use of HtmlTree constructors. > > Hitherto, many/most instances of `HtmlTree` were created by static factory > methods. This update extends that convention. > In most cases, this is by providing either simple no-arg factory methods or > commonl

Re: RFR: 8338133: Cleanup direct use of `new HtmlTree` [v2]

2024-09-04 Thread Hannes Wallnöfer
On Tue, 3 Sep 2024 20:31:34 GMT, Jonathan Gibbons wrote: >> Please review an update to "clean up" the direct use of HtmlTree >> constructors. >> >> Hitherto, many/most instances of `HtmlTree` were created by static factory >> methods. This update extends that convention. >> In most cases, thi