Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v3]

2024-09-19 Thread David Holmes
On Thu, 19 Sep 2024 12:29:34 GMT, Maurizio Cimadamore wrote: > And I claim that this is outside the scope of this PR. And I strongly disagree because the only reason I conceded that this documentation issue need not be addressed by the CSR request for JEP 472 was because JDK-8338596 was filed

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v2]

2024-09-19 Thread Maurizio Cimadamore
On Thu, 19 Sep 2024 17:21:30 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move restricted method page to `java.lang` >> Update restricted method page > > src/java.base/share/classes/jav

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v3]

2024-09-19 Thread Maurizio Cimadamore
> This PR moves the section on restricted methods from the the javadoc of > `java.lang.foreign` package into a standalone static [javadoc > page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base/java/lang/foreign/doc-files/RestrictedMethods.html). > > This is

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v2]

2024-09-19 Thread Jorn Vernee
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore wrote: >> This PR moves the section on restricted methods from the the javadoc of >> `java.lang.foreign` package into a standalone static [javadoc >> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas

Integrated: 8339735: Remove references to Applet in core-libs/security APIs

2024-09-19 Thread Justin Lu
On Tue, 17 Sep 2024 23:14:16 GMT, Justin Lu wrote: > Please review this PR which removes occurrences of 'applet' within the > corelibs specification. Applet has been deprecated since JDK9, and may be a > confusing term for new Java developers, so it should be removed from the > documentation.

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-19 Thread Justin Lu
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v2]

2024-09-19 Thread Maurizio Cimadamore
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore wrote: >> This PR moves the section on restricted methods from the the javadoc of >> `java.lang.foreign` package into a standalone static [javadoc >> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v2]

2024-09-19 Thread Maurizio Cimadamore
On Thu, 19 Sep 2024 13:59:30 GMT, Maurizio Cimadamore wrote: >> This PR moves the section on restricted methods from the the javadoc of >> `java.lang.foreign` package into a standalone static [javadoc >> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.bas

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods [v2]

2024-09-19 Thread Maurizio Cimadamore
> This PR moves the section on restricted methods from the the javadoc of > `java.lang.foreign` package into a standalone static [javadoc > page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base/java/lang/foreign/doc-files/RestrictedMethods.html). > > This is

Re: RFR: 8338596: Clarify handling of restricted and caller-sensitive methods

2024-09-19 Thread Maurizio Cimadamore
On Thu, 19 Sep 2024 02:59:39 GMT, David Holmes wrote: > As I wrote in the CSR request for the JEP: > > > I think each method that is restricted and/or caller-sensitive should > > specify what happens when called when there is no caller context. We should > > use `AccessibleObject::canAccess` a

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

2024-09-19 Thread Sean Mullan
On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati