On Fri, 8 Nov 2024 13:49:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main cha
On Fri, 1 Nov 2024 18:06:47 GMT, Alexey Ivanov wrote:
> > I'd not looked at this test before but when I do the thing I noticed is
> > that createPrivateValue is no longer used. But I don't see a problem with
> > keeping the rest of the test.
>
> @prrace Do I understand correctly that _“`create
On Fri, 8 Nov 2024 13:49:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main cha
On Fri, 1 Nov 2024 20:26:45 GMT, Alexey Ivanov wrote:
>>> Is it intentional?
>>
>> It was probably by mistake. but you are right, I see it mentioned already in
>> the doc. I don't think we need to mention it again?
>
> It has a value… when it's mentioned with `@see`, the link is present in the
On Tue, 29 Oct 2024 17:06:08 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/MouseInfo.java line 68:
>>
>>> 66: * @throws SecurityException if a security manager exists and its
>>> 67: *{@code checkPermission} method doesn't allow the
>>> operation
>
On Fri, 8 Nov 2024 13:52:28 GMT, Nizar Benalla wrote:
>> Please review this patch to prevent links to private and package-private
>> members to be generated.
>> The bug happens when you link to private/package-private members, and
>> javadoc used to generated links to them (assuming they were i
On Fri, 8 Nov 2024 17:06:17 GMT, Hannes Wallnöfer wrote:
>> Please review a change to avoid generation of index items for comments
>> inherited from overridden methods. This affects `{@index}`,
>> `{@systemProperty}`, and `@spec` tags in both implicitly and explicitly doc
>> comments.
>>
>>
On Fri, 8 Nov 2024 16:58:52 GMT, Jan Lahoda wrote:
>> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be
>> a new preview language feature: `requires transitive java.base;`. It would
>> be good to show a warning box in the javadoc about the use of the feature.
>> This
On Fri, 8 Nov 2024 16:30:27 GMT, Pavel Rappo wrote:
> Also, I assume some doubling I see in the rightmost column will go away after
> #21765 has been integrated; correct?
>
> ```
> equivalence relation | java.lang.Object.equals(Object),
> java.lang.Object.equals(Object)
> ```
Yes, the second
> Please review a change to avoid generation of index items for comments
> inherited from overridden methods. This affects `{@index}`,
> `{@systemProperty}`, and `@spec` tags in both implicitly and explicitly doc
> comments.
>
> The change adds two additional means for avoiding generation of i
> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be a
> new preview language feature: `requires transitive java.base;`. It would be
> good to show a warning box in the javadoc about the use of the feature. This
> PR is attempting to add such a warning box.
>
> Given it
On Wed, 9 Oct 2024 17:49:23 GMT, Hannes Wallnöfer wrote:
> This change adds a conditional `search-tags.html` page to list all search
> tags defined by the `{@index ... }` tag. Since search tags work very similar
> to the `{@systemProperty ...}` tag and are internally represented by the same
>
On Fri, 8 Nov 2024 10:17:04 GMT, Jan Lahoda wrote:
>> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be
>> a new preview language feature: `requires transitive java.base;`. It would
>> be good to show a warning box in the javadoc about the use of the feature.
>> This
On Tue, 29 Oct 2024 14:51:53 GMT, Hannes Wallnöfer wrote:
> Please review a change to avoid generation of index items for comments
> inherited from overridden methods. This affects `{@index}`,
> `{@systemProperty}`, and `@spec` tags in both implicitly and explicitly doc
> comments.
>
> The c
> This is the implementation of JEP 486: Permanently Disable the Security
> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
> main changes in the JEP and also includes an apidiff of the specif
On Fri, 8 Nov 2024 13:52:28 GMT, Nizar Benalla wrote:
>> Please review this patch to prevent links to private and package-private
>> members to be generated.
>> The bug happens when you link to private/package-private members, and
>> javadoc used to generated links to them (assuming they were i
> Please review this patch to prevent links to private and package-private
> members to be generated.
> The bug happens when you link to private/package-private members, and javadoc
> used to generated links to them (assuming they were inherited because the
> holder is unreachable).
>
> Taking
> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be a
> new preview language feature: `requires transitive java.base;`. It would be
> good to show a warning box in the javadoc about the use of the feature. This
> PR is attempting to add such a warning box.
>
> Given it
On Wed, 16 Oct 2024 16:23:41 GMT, Nizar Benalla wrote:
> Can I get a review for this patch that adds `@since` checker tests to the
> following modules: java.compiler, jdk.compiler, jdk.javadoc and jdk.jdeps.
> The initial test for `java.base` has been integrated in
> [JDK-8331051](https://bugs
19 matches
Mail list logo
