Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread David Holmes
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread David Holmes
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 15:23:35 GMT, Jonathan Gibbons wrote: > The policy has long been to use Classpath Exception in the src and make > directories, but not in the test directories. If you're changing the policy, > you might want to check and update any documentation where the policy might > be

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Iris Clark
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Jonathan Gibbons
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Re: RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Abdelhak Zaaim
On Thu, 14 Nov 2024 12:22:36 GMT, Magnus Ihse Bursie wrote: > In several (most? all?) of the build system files, the copyright header > includes the classpath exception. This makes no sense, and should be removed. > > I have removed the classpath exception from makefiles, autoconf, shell > sc

Re: RFR: 8337111: Bad HTML checker for generated documentation

2024-11-14 Thread Nizar Benalla
On Thu, 14 Nov 2024 11:58:47 GMT, Hannes Wallnöfer wrote: >> Doccheck's human-generated reports are great at previewing a "chessboard" of >> results. Giving reader a quick glimpse at the quality/health of the >> documentation. But these tests needed to be automated and they didn't easily >> tr

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
On Thu, 14 Nov 2024 12:29:38 GMT, Christian Stein wrote: > Now `CheckManPageOptions` finds the `.md` file (good) and its checks fail > (bad). *sigh* > A candidate for an ignore list as fixing it is out of scope of this PR? Let me have a look at it first. It seems the test has the indention t

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Christian Stein
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

RFR: 8344191: Build code should not have classpath exception

2024-11-14 Thread Magnus Ihse Bursie
In several (most? all?) of the build system files, the copyright header includes the classpath exception. This makes no sense, and should be removed. I have removed the classpath exception from makefiles, autoconf, shell scripts, properties files, configuration files, IDE support files, build t

Re: RFR: 8337111: Bad HTML checker for generated documentation

2024-11-14 Thread Hannes Wallnöfer
On Mon, 4 Nov 2024 15:43:40 GMT, Nizar Benalla wrote: > Doccheck's human-generated reports are great at previewing a "chessboard" of > results. Giving reader a quick glimpse at the quality/health of the > documentation. But these tests needed to be automated and they didn't easily > translate

Integrated: 8343752: The javadoc should contain a note about usages of requires transitive java.base;

2024-11-14 Thread Jan Lahoda
On Thu, 7 Nov 2024 12:03:18 GMT, Jan Lahoda wrote: > When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be a > new preview language feature: `requires transitive java.base;`. It would be > good to show a warning box in the javadoc about the use of the feature. This > PR i

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
On Wed, 13 Nov 2024 21:55:53 GMT, Iris Clark wrote: >> src/java.base/share/man/java.md line 9: >> >>> 7: # published by the Free Software Foundation. Oracle designates this >>> 8: # particular file as subject to the "Classpath" exception as provided >>> 9: # by Oracle in the LICENSE file that a

Re: RFR: 8344056: Use markdown format for man pages [v2]

2024-11-14 Thread Magnus Ihse Bursie
> Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms of editing, we make changes to > the man pages in markdown and

Re: RFR: 8344056: Use markdown format for man pages

2024-11-14 Thread Daniel Fuchs
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote: > Currently, the man pages are stored as troff (a text format) in the open > repo, and a content-wise identical copy is stored as markdown (another text > format) in the closed repo. > > Since markdown is preferred to troff in terms o