Re: RFR: 8350920: Allow inherited member summaries to be viewed inline [v3]

2025-03-24 Thread Hannes Wallnöfer
> Please review an enhancement to allow switching between the traditional > condensed footnote-style summary and the summary table format for inherited > members (types, fields, methods and properties) that are inherited from > included types. You can test the feature in [the doc bundle I > upl

Re: RFR: 8352740: Introduce new factory method HtmlTree.IMG

2025-03-24 Thread Chen Liang
On Mon, 24 Mar 2025 17:08:32 GMT, Nizar Benalla wrote: > Please review this small patch to add a new factory method `HtmlTree > IMG(DocPath src, String alt)`, to provide a convenient way to reliably create > valid tree nodes. > > Previously, all uses of `HtmlTag.IMG` followed a similar pattern

Re: RFR: 8350920: Allow inherited member summaries to be viewed inline [v2]

2025-03-24 Thread Chen Liang
On Wed, 12 Mar 2025 16:25:42 GMT, Hannes Wallnöfer wrote: >> Please review an enhancement to allow switching between the traditional >> condensed footnote-style summary and the summary table format for inherited >> members (types, fields, methods and properties) that are inherited from >> incl

Re: RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index

2025-03-24 Thread Nizar Benalla
On Mon, 24 Mar 2025 16:09:20 GMT, Chen Liang wrote: >> Please review this patch to fix an issue in the `tag-search-index.js` >> generation. >> >> The problem was in the `toJSON()` method of `IndexItem`. When adding the >> description, it's using `escapeQuotes(description)` which only escapes

RFR: 8352740: Introduce new factory method HtmlTree.IMG

2025-03-24 Thread Nizar Benalla
Please review this small patch to add a new factory method `HtmlTree IMG(DocPath src, String alt)`, to provide a convenient way to reliably create valid tree nodes. Previously, all uses of `HtmlTag.IMG` followed a similar pattern : HtmlTree.of(HtmlTag.IMG) .put(HtmlAttr.

Re: RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index

2025-03-24 Thread Chen Liang
On Mon, 24 Mar 2025 16:14:54 GMT, Nizar Benalla wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/IndexItem.java >> line 645: >> >>> 643: if (!description.isEmpty()) { >>> 644: String normalizedDescription = >>> description.re

Re: RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index

2025-03-24 Thread Chen Liang
On Mon, 24 Mar 2025 14:41:43 GMT, Nizar Benalla wrote: > Please review this patch to fix an issue in the `tag-search-index.js` > generation. > > The problem was in the `toJSON()` method of `IndexItem`. When adding the > description, it's using `escapeQuotes(description)` which only escapes >

RFR: 8351332: Line breaks in search tag descriptions corrupt JSON search index

2025-03-24 Thread Nizar Benalla
Please review this patch to fix an issue in the `tag-search-index.js` generation. The problem was in the `toJSON()` method of `IndexItem`. When adding the description, it's using `escapeQuotes(description)` which only escapes backslashes and quotes, but doesn't normalize whitespace. TIA -