Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-21 Thread Alan Bateman
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-8356420](https://bugs.open

Re: RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-21 Thread Roger Riggs
On Wed, 21 May 2025 20:56:31 GMT, Volkan Yazici wrote: > There are several locations in the JDK source where `System.in` and > `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the > default charset. As recommended by the recently merged > [JDK-8356420](https://bugs.open

Re: RFR: 8357458: Missing Highlight.js license file [v2]

2025-05-21 Thread Hannes Wallnöfer
> Please review a change to add the missing license file for Highlight.js > required for the `--syntax-highlight` option. This also updates the tests for > legal files and library versions to handle the file correctly. Hannes Wallnöfer has updated the pull request incrementally with one addition

RFR: 8356893: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner

2025-05-21 Thread Volkan Yazici
There are several locations in the JDK source where `System.in` and `FileDescriptor.in` is read with `InputStreamReader` and `Scanner` using the default charset. As recommended by the recently merged [JDK-8356420](https://bugs.openjdk.org/browse/JDK-8356420), this PR replaces the default charse

Integrated: 8357452: Remove code span highlight in JavaDoc default stylesheet

2025-05-21 Thread Hannes Wallnöfer
On Wed, 21 May 2025 11:14:59 GMT, Hannes Wallnöfer wrote: > Please review a simple change to remove highlighting of code spans > (background and padding) in the default JavaDoc stylesheet. This pull request has now been integrated. Changeset: f1eead60 Author:Hannes Wallnöfer URL: h

Re: RFR: 8357452: Remove code span highlight in JavaDoc default stylesheet

2025-05-21 Thread Nizar Benalla
On Wed, 21 May 2025 11:14:59 GMT, Hannes Wallnöfer wrote: > Please review a simple change to remove highlighting of code spans > (background and padding) in the default JavaDoc stylesheet. I think this looks trivially good. - Marked as reviewed by nbenalla (Committer). PR Review:

Re: RFR: 8357452: Remove code span highlight in JavaDoc default stylesheet

2025-05-21 Thread Chen Liang
On Wed, 21 May 2025 11:14:59 GMT, Hannes Wallnöfer wrote: > Please review a simple change to remove highlighting of code spans > (background and padding) in the default JavaDoc stylesheet. Marked as reviewed by liach (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25349#

Re: RFR: 8357452: Remove code span highlight in JavaDoc default stylesheet

2025-05-21 Thread Jonathan Gibbons
On Wed, 21 May 2025 11:14:59 GMT, Hannes Wallnöfer wrote: > Please review a simple change to remove highlighting of code spans > (background and padding) in the default JavaDoc stylesheet. Marked as reviewed by jjg (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25349#pu

Integrated: 8338833: Error on reference not found for a snippet target

2025-05-21 Thread Hannes Wallnöfer
On Tue, 20 May 2025 13:49:37 GMT, Hannes Wallnöfer wrote: > Please review a trivial fix to generate an error when a link in a snippet has > an invalid target. This pull request has now been integrated. Changeset: 254713ab Author:Hannes Wallnöfer URL: https://git.openjdk.org/jdk/com

Re: RFR: 8338833: Error on reference not found for a snippet target [v2]

2025-05-21 Thread Pavel Rappo
On Wed, 21 May 2025 10:06:36 GMT, Hannes Wallnöfer wrote: >> Please review a trivial fix to generate an error when a link in a snippet >> has an invalid target. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Remove as

RFR: 8357458: Missing Highlight.js license file

2025-05-21 Thread Hannes Wallnöfer
Please review a change to add the missing license file for Highlight.js required for the `--syntax-highlight` option. This also updates the tests for legal files and library versions to handle the file correctly. - Commit messages: - 8357458: Missing Highlight.js license file Chan

RFR: 8357452: Remove code span highlight in JavaDoc default stylesheet

2025-05-21 Thread Hannes Wallnöfer
Please review a simple change to remove highlighting of code spans (background and padding) in the default JavaDoc stylesheet. - Commit messages: - 8357452: Remove code span highlight in JavaDoc default stylesheet Changes: https://git.openjdk.org/jdk/pull/25349/files Webrev: http

Re: RFR: 8338833: Error on reference not found for a snippet target [v2]

2025-05-21 Thread Hannes Wallnöfer
On Wed, 21 May 2025 07:35:12 GMT, Pavel Rappo wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove assert that prevents invalid tag markup and rename variable > > Marked as reviewed by prappo (Reviewer). Tha

Re: RFR: 8338833: Error on reference not found for a snippet target [v2]

2025-05-21 Thread Hannes Wallnöfer
> Please review a trivial fix to generate an error when a link in a snippet has > an invalid target. Hannes Wallnöfer has updated the pull request incrementally with one additional commit since the last revision: Remove assert that prevents invalid tag markup and rename variable

Re: RFR: 8338833: Error on reference not found for a snippet target

2025-05-21 Thread Pavel Rappo
On Tue, 20 May 2025 13:49:37 GMT, Hannes Wallnöfer wrote: > Please review a trivial fix to generate an error when a link in a snippet has > an invalid target. Marked as reviewed by prappo (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/25329#pullrequestreview-2856632833