Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Phil Race
On Wed, 18 Jun 2025 14:45:32 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 460: > >> 458: SliderDemo.

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]

2025-06-18 Thread Damon Nguyen
On Tue, 17 Jun 2025 23:15:05 GMT, Justin Lu wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove double quotes > > src/jdk.jdi/share/classes/com/sun/tools/example/debug/tty/TTYResources_de.java > line 2: > >> 1

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v3]

2025-06-18 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: remove double quotes - Changes:

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Naoto Sato
On Wed, 18 Jun 2025 09:47:57 GMT, Joel Sikström wrote: > Should the other localizations for the launcher help text (in > `launcher_.properties`) also be updated? I see that only the German, > Japanese and Chinese localizations have been updated so far. Those languages (de/ja/zh-CN) are the one

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Alexey Ivanov
On Wed, 18 Jun 2025 16:25:29 GMT, Justin Lu wrote: >> src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1: >> >>> 1: # Copyright (c) 2010, 2022, Oracle and/or its affiliates. All rights >>> reserved. >> >> Shall the copyright year be updated? > > In the past, we usually don't

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Justin Lu
On Wed, 18 Jun 2025 15:34:38 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/demo/share/jfc/SwingSet2/resources/swingset_de.properties line 1: > >> 1: # Copyright (c)

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Justin Lu
On Wed, 18 Jun 2025 15:28:49 GMT, Alexey Ivanov wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix unicode escapes > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > line 56:

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Alexey Ivanov
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Joel Sikström
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-18 Thread Nizar Benalla
On Tue, 17 Jun 2025 23:34:52 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26

2025-06-18 Thread SendaoYan
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote: > Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved, > JavaBaseCheckSince no longer needs to be problemlisted. Marked as reviewed by syan (Committer). - PR Review: https://git.openjdk.org/jdk/pull/25855#p

RFR: 8358627: tools/sincechecker/modules/java.base/JavaBaseCheckSince.java fails with JDK 26

2025-06-18 Thread Nizar Benalla
Once [8346295](https://bugs.openjdk.org/browse/JDK-8346295) is resolved, JavaBaseCheckSince no longer needs to be problemlisted. - Depends on: https://git.openjdk.org/jdk/pull/25854 Commit messages: - this test no longer needs to be problem listed Changes: https://git.openjdk.org/