Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-25 Thread Christian Stein
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-25 Thread Damon Nguyen
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-25 Thread Justin Lu
On Tue, 24 Jun 2025 14:58:38 GMT, Weijun Wang wrote: >> However, there is no space required between two Chinese sentences. In >> English, we usually write "I am here, and you are there." But in Chinese, >> with the full-width punctuation, it's always "我在这里,你在那里。". > > Some people like to insert

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-25 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with one additional commit since the last revision: revert german translation, revert english wxl fo

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v7]

2025-06-25 Thread Justin Lu
On Wed, 25 Jun 2025 21:28:16 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the las

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]

2025-06-25 Thread Justin Lu
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with three additional > commits since the

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]

2025-06-25 Thread Alisen Chung
On Wed, 25 Jun 2025 17:08:20 GMT, Alisen Chung wrote: >> This issue is responsible for updating the translations of all the >> localize(able) resources in the JDK since the previous L10n drop. > > Alisen Chung has updated the pull request incrementally with three additional > commits since the

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-25 Thread Christian Stein
On Mon, 23 Jun 2025 19:04:22 GMT, Alexey Ivanov wrote: >> If "major tick" is translated to "Hauptteilstrich", then the plural would be >> `[SliderDemo.majorticks=]Hauptteilstriche` (which is a rather artificial >> word so the translation team might want to come up with a better translation >>

Re: RFR: 8360307: Problemlist tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java

2025-06-25 Thread David Holmes
On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai wrote: > Can I please get a review of this problemlisting change which problem lists > the > `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` > test? This test has been failing regularly in our CI in tier2. > > I ha

Re: RFR: 8177100: APIs duplicated in JavaDoc [v8]

2025-06-25 Thread Chen Liang
On Tue, 24 Jun 2025 10:32:51 GMT, Nizar Benalla wrote: >> Please review this patch to fix a bug where a method can be documented >> multiple times >> Consider these 4 classes >> >> A (interface) >>/ \ >> / \ >> (abstract class)

Re: RFR: 8360307: Problemlist tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java

2025-06-25 Thread Jaikiran Pai
On Tue, 24 Jun 2025 04:29:16 GMT, Jaikiran Pai wrote: > Can I please get a review of this problemlisting change which problem lists > the > `tools/sincechecker/modules/jdk.management.jfr/JdkManagementJfrCheckSince.java` > test? This test has been failing regularly in our CI in tier2. > > I ha

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-25 Thread Damon Nguyen
On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang wrote: >> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update to german translations > > src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties > l

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v2]

2025-06-25 Thread Weijun Wang
On Wed, 18 Jun 2025 16:43:02 GMT, Alexey Ivanov wrote: >> There is still only one space, the new one is a full width colon (U+FF1A). >> Localization rules have been observed to make the switch from regular colons >> (U+003A) into the full width version depending on the language. > > Thank you f

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-25 Thread Alisen Chung
On Wed, 25 Jun 2025 16:59:09 GMT, Justin Lu wrote: >> I checked the ASCII codes here and on the source file. The updated colons >> are localized to full-width colons as @justin-curtis-lu mentioned in another >> thread here. >> >> I agree. I also believe lines 48 & 49 need to be updated to the

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v6]

2025-06-25 Thread Alisen Chung
> This issue is responsible for updating the translations of all the > localize(able) resources in the JDK since the previous L10n drop. Alisen Chung has updated the pull request incrementally with three additional commits since the last revision: - update majorticks translation - Merge branc

Re: RFR: 8359761: JDK 25 RDP1 L10n resource files update [v4]

2025-06-25 Thread Justin Lu
On Wed, 25 Jun 2025 00:27:48 GMT, Damon Nguyen wrote: >> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties >> line 49: >> >>> 47: .Principal.=\t主用户:\u0020 >>> 48: .Public.Credential.=\t公共身份证明:\u0020 >>> 49: .Private.Credential.=\t专用身份证明:\u0020 >> >> Why aren't t