On Sat, 18 Mar 2023 17:46:00 GMT, Archie L. Cobbs wrote:
> The fix for JDK-8015831, which added the new `this-escape` lint warning,
> caused the build of the `bootcycle-images` make target to fail.
>
> This commit adds the additional `@SuppressWarnings("this-escape")`
&
The fix for JDK-8015831, which added the new `this-escape` lint warning, caused
the build of the `bootcycle-images` make target to fail.
This commit adds the additional `@SuppressWarnings("this-escape")` annotations
needed to fix it.
-
Commit messages:
- Add @SuppressWarnings("thi
On Thu, 23 Feb 2023 09:04:23 GMT, Justin Lu wrote:
> This PR converts Unicode sequences to UTF-8 native in .properties file.
> (Excluding the Unicode space and tab sequence). The conversion was done using
> native2ascii.
>
> In addition, the build logic is adjusted to support reading in the
>
On Thu, 16 Feb 2023 21:32:44 GMT, Archie L. Cobbs wrote:
> Some javac unit tests aren't reliably closing open files. Many were written
> prior to (or without utilizing) try-with-resources.
>
> Leaving files and other resources open can cause problems during automated
> bu
On Sat, 25 Feb 2023 19:06:49 GMT, Andrey Turbanov wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove extra whitespace.
>
> test/langtools/tools/javac/T8071847/T8071847.ja
s to use try-with-resource.
>
> Side note: there is at least one unit test that intentionally leaves a file
> open - `diags/examples/ProcUnclosedTypeFiles/processors/AnnoProc.java`.
Archie L. Cobbs has updated the pull request incrementally with one additional
commit since the last r
Some javac unit tests aren't reliably closing open files. Many were written
prior to (or without utilizing) try-with-resources.
Leaving files and other resources open can cause problems during automated
builds, etc.
This patch updates these tests to use try-with-resource.
Side note: there is a
re/classes/java/util/HashSet.java`
> * `src/java.base/share/classes/java/util/Hashtable.java`
> * `src/java.base/share/classes/java/util/LinkedList.java`
> * `src/java.base/share/classes/java/util/TreeMap.java`
> * `src/java.base/share/classes/java/util/TreeSet.java`
>
&
On Sat, 7 Jan 2023 18:03:04 GMT, Alan Bateman wrote:
> I don't think the implementation notes should be included as part of the
> adding the lint warning as I think it creates an attractive nuisance.
I agree with you - not only for that reason, but also because as others have
pointed out the a
re/classes/java/util/HashSet.java`
> * `src/java.base/share/classes/java/util/Hashtable.java`
> * `src/java.base/share/classes/java/util/LinkedList.java`
> * `src/java.base/share/classes/java/util/TreeMap.java`
> * `src/java.base/share/classes/java/util/TreeSet.java`
>
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote:
>>> The associated JBS issue has been dormant for 6+ years and this is a very
>>> intrusive change affecting many, many files. Has the resurrection of this
>>> project previously been discussed somewhere?
>>
>> Hi @dholmes-ora,
>>
>> The wo
re/classes/java/util/HashSet.java`
> * `src/java.base/share/classes/java/util/Hashtable.java`
> * `src/java.base/share/classes/java/util/LinkedList.java`
> * `src/java.base/share/classes/java/util/TreeMap.java`
> * `src/java.base/share/classes/java/util/TreeSet.java`
>
&
On Fri, 6 Jan 2023 04:48:27 GMT, David Holmes wrote:
> The associated JBS issue has been dormant for 6+ years and this is a very
> intrusive change affecting many, many files. Has the resurrection of this
> project previously been discussed somewhere?
Hi @dholmes-ora,
The work to add this war
This PR adds a new lint warning category `this-escape`.
It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
allow the JDK to continue to compile with `-Xlint:all`.
A 'this' escape warning is generated for a constructor `A()` in a class `A`
when the compiler detects that
On Mon, 19 Dec 2022 20:56:14 GMT, Jonathan Gibbons wrote:
> Please review a fix for the golden-file for a test, required after quotes in
> resources were fixed in JDK-8298943.
Oops - my fault. Thanks for fixing.
-
PR: https://git.openjdk.org/jdk/pull/11732
15 matches
Mail list logo
