Re: RFR: 8311043: Remove trailing blank lines in source files

2023-06-30 Thread Daniel D . Daugherty
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote: > Remove trailing "blank" lines in source files. > > I like to use global-whitespace-cleanup-mode, but I can not use it if the > files are "dirty" to begin with. This fix will make more files "clean". I > also considered adding a check for t

Integrated: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-12-06 Thread Daniel D . Daugherty
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty wrote: > Misc stress testing related fixes: > > [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for > another JLI GetObjectSizeIntrinsicsTest.java subtest > [JDK-8297367](https://bugs.openjdk

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-12-02 Thread Daniel D . Daugherty
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty wrote: > Misc stress testing related fixes: > > [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for > another JLI GetObjectSizeIntrinsicsTest.java subtest > [JDK-8297367](https://bugs.openjdk

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-30 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes wrote: >> @jonathan-gibbons - Thanks for the review! >> >> I could not find an @requires incantation for saying >> do-not-use-slowdebug-bits >> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with >> @requires so I could be mi

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-30 Thread Daniel D . Daugherty
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty wrote: > Misc stress testing related fixes: > > [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for > another JLI GetObjectSizeIntrinsicsTest.java subtest > [JDK-8297367](https://bugs.openjdk

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-30 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes wrote: >> @jonathan-gibbons - Thanks for the review! >> >> I could not find an @requires incantation for saying >> do-not-use-slowdebug-bits >> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with >> @requires so I could be mi

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Tue, 22 Nov 2022 23:17:24 GMT, Jonathan Gibbons wrote: >> Misc stress testing related fixes: >> >> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout >> for another JLI GetObjectSizeIntrinsicsTest.java subtest >> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-829736

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 02:28:02 GMT, Chris Plummer wrote: > Do you plan on closing the CRs associated with these changes even though the > root causes are not being addressed, just avoided? These two CRs are like ProblemListing bugs: [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367): dis

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 17:51:20 GMT, Leonid Mesnik wrote: >> Misc stress testing related fixes: >> >> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout >> for another JLI GetObjectSizeIntrinsicsTest.java subtest >> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367)

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 00:05:54 GMT, Serguei Spitsyn wrote: >> Does langtools have its own test libraries that I can use to ask the same >> questions? > > Sorry, I was not clear. > The Fuzz.java has this order: > > +import jdk.test.lib.Platform; > +import jtreg.SkippedException; > > I thought, yo

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes wrote: >> @jonathan-gibbons - Thanks for the review! >> >> I could not find an @requires incantation for saying >> do-not-use-slowdebug-bits >> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with >> @requires so I could be mi

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-29 Thread Daniel D . Daugherty
On Tue, 22 Nov 2022 19:43:38 GMT, Serguei Spitsyn wrote: >> Misc stress testing related fixes: >> >> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout >> for another JLI GetObjectSizeIntrinsicsTest.java subtest >> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-22 Thread Daniel D . Daugherty
On Tue, 22 Nov 2022 23:15:48 GMT, Jonathan Gibbons wrote: >> Why? 'jdk' comes before 'jtreg' and 'Platform' comes before >> 'SkippedException'. >> What am I missing here? > > Mild grumble: langtools tests do not rely on jdk test libraries Does langtools have its own test libraries that I can us

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-22 Thread Daniel D . Daugherty
On Tue, 22 Nov 2022 23:17:24 GMT, Jonathan Gibbons wrote: >> Misc stress testing related fixes: >> >> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout >> for another JLI GetObjectSizeIntrinsicsTest.java subtest >> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-829736

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-22 Thread Daniel D . Daugherty
On Tue, 22 Nov 2022 19:43:38 GMT, Serguei Spitsyn wrote: >> Misc stress testing related fixes: >> >> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout >> for another JLI GetObjectSizeIntrinsicsTest.java subtest >> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367

RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-11-22 Thread Daniel D . Daugherty
Misc stress testing related fixes: [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367) disable TestRedirectLinks.java in slowdebug mode [JDK-8297369](https://

Re: RFR: 8290489: Initial nroff manpage generation for JDK 20

2022-07-20 Thread Daniel D . Daugherty
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote: > The version will be 20-ea and the copyright year 2023 (for March 2023 release > date). > > Thanks. Thumbs up. This is a trivial change. - Marked as reviewed by dcubed (Reviewer). PR: https://git.openjdk.org/jdk/pull/9581

Integrated: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. This pull request has now been integrated. Changeset: 9c19d89c Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/9c19d89c9c564e436732c5f7851f4960fb5d783c Stats: 504 li

Re: RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
On Wed, 20 Jul 2022 22:20:31 GMT, Daniel D. Daugherty wrote: > Merge jdk19 -> jdk20. Mach5 Tier1 passed. - PR: https://git.openjdk.org/jdk/pull/9578

RFR: Merge jdk19

2022-07-20 Thread Daniel D . Daugherty
Merge jdk19 -> jdk20. - Commit messages: - Merge - 8290625: Test jdk/javadoc/tool/CheckManPageOptions.java after manpage update - 8278274: Update nroff pages in JDK 19 before RC - 8287916: Address the inconsistency between the constant array and pool size - 8285407: Improve Xalan