On Mon, 11 Mar 2024 13:53:57 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Mon, 11 Mar 2024 13:13:07 GMT, Chen Liang wrote:
> The 2-D array case is broken: currently source code `@A int @B [] @C []` is
> compiled to `@A int @C [] @B []` in both class file and javadoc output, so I
> don't want to add a buggy case that needs to be updated if this annotation
> placem
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote:
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
This test case has a two-dimensional array with annotations. But the tests of
your patch don't have such case. It is good to add it.
-
PR Commen
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote:
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.annotation.*;
>
> public
On Thu, 7 Mar 2024 14:29:39 GMT, Hannes Wallnöfer wrote:
> Please review a simple fix to make sure inline tags are always closed in
> summary tables, even when the tags are closed after the first sentence in the
> original doc comment.
>
> I decided to colocate the functionality to track open
On Fri, 8 Mar 2024 11:09:50 GMT, Hannes Wallnöfer wrote:
>> test/langtools/jdk/javadoc/doclet/testBreakIterator/TestBreakIterator.java
>> line 83:
>>
>>> 81: """
>>> 82: Inline tags >> href="../index-all.html">extending
>>> 83: beyond the
On Thu, 7 Mar 2024 14:29:39 GMT, Hannes Wallnöfer wrote:
> Please review a simple fix to make sure inline tags are always closed in
> summary tables, even when the tags are closed after the first sentence in the
> original doc comment.
>
> I decided to colocate the functionality to track open
On Tue, 9 May 2023 14:44:43 GMT, Jonathan Gibbons wrote:
>>> Overall, I would expect `newline` to be set `false`earlier, maybe in
>>> `blockTag`, so that the setting applies to all block tags. That might still
>>> leave the possibility of a newline happening after the tag name and before
>>> t
On Tue, 9 May 2023 14:01:43 GMT, Guoxiong Li wrote:
> Hi all,
>
> When invoking the method `DocCommentParser::quotedString` with field
> `newline` as `true`
> and the quoted string has the character `@`, `quotedString` will break the
> loop and return `null`.
> This pa
ning of the
> method `quotedString`
> to solve this issue. And a corresponding test case is added.
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request incrementally with one additional
commit since the l
On Fri, 12 May 2023 21:15:50 GMT, Jonathan Gibbons wrote:
> It would be better to set the `newline` flag to false earlier, perhaps at the
> beginning of `blockTag`
Fixed.
> Here is another test case:
>
> ```
> /**
> * case 2.
> * @see
> *"{@code ...}"
> */
> pu
On Fri, 12 May 2023 21:32:55 GMT, Jonathan Gibbons wrote:
>> test/langtools/tools/javac/doctree/SeeTest.java line 59:
>>
>>> 57: * @see "{@code}"
>>> 58: */
>>> 59: void at_sign_in_quote_string() { }
>>
>> (minor) add `d` after `quote` in method name
>
> Also, add a test case for
ning of the
> method `quotedString`
> to solve this issue. And a corresponding test case is added.
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
Guoxiong Li has updated the pull request incrementally with two additional
commits since the last revision:
-
On Tue, 9 May 2023 14:17:59 GMT, Jonathan Gibbons wrote:
> Overall, I would expect `newline` to be set `false`earlier, maybe in
> `blockTag`, so that the setting applies to all block tags. That might still
> leave the possibility of a newline happening after the tag name and before
> the quote
Hi all,
When invoking the method `DocCommentParser::quotedString` with field `newline`
as `true`
and the quoted string has the character `@`, `quotedString` will break the loop
and return `null`.
This patch changes the field `newline` to `false` at the beginning of the
method `quotedString`
to
16 matches
Mail list logo
