Re: RFR: 8359760: Remove the jdk.jsobject module [v2]

On Tue, 22 Jul 2025 19:53:39 GMT, Kevin Rushforth wrote: >> This PR removes the terminally-deprecated `jdk.jsobject` module from the >> JDK. This module is now shipped with JavaFX, and has been since JavaFX 24. >> >> The following files still reference `jdk.jsobject` (or the >> `netscape.javas

Re: RFR: 8344056: Use markdown format for man pages [v4]

On Fri, 15 Nov 2024 14:50:21 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages [v2]

On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in te

Re: RFR: 8344056: Use markdown format for man pages

On Wed, 13 Nov 2024 21:27:02 GMT, David Holmes wrote: >> Currently, the man pages are stored as troff (a text format) in the open >> repo, and a content-wise identical copy is stored as markdown (another text >> format) in the closed repo. >> >> Since markdown is preferred to troff in terms of

Re: RFR: 8339735: Remove references to Applet in core-libs/security APIs [v2]

On Wed, 18 Sep 2024 17:59:40 GMT, Justin Lu wrote: >> Please review this PR which removes occurrences of 'applet' within the >> corelibs specification. Applet has been deprecated since JDK9, and may be a >> confusing term for new Java developers, so it should be removed from the >> documentati

Re: [jdk23] RFR: 8325280: Update troff manpages in JDK 23 before RC

On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote: > Before RC we need to update the man pages in the repo from their Markdown > sources. All pages at a minimum have 23-ea replaced with 23, and publication > year set to 2024 if needed. > > This also picks up the unpublished changes to java.

Re: [jdk23] RFR: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation

On Fri, 12 Jul 2024 23:38:31 GMT, Chen Liang wrote: > Please review the backport of #20145 onto jdk23, fixing 2 unnecessary and > erroneous links in the doc files. Confirmed identical to original PR. - Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/jdk/

Re: RFR: 8330205: Initial troff manpage generation for JDK 24

On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote: > Sets the version to 24/24-ea and the copyright year to 2025. > > Content changes related to the start of release (e.g. for removed options in > java.1) are handled separately. > > This initial generation also picks up the unpublished chan

Re: RFR: 8330704: Clean up non-standard use of /** comments in some langtools tests

On Mon, 22 Apr 2024 18:02:39 GMT, Jonathan Gibbons wrote: > Please review a simple change to clean up inappropriate use of `/**` comments > in test code -- most notably to enclose the `jtreg` test description. > > There is no change to the functionality of any test, and (obviously) all > tests

Re: [jdk22] RFR: 8322066: Update troff manpages in JDK 22 before RC

On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote: > This update drops the "ea" from the version string. > > We also propagate the following fixes from the markdown sources to the troff > manpage file: > > JDK-8322478: Update java manpage for multi-file source-code launcher > JDK-8302233: HS

Re: RFR: JDK-8317693: Unused parameter to Tokens.Token.comment method

On Fri, 6 Oct 2023 23:39:27 GMT, Jonathan Gibbons wrote: > Please review a simple cleanup to eliminate an unused parameter and rename > the enclosing method. > > No new tests; bug is primarily `noreg-cleanup`. Two tests were affected by > the change, but are not in themselves tests for the cha

Re: RFR: 8314762: Make {@Incubating} conventional

On Tue, 22 Aug 2023 12:19:42 GMT, Pavel Rappo wrote: > Please review this trivial PR. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/15387#pullrequestreview-1593932872

Re: [jdk21] RFR: 8312572: JDK 21 RDP2 L10n resource files update

On Wed, 2 Aug 2023 17:03:40 GMT, Justin Lu wrote: > Please review this PR (L10N translation update), which is a backport of > commit > [9b55e9a7](https://github.com/openjdk/jdk/commit/9b55e9a706de9893b1a71c7a6a4e23c4b8842f18) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >

Re: [jdk21] RFR: 8300937: Update nroff pages in JDK 21 before RC

On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote: > Main changes are to use 21 instead of 21-ea. In addition the following files > contain additional updates from the closed sources: > > - src/java.base/share/man/java.1 > > [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Updat

Re: RFR: JDK-8306952: improve generic signature of internal DCInlineTag class

On Wed, 26 Apr 2023 21:03:16 GMT, Jonathan Gibbons wrote: > Please review a small update to the generic signature of the internal > `DCInlineTag` class, to improve its use in chained method calls. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull

Re: RFR: JDK-8305620: Missing `break` in DocCommentParser `inlineWord()`

On Tue, 4 Apr 2023 23:58:28 GMT, Jonathan Gibbons wrote: > Please review a fix for the `depth` counting in `DocCommentParser` > `inlineWord`. > There was a missing break that caused the count to go high, and because of > that the code for the down count needed to be adjusted as well. > > The t

Re: RFR: JDK-8305094: typo (missing *) in doc comment

On Tue, 28 Mar 2023 16:34:29 GMT, Jonathan Gibbons wrote: > Please review a trivial patch to fix a typo in a recent update Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13210#pullrequestreview-1361894459

Re: RFR: JDK-8305004: add @spec tags to langtools modules

On Tue, 28 Mar 2023 02:26:49 GMT, Jonathan Gibbons wrote: > Please review a simple doc-only PR to add `@spec` tags to 3 "langtools" > modules, for eventual use in an "External Specifications" page. Marked as reviewed by iris (Reviewer). - PR Review: https://git.openjdk.org/jdk/pul

Re: RFR: 8301813: Bad caret position in error message

On Fri, 3 Feb 2023 22:56:58 GMT, Jonathan Gibbons wrote: > Please review a trivial update to `DocCommentParser` and corresponding > updates to tests, to fix the caret position in the two forms of the "no tag > name found" error message. > > The fix is simply to use the overload of `erroneous`

Re: RFR: 8290918: Initial nroff manpage generation for JDK 21

On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by iris (Reviewer). -

Re: [jdk20] RFR: 8290919: Update nroff pages in JDK 20 before RC

On Mon, 23 Jan 2023 02:59:42 GMT, David Holmes wrote: > There was one missing update in javac.1 from: > > [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate > -profile option in javac > > otherwise the change is limited to dropping the "-ea". > > Thanks. Marked as reviewed

Re: RFR: 8297695: Fix typos in test/langtools files

On Mon, 28 Nov 2022 10:06:45 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which fixes some typos in the > `test/langtools` files? This was originally raised by @mernst in > https://github.com/openjdk/jdk/pull/10029, but given that the other PR > touches multiple other ar

Re: RFR: JDK-8295914: Add a header to generated HTML files in specs

On Thu, 27 Oct 2022 20:50:04 GMT, Jonathan Gibbons wrote: > Please review some updates to the parts of the build system related to > building the documentation. Your changes look good! Can't wait to see this in a promotion. - Marked as reviewed by iris (Reviewer). PR: https://gi

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-6251738: Want a top-level summary page that itemizes all spec documents referenced from javadocs (OEM spec) [v14]

On Tue, 3 May 2022 13:22:05 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 22 commits: >> >> - Fix merge issue >> - Merge remote-tracking branch 'upstream/master' into 6251738.spec-ta

Re: RFR: 8289562: Change bugs.java.com and bugreport.java.com URL's to https

On Mon, 11 Jul 2022 08:04:20 GMT, Joe wrote: > 8289562: Change bugs.java.com and bugreport.java.com URL's to https Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.org/jdk/pull/9445

Re: RFR: JDK-8288533: Missing @param tags in com.sun.source classes

On Wed, 15 Jun 2022 21:42:07 GMT, Jonathan Gibbons wrote: > Please review a noreg-doc fix to add some missing `@param` tags in the > `com.sun.source` API. The added text is boilerplate taken from similar > classes. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.