On Tue, 7 May 2024 17:31:29 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 1 May 2024 20:40:00 GMT, Jonathan Gibbons wrote:
> > There should be some quick testing of the new default method on Elements
> > using the VacuousElements implementation; see
> > `test/langtools/tools/javac/processing/model/util/elements` for some
> > examples.
>
> @jddarcy I've
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
Marked as reviewed by darcy (Reviewer).
> This PR is standalone as opposed to dependent because the #18787
On Fri, 26 Apr 2024 11:05:03 GMT, Nizar Benalla wrote:
> This PR aims to add `@since` tags in elements in both `jdk.compiler` and
> `java.compiler`.
> A lot of these changes have to do with handling of preview features.
>
> The existing rules for handling of `@since` for preview elements:
> -
On Thu, 11 Apr 2024 17:52:14 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote:
> This update drops the "ea" from the version string.
>
> We also propagate the following fixes from the markdown sources to the troff
> manpage file:
>
> JDK-8322478: Update java manpage for multi-file source-code launcher
> JDK-8302233:
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial
On Wed, 13 Dec 2023 10:44:43 GMT, Hannes Wallnöfer wrote:
> > Should this issue have a CSR for the behavioral change?
>
> My understanding of the issue is that the lookup of explicit-class member
> references in enclosing classes was an unintended consequence of doing the
> same for classless
On Wed, 6 Dec 2023 21:09:40 GMT, Joe Darcy wrote:
> Simple test fix ahead of the fork.
This pull request has now been integrated.
Changeset: 781775d7
Author: Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/781775d73b4dd0b241870be50c921242f561b8a1
Stats: 1 line in 1 f
Simple test fix ahead of the fork.
-
Commit messages:
- JDK-8321484: Make TestImplicitlyDeclaredClasses release independent
Changes: https://git.openjdk.org/jdk/pull/17003/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=17003=00
Issue:
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 28 Nov 2023 15:00:43 GMT, Jim Laskey wrote:
>> test/langtools/tools/javac/ImplicitClass/TestImplicitClass.java line 35:
>>
>>> 33: import java.lang.reflect.Modifier;
>>> 34:
>>> 35: public class TestImplicitClass {
>>
>> The test looks to be testing core reflection behavior (i.e.
On Wed, 29 Nov 2023 15:25:15 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 28 Nov 2023 14:43:13 GMT, Pavel Rappo wrote:
>> Please review this PR to support _JEP 463 Implicitly Declared Classes and
>> Instance Main Method (Second Preview)_ in JavaDoc.
>>
>> [JEP 463](https://openjdk.org/jeps/463) is the next iteration of [JEP
>>
On Fri, 24 Nov 2023 12:56:40 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 17:42:48 GMT, Jim Laskey wrote:
>> `UNNAMED_CLASSES` should probably be removed, as I think it is fully
>> replaced with `IMPLICIT_CLASSES`, and I don't think there are bootstrap
>> problems here (unlike in `jdk.internal.java.PreviewFeature`). I would say it
>> would make
On Tue, 21 Nov 2023 10:38:36 GMT, Pavel Rappo wrote:
>> Look at the spec https://bugs.openjdk.org/browse/JDK-8319252 under 7.3
>> Compilation Units.
>>
>> - It is not abstract (8.1.1.1 ⇗).
>> - It is final (8.1.1.2 ⇗).
>> - It is a member of an unnamed package (7.4.2 ⇗) and **has package
On Thu, 2 Nov 2023 11:58:23 GMT, Jim Laskey wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove .orig files
>
> Re .orig. Thank you Alan.
@JimLaskey , please "/issue add JDK-8319133" to include the annotation
On Fri, 14 Jul 2023 14:00:44 GMT, Jim Laskey wrote:
> Update javadoc man page to indicate unnamed classes are supported.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk21/pull/130#pullrequestreview-1530461335
On Wed, 21 Jun 2023 19:00:19 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to provide a previously-missing `@since` tag
> for `StandardDoclet`
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/14603#pullrequestreview-1491649140
On Thu, 16 Feb 2023 21:32:44 GMT, Archie L. Cobbs wrote:
> Some javac unit tests aren't reliably closing open files. Many were written
> prior to (or without utilizing) try-with-resources.
>
> Leaving files and other resources open can cause problems during automated
> builds, etc.
>
> This
On Wed, 1 Feb 2023 19:09:21 GMT, Pavel Rappo wrote:
>> This makes jdk.javadoc compare javax.lang.model primitives correctly:
>> elements with `Object.equals` and type mirrors with `Types.isSameType`.
>>
>> jdk.javadoc sometimes compares elements using identity comparison (`==`) and
>> type
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
Marked as reviewed by darcy (Reviewer).
On Tue, 13 Dec 2022 22:27:05 GMT, Jonathan Gibbons wrote:
> Please review a trivial fix to a long-standing copy-paste typo.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/28
On Tue, 13 Dec 2022 14:27:37 GMT, Per Minborg wrote:
> This PR proposes adding hyperlinks to the sealed graphic layout making
> navigation much simpler via the image.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk20/pull/23
On Thu, 8 Dec 2022 16:21:30 GMT, Pavel Rappo wrote:
>> This PR proposes adding hyperlinks to the sealed graphic layout making
>> navigation much simpler via the image.
>
> Given that this feature is welcome, I would suggest changing the priority of
> the respective JBS issue to P3, withdrawing
On Tue, 18 Oct 2022 11:55:06 GMT, Magnus Ihse Bursie wrote:
> This is a continuation of the effort to update all our URLs to the new
> top-level domain.
>
> This patch updates (most) URLs in testing code. There still exists references
> to openjdk.java.net, but that are not strictly used as
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote:
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
This pull
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update make directory.
>
> src/jdk.accessibility/windows/native/include/bridge/AccessBrid
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote:
> > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> > might warrant a separate PR..?
>
> Filed a few follow-up bugs:
>
> JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbre
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Filed a few follow-up bugs:
JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella)
JDK-829472
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote:
> This is correct. AccessBridge.h is published with the include/header files of
> the JDK and anyone reading it there can't exactly make use of "../"
Update to persistent git links.
-
PR: https://git.openjdk.org/jdk/pull/10501
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote:
> Also, FWIW, there are 100+ hits in `test` as well. But that is so many it
> might warrant a separate PR..?
Yes; I think it is sufficient to update src and doc with this PR.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request with a new target
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote:
> Switch to https where needed/applicable while at it?
Good idea; might as well do the update in a single changeset.
-
PR: https://git.openjdk.org/jdk/pull/10501
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with o
> With the domain change from openjdk.java.net to openjdk.org, references to
> URLs in the sources should be updated.
>
> Updates were made using a shell script. I"ll run a copyright updater before
> any push.
Joe Darcy has updated the pull request incrementally with two
With the domain change from openjdk.java.net to openjdk.org, references to URLs
in the sources should be updated.
Updates were made using a shell script. I"ll run a copyright updater before any
push.
-
Commit messages:
- JDK-8294618: Update openjdk.java.net => openjdk.org
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote:
> Update to remove support for -source/-target/--release 7 from javac.
>
> As seen in the PR, many test fails are affected. Further refactorings of
> javac's implementation that can be made from dropping 7 support are left as
&
> Update to remove support for -source/-target/--release 7 from javac.
>
> As seen in the PR, many test fails are affected. Further refactorings of
> javac's implementation that can be made from dropping 7 support are left as
> future work.
Joe Darcy has updated the pull req
On Wed, 31 Aug 2022 17:13:04 GMT, Vicente Romero wrote:
> the PR looks good to me. You have mentioned that further refactorings could
> be done later on, I agree but you are already removing a lot of code,
> although that could have been forced to make some tests pass. I would
> recommend
On Tue, 30 Aug 2022 06:26:25 GMT, Alan Bateman wrote:
>> Update to remove support for -source/-target/--release 7 from javac.
>>
>> As seen in the PR, many test fails are affected. Further refactorings of
>> javac's implementation that can be made from dropping 7 support are left as
>> future
On Tue, 30 Aug 2022 00:16:09 GMT, Joe Darcy wrote:
> Please also review the accompanying CSR:
>
> https://bugs.openjdk.org/browse/JDK-8293047
>
> Note that the DEFAULT_METHODS enum constant is used indirectly by a test to
> force a class file's minor version bits to be s
On Tue, 30 Aug 2022 00:04:03 GMT, Joe Darcy wrote:
> Update to remove support for -source/-target/--release 7 from javac.
>
> As seen in the PR, many test fails are affected. Further refactorings of
> javac's implementation that can be made from dropping 7 support are left as
&
Update to remove support for -source/-target/--release 7 from javac.
As seen in the PR, many test fails are affected. Further refactorings of
javac's implementation that can be made from dropping 7 support are left as
future work.
-
Commit messages:
- Small refactoring to remove
On Wed, 22 Jun 2022 20:00:24 GMT, Jonathan Gibbons wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
>
On Wed, 22 Jun 2022 19:47:53 GMT, Jonathan Gibbons wrote:
> Please review a trivial update to correct the values of the @since tags from
> a recent commit
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/9250
On Wed, 15 Jun 2022 21:42:07 GMT, Jonathan Gibbons wrote:
> Please review a noreg-doc fix to add some missing `@param` tags in the
> `com.sun.source` API. The added text is boilerplate taken from similar
> classes.
Marked as reviewed by darcy (Reviewer).
-
PR:
53 matches
Mail list logo
