Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Hannes Wallnöfer
On Fri, 26 Apr 2024 18:05:14 GMT, Jonathan Gibbons wrote: > The feature is good, but I'm surprised to see it being tested in > DocLintTest.java. I admit I took a shortcut there, using `DocLintTest` for something it wasn't meant to do. The test had to be updated anyway, and it had both the inva

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Jonathan Gibbons
On Fri, 26 Apr 2024 16:40:33 GMT, Pavel Rappo wrote: > The feature is good, but I'm surprised to see it being tested in > DocLintTest.java. Yeah, good point. The message should be generated independently of any doclint settings. - PR Comment: https://git.openjdk.org/jdk/pull/189

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Jonathan Gibbons
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote: > Please review a change to print a terminal message if the documentation > generated by `HtmlDoclet` contains any diagnostic marker elements for invalid > input. The message is printed after the documentation has been generated and > b

Re: RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Pavel Rappo
On Fri, 26 Apr 2024 15:14:04 GMT, Hannes Wallnöfer wrote: > Please review a change to print a terminal message if the documentation > generated by `HtmlDoclet` contains any diagnostic marker elements for invalid > input. The message is printed after the documentation has been generated and > b

RFR: 8296175: Output warning if generated docs contain diagnostic markers

2024-04-26 Thread Hannes Wallnöfer
Please review a change to print a terminal message if the documentation generated by `HtmlDoclet` contains any diagnostic marker elements for invalid input. The message is printed after the documentation has been generated and before the error/warning count with the purpose to let the user know