On Mon, 26 Aug 2024 12:32:11 GMT, Pavel Rappo wrote:
>> I can change it back.
>> By the way I only see it used in the codebase once
>> [here](https://github.com/openjdk/jdk/blob/20d8f58c92009a46dfb91b951e7d87b4cb8e8b41/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L254)
>>
On Mon, 26 Aug 2024 11:15:53 GMT, Nizar Benalla wrote:
> I can change it back. By the way I only see it used in the codebase once
> [here](https://github.com/openjdk/jdk/blob/20d8f58c92009a46dfb91b951e7d87b4cb8e8b41/src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java#L254)
> wher
On Mon, 26 Aug 2024 10:23:07 GMT, Pavel Rappo wrote:
>> Fixed in
>> [e24bbd8](https://github.com/openjdk/jdk/pull/20618/commits/e24bbd8d6c1f55f2e43ad453703c26105d0b4e7a),
>> thanks.
>
> @nizarbenalla have you checked that the help output is rendered correctly
> after you changed backticks to s
On Mon, 26 Aug 2024 10:32:49 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> - replace backticks with single quotes
>> - drop use of underscores
>> - capitalize first letter for "doclet"
>
> s
On Thu, 22 Aug 2024 18:11:16 GMT, Nizar Benalla wrote:
>> Could I please get a review for this small clenup? I updated the `--help`
>> command output to match that of `man javadoc`.
>>
>> I also noticed that `--help-extended` was renamed to `--help-extra` at some
>> point but doc-comment was
On Thu, 22 Aug 2024 18:08:11 GMT, Nizar Benalla wrote:
>> They should not be removed/deleted. They could be replaced with single
>> quotes `'` but IIRC they sometimes? have to be doubled in properties files.
>
> Fixed in
> [e24bbd8](https://github.com/openjdk/jdk/pull/20618/commits/e24bbd8d6c1f
On Tue, 20 Aug 2024 14:43:24 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/standard.properties
>> line 481:
>>
>>> 479:
>>> 480: doclet.usage.docfilessubdirs.description=\
>>> 481: Enables deep copying of `doc-files` direc
> Could I please get a review for this small clenup? I updated the `--help`
> command output to match that of `man javadoc`.
>
> I also noticed that `--help-extended` was renamed to `--help-extra` at some
> point but doc-comment was not changed, so I changed it.
> I could create a separate issu
