Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-05 Thread Pavel Rappo
On Thu, 4 Apr 2024 21:21:58 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriter.java >> line 200: >> >>> 198: content.add(heading); >>> 199: return HtmlTree.SECTION(HtmlStyle.detail, content) >>> 200:

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Jonathan Gibbons
On Thu, 4 Apr 2024 21:52:20 GMT, Pavel Rappo wrote: >> If you use `forMember` on an `ExecutableElement` whose enclosing element is >> an annotation type interface, you know there cannot be any type parameters. > > Right, but some accommodation/special-casing for annotations will be there >

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Pavel Rappo
On Thu, 4 Apr 2024 21:31:03 GMT, Jonathan Gibbons wrote: >> True, type parameters are not an issue for annotation interface methods, >> which [are not allowed to have any parameters][], type or otherwise. >> However, the code that prints annotations for method signatures does not >> know that

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Jonathan Gibbons
On Thu, 4 Apr 2024 21:20:19 GMT, Pavel Rappo wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java >> line 567: >> >>> 565: var methods = >>> vmt.getVisibleMembers(VisibleMemberTable.Kind.METHODS); >>> 566: // for whatever reason

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Pavel Rappo
On Thu, 4 Apr 2024 18:52:42 GMT, Jonathan Gibbons wrote: >> Pavel Rappo has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to feedback > >

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Jonathan Gibbons
On Thu, 4 Apr 2024 12:28:23 GMT, Pavel Rappo wrote: >> Creating a link to a constructor or a method or comparing constructors or >> methods __does not__ factor in type parameters. When constructors or methods >> are overloaded and differ only in type parameters -- a situation which is >>

Re: RFR: 8325088: Overloads that differ in type parameters may be lost [v4]

2024-04-04 Thread Pavel Rappo
> Creating a link to a constructor or a method or comparing constructors or > methods __does not__ factor in type parameters. When constructors or methods > are overloaded and differ only in type parameters -- a situation which is > absent in JDK API, but present elsewhere -- that causes