Re: RFR: JDK-8289332: Auto-generate ids for user-defined headings [v2]

2022-08-17 Thread Jonathan Gibbons
On Wed, 17 Aug 2022 14:27:05 GMT, Hannes Wallnöfer wrote: >> This is a simple change to automatically generate `id` attributes for HTML >> headers in documentation comments. >> >> I decided to leave the functionality in `HtmlDocletWriter` rather than >> moving it to `HtmlIds` because it uses

Re: RFR: JDK-8289332: Auto-generate ids for user-defined headings

2022-08-17 Thread Hannes Wallnöfer
On Mon, 25 Jul 2022 15:10:36 GMT, Hannes Wallnöfer wrote: > This is a simple change to automatically generate `id` attributes for HTML > headers in documentation comments. > > I decided to leave the functionality in `HtmlDocletWriter` rather than moving > it to `HtmlIds` because it uses the s

Re: RFR: JDK-8289332: Auto-generate ids for user-defined headings [v2]

2022-08-17 Thread Hannes Wallnöfer
> This is a simple change to automatically generate `id` attributes for HTML > headers in documentation comments. > > I decided to leave the functionality in `HtmlDocletWriter` rather than moving > it to `HtmlIds` because it uses the same helper methods > as`commentTagsToContent`. > > The val

Re: RFR: JDK-8289332: Auto-generate ids for user-defined headings [v2]

2022-08-17 Thread Hannes Wallnöfer
On Tue, 16 Aug 2022 19:58:52 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove trailing whitespace >> - Address review feedback >> >> - Make sure hasIdAttribute is safe >>

Re: RFR: JDK-8289332: Auto-generate ids for user-defined headings

2022-08-16 Thread Jonathan Gibbons
On Mon, 25 Jul 2022 15:10:36 GMT, Hannes Wallnöfer wrote: > This is a simple change to automatically generate `id` attributes for HTML > headers in documentation comments. > > I decided to leave the functionality in `HtmlDocletWriter` rather than moving > it to `HtmlIds` because it uses the s

RFR: JDK-8289332: Auto-generate ids for user-defined headings

2022-07-26 Thread Hannes Wallnöfer
This is a simple change to automatically generate `id` attributes for HTML headers in documentation comments. I decided to leave the functionality in `HtmlDocletWriter` rather than moving it to `HtmlIds` because it uses the same helper methods as`commentTagsToContent`. The value of the `id` a