Re: RFR: JDK-8295914: Add a header to generated HTML files in specs [v2]

2022-11-01 Thread Erik Joelsson
On Mon, 31 Oct 2022 23:23:44 GMT, Jonathan Gibbons wrote: >> Please review some updates to the parts of the build system related to >> building the documentation. > > Jonathan Gibbons has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev exclud

Re: RFR: JDK-8295914: Add a header to generated HTML files in specs [v2]

2022-10-31 Thread Jonathan Gibbons
> Please review some updates to the parts of the build system related to > building the documentation. Jonathan Gibbons has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull

Re: RFR: JDK-8295914: Add a header to generated HTML files in specs

2022-10-31 Thread Jonathan Gibbons
On Fri, 28 Oct 2022 13:46:27 GMT, Erik Joelsson wrote: >> Please review some updates to the parts of the build system related to >> building the documentation. > > make/Docs.gmk line 598: > >> 596: # Unset the following to suppress the link to the tool guides >> 597: NAV_LINK_GUIDES = --nav

Re: RFR: JDK-8295914: Add a header to generated HTML files in specs

2022-10-31 Thread Iris Clark
On Thu, 27 Oct 2022 20:50:04 GMT, Jonathan Gibbons wrote: > Please review some updates to the parts of the build system related to > building the documentation. Your changes look good! Can't wait to see this in a promotion. - Marked as reviewed by iris (Reviewer). PR: https://gi

Re: RFR: JDK-8295914: Add a header to generated HTML files in specs

2022-10-28 Thread Erik Joelsson
On Thu, 27 Oct 2022 20:50:04 GMT, Jonathan Gibbons wrote: > Please review some updates to the parts of the build system related to > building the documentation. Build changes look fine in general. make/Docs.gmk line 598: > 596: # Unset the following to suppress the link to the tool guides >

RFR: JDK-8295914: Add a header to generated HTML files in specs

2022-10-27 Thread Jonathan Gibbons
Please review some updates to the parts of the build system related to building the documentation. - Commit messages: - JDK-8295914: Add a header to generated HTML files in specs Changes: https://git.openjdk.org/jdk/pull/10891/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr