I tried to do this around noon on Sunday and cvs head was not compiling...
I didn't have too much time to look into it, so I'll give this another
shot later on this week.
-- Guillaume
-Original Message-
From: Guillaume Boissiere [mailto:[EMAIL PROTECTED]]
Sent: Thursday, February
Submitted By: Guillaume Boissiere (boissier)
Assigned to: Nobody/Anonymous (nobody)
Summary: Remove dead imports from jboss-all
Initial Comment:
Would you believe that there are 2065 lines of
import x.y.z; where the class is imported but not used?
I put together a script that parses through
Yes, it does improve significantly the build time. When I put together
the patch back in November, the speedup was close to 10% if I remember
correctly.
Cool. I will rerun the script this week-end and commit it.
Cheers,
-- Guillaume
-Original Message-
From: Adam Heath
Yes, I added those lines and kept them commented because there are some
new classes in 1.4, like java.sql.SavePoint, so it would break uncommented
for 1.3.
The only way to get around it would be to use import java.sql.*; instead
but it's not usually recommended, so I left it that way.
--
User: boissier
Date: 01/12/05 14:29:59
Modified:src/main/org/jboss/deployment/scope Scope.java
Log:
Added some Javadoc
Revision ChangesPath
1.6 +79 -33jboss/src/main/org/jboss/deployment/scope/Scope.java
Index: Scope.java
User: boissier
Date: 01/12/05 15:45:09
Modified:src/main/org/jboss Shutdown.java Version.java
Log:
Added some Javadoc
Revision ChangesPath
1.6 +7 -4 jboss/src/main/org/jboss/Shutdown.java
Index: Shutdown.java
User: boissier
Date: 01/12/04 10:05:25
Modified:src/main/org/jboss/util/timeout TimeoutFactory.java
Log:
* Replace the method private assert(boolean expr) by private assertExpr(boolean
expr) to avoid conflicts with the new assert keyword in JDK 1.4.
Revision ChangesPath
User: boissier
Date: 01/12/04 10:36:47
Modified:src/main/org/jboss/test/bank/interfaces BankException.java
Log:
* In JDK 1.4, the Throwable interface has a new method:
public Throwable getCause()
This causes a conflict with the file BankException.java.
This patch fixes
User: boissier
Date: 01/12/04 11:01:14
Modified:src/main/org/jboss/resource/adapter/jdbc/local
ConnectionInPool.java PreparedStatementInPool.java
ResultSetInPool.java StatementInPool.java
Log:
* In JDK 1.4, the interfaces
User: boissier
Date: 01/12/04 11:08:59
Modified:src/main/org/jboss/test/util TestConnection.java
Log:
* In JDK 1.4, the interface java.sql.Connection has new 12 methods.
The patch below adds those methods to TestConnection.java
to make the project compile, but keep them
User: boissier
Date: 01/12/04 14:34:02
Modified:src/main/org/jbossmx/cluster/watchdog/util
MirroringService.java
Log:
* Remove some unnecessary String creations, because String objects are
immutable, so using new String(x) always results in extra
User: boissier
Date: 01/12/04 14:34:02
Modified:src/main/org/jbossmx/cluster/watchdog/mbean Watchdog.java
Log:
* Remove some unnecessary String creations, because String objects are
immutable, so using new String(x) always results in extra overhead.
Revision Changes
This patch removes all the annoying compile warnings about
java.security.Identity being deprecated since EJB 1.1 but the patch is so
simple that it probably breaks something otherwise someone would have done
this a long time ago...
... or not?
Is Rabbit-Hole supposed to support EJB 1.0? Can
As a reference point, a build on the latest checkout worked for me.
But 'build clobber' fails as it tries to delete build.log (this is
JDK 1.3.1_01 on Win2k).
-- Guillaume
...
_configure-tasks:
_init-show-environment:
clean:
clobber:
[execmodules]
==
== Finished with 'clobber' in
I sent a big patch about a month ago [#475080] that was removing all the
unused import lines from the code. I did not get any feedback on it so I am
resending it, this time on a subset of the code (only the /server directory
from jboss-all).
The patch is at http://www.boissiere.com/diff.txt
I created a small program in Java to do this. I'd be happy to make this
into an ant task. How would you like this to be structured?
-- Guillaume
How did you create this? What would be even better is an ant task to use
in a build target.
Anyone mind if I commit this?
david jencks
Perusing through the code, I saw the following variations for the service
names of MBeans in JBoss:
- no prefix, i.e :service=Mail
- EJB prefix, i.e EJB:service=
- JBOSS-SYSTEM prefix i.e JBOSS-SYSTEM:service=Info
- J2EE prefix i.e J2EE:service=J2eeDeployer
Are there any specific rules for the
: Friday, November 02, 2001 10:36 PM
To: Guillaume Boissiere; [EMAIL PROTECTED]
Subject: Re: [JBoss-dev] OBJECT_NAME rules
Hi
Your are right but Object Names rules are:
Domain Name:[key=value],...
Right now JBoss does not use the Object Name capabilities fully
one part you can see
Title: RE: [JBoss-dev] Fwd: ests on different OS'es
I agree. Without going overboard, it'd be great to set some specific milestones regarding the
quality of the code and documentation that need to be met for 3.0 final release (i.e. has to
pass the test suite with no errors, all public
19 matches
Mail list logo
