Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Alex Loubyansky
parameters there is no differences AFAI see). > > Thanx - Andy > > - Original Message - > From: "Alex Loubyansky" <[EMAIL PROTECTED]> > To: "JBoss-Dev" <[EMAIL PROTECTED]> > Sent: Friday, August 16, 2002 12:54 PM > Subj

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Andreas Schaefer
oss-Dev" <[EMAIL PROTECTED]> Sent: Friday, August 16, 2002 12:54 PM Subject: [JBoss-dev] JCAConnectionFactory undeployment bug and patch > Hello guys, > > there is a bug in JCAConnectionFactory undeployment (I guess in all > 3.0 branches). Here are the details (I played with M

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Andreas Schaefer
Hi Dain I don't know what this is all about but what you want would looks like this: ObjectName lServer = null; try { Set lServers = pServer.queryNames( new ObjectName( J2EEManagedObject.getDomainName() + ":" + J2EEManagedObject.TYPE + "=" + J2EEServer.J2EE_TYPE

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Dain Sundstrom
That is not the point david. It is normal case for the code to return an empty set; it is in the java docs. He should check for it. Exceptions are only for exceptional cases not regular program flow. He is being lazy. If he coded it correctly in the first place it would not need a comment.

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread David Jencks
A comment might make it clearer what is going on, but I think Andy is right-- if the query returns, there will be an element in it, so the iterator().next() is sure to succeed. The exception would come from executing the query -- right? david On 2002.08.16 19:35:35 -0400 Andreas Schaefer wrote:

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Dain Sundstrom
Andreas Schaefer wrote: > Hi Dain > > >>That is no excuse. The exceptional case is the MBeanServer is having >>issues. So to quote you "get off your fat ass". This code is >>confusing, and just plane wrong. Fix it. > > > No, it is an exception when no server is available therefore this >

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Andreas Schaefer
Hi Dain > That is no excuse. The exceptional case is the MBeanServer is having > issues. So to quote you "get off your fat ass". This code is > confusing, and just plane wrong. Fix it. No, it is an exception when no server is available therefore this is correct or do you check every String

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Dain Sundstrom
: "Dain Sundstrom" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Friday, August 16, 2002 2:45 PM > Subject: Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch > > > >>Alex Loubyansky wrote: >> >>>Obje

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Andreas Schaefer
- Original Message - From: "Dain Sundstrom" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Friday, August 16, 2002 2:45 PM Subject: Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch > Alex Loubyansky wrote: > > ObjectName lServer = null; > &g

Re: [JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Dain Sundstrom
Alex Loubyansky wrote: > ObjectName lServer = null; > try { >lServer = (ObjectName) pServer.queryNames( > new ObjectName( > J2EEManagedObject.getDomainName() + ":" + > J2EEManagedObject.TYPE + "=" + J2EEServer.J2EE_TYPE + "," + > "*" > ), > null >

[JBoss-dev] JCAConnectionFactory undeployment bug and patch

2002-08-16 Thread Alex Loubyansky
Hello guys, there is a bug in JCAConnectionFactory undeployment (I guess in all 3.0 branches). Here are the details (I played with MySQL). When it is created the J2EEManagedObject is created with a name like: J2EEServer=Local,JCAResource=JCA,j2eeType=JCAConnectionFactory,name=MySqlDS-LocalTxCM B