Changeset: fec31f67f89f
Author:coffeys
Date: 2012-06-06 16:19 +0100
URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/fec31f67f89f
7174440: JDK6-open build breakage
Reviewed-by: andrew, ohair
! src/windows/native/sun/windows/awt_Window.cpp
! test/java/awt/Dialog/CrashXCheckJni/Cras
- Original Message -
> It was more or less to change Sun -> Oracle.
>
Yeah, I see that, but the copyright should be 2008 not 2012, as that's when the
changes were made.
> thanks for reviewing.
No problem. Sorry for causing the build failure.
Here's to an open test system so patches ca
It was more or less to change Sun -> Oracle.
thanks for reviewing.
regards,
Sean.
On 06/06/12 14:19, Andrew Hughes wrote:
The code change looks ok from comparing the 6& 7 versions. I'm not sure
why you're changing the copyright to 2012 when no changes have been made in
2012.
- Original Message -
> I'd like to push the following change which should fix the awt code
> to allow 6open build on windows again.
>
> http://cr.openjdk.java.net/~coffeys/webrev.7174440.6open/
>
> Builds & tests ok.
>
> regards,
> Sean.
>
The code change looks ok from comparing the 6 &
- Original Message -
> Looks like not all of the jdk7 changes from 6610244 made the jdk
> push.
>
> See (jdk7)
> http://hg.openjdk.java.net/jdk7/jdk7/jdk/diff/58c90502785d/src/windows/native/sun/windows/awt_Window.cpp
>
> versus (jdk6)
>
> http://hg.openjdk.java.net/jdk6/jdk6/jdk/diff/93
- Original Message -
> On 5/30/12 5:53 PM, Andrew Hughes wrote:
> > In other words, does this also mean Oracle won't approve changes by
> > others
> > or make releases, or just that they won't contribute changes? If
> > so, can
> > someone else take over this role?
>
> I'd expect the Ope