Re: CR 7071826 - code review & push request

2012-06-08 Thread Mike Duigou
Looks good On May 25 2012, at 04:39 , Seán Coffey wrote: > this is a port of jdk7u fix to the openjdk6 repo. > > webrev : http://cr.openjdk.java.net/~coffeys/webrev.7071826.jdk6/ > 7u discussion/review thread : > http://mail.openjdk.java.net/pipermail/jdk7u-dev/2012-May/002990.html > > regards,

Re: [BACKPORT] 7140882: Don't return booleans from methods returning pointers

2012-06-08 Thread Kelly O'Hair
Approved. -kto On Jun 8, 2012, at 6:40 AM, Andrew Hughes wrote: > This is another build fix for OpenJDK6, this time related to gcc 4.7. > With this and the next patch, I'm able to build OpenJDK6 again :-) > > The webrev is here: > > http://cr.openjdk.java.net/~andrew/openjdk6/7140882/webrev.01

[BACKPORT] 7140882: Don't return booleans from methods returning pointers

2012-06-08 Thread Andrew Hughes
This is another build fix for OpenJDK6, this time related to gcc 4.7. With this and the next patch, I'm able to build OpenJDK6 again :-) The webrev is here: http://cr.openjdk.java.net/~andrew/openjdk6/7140882/webrev.01/ and it differs from http://hg.openjdk.java.net/jdk7u/jdk7u/hotspot/rev/f457