[PATCH FOR REVIEW] OPENJDK6-3: Fix small memory leak in get_stack_bounds

2013-03-20 Thread Andrew Hughes
A small memory leak was found in get_stack_bounds when getline returned with an error code, but it was fixed in OpenJDK 7 & 8 in a way that introduced worse issues: http://mail.openjdk.java.net/pipermail/hotspot-dev/2013-February/008695.html This webrev adds a simpler fix, just adding the necess

Re: The future of OpenJDK6

2013-03-20 Thread Andrew Hughes
- Original Message - > On 20/03/2013 14:28, Andrew Hughes wrote: > > : > > http://cr.openjdk.java.net/~andrew/jdk6/copymemory/webrev.01/ > > > > The patched version of OpenJDK6 can build Snappy. > I wonder if the @since should be changed. > > -Alan > I'd be happy to just drop that line

Re: The future of OpenJDK6

2013-03-20 Thread Andrew Haley
On 03/20/2013 02:28 PM, Andrew Hughes wrote: > http://cr.openjdk.java.net/~andrew/jdk6/copymemory/webrev.01/ > > The patched version of OpenJDK6 can build Snappy. That's great, thanks. Andrew.

Re: The future of OpenJDK6

2013-03-20 Thread Alan Bateman
On 20/03/2013 14:28, Andrew Hughes wrote: : http://cr.openjdk.java.net/~andrew/jdk6/copymemory/webrev.01/ The patched version of OpenJDK6 can build Snappy. I wonder if the @since should be changed. -Alan

Re: The future of OpenJDK6

2013-03-20 Thread Andrew Hughes
- Original Message - > On 03/14/2013 04:42 PM, Alex Kasko wrote: > >> > But if upstream won't do that, I'll accept a patch that > >> > re- enables copyMemory. > > The code part of the patch (without comments) is: > > > > - public native void copyMemory(long srcAddress, long > > destA

Re: The future of OpenJDK6

2013-03-20 Thread Andrew Haley
On 03/14/2013 04:42 PM, Alex Kasko wrote: >> > But if upstream won't do that, I'll accept a patch that >> > re- enables copyMemory. > The code part of the patch (without comments) is: > > - public native void copyMemory(long srcAddress, long destAddress, > long bytes); > + public native v