Re: [7u4] Code Review Request for CR 7145980 - Dispose method of window.java takes long

2012-02-28 Thread Artem Ananiev
Hi, Oleg, since you haven't provided a link to the webrev, I assume the fix is a straightforward backport from JDK8, correct? I don't see any problems with it then. Thanks, Artem On 2/24/2012 12:36 PM, Oleg Pekhovskiy wrote: Hi! Please review the fix to push for CR: http://bugs.sun.com/vi

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Artem Ananiev
On 2/28/2012 10:56 AM, Anthony Petrov wrote: On 2/28/2012 10:05 PM, Artem Ananiev wrote: 1. On X11, we don't have any other toolkits than XToolkit, so I don't see any point in checking the AWT_TOOLKIT var on X11. A custom toolkit may be specified via the -Dawt.toolkit= argument. The AWT_TOOLK

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
On 2/28/2012 10:05 PM, Artem Ananiev wrote: 1. On X11, we don't have any other toolkits than XToolkit, so I don't see any point in checking the AWT_TOOLKIT var on X11. A custom toolkit may be specified via the -Dawt.toolkit= argument. The AWT_TOOLKIT env var must override this setting. Therefor

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Artem Ananiev
On 2/28/2012 9:32 AM, Anthony Petrov wrote: Hi Artem, Thanks for the review. Please find my comments below. On 2/28/2012 9:22 PM, Artem Ananiev wrote: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ contains changes to the awt_LoadLibrary.c file only. I have provided

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
Hi Artem, Thanks for the review. Please find my comments below. On 2/28/2012 9:22 PM, Artem Ananiev wrote: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ contains changes to the awt_LoadLibrary.c file only. I have provided a link to the webrev for 7124511 as a referenc

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Artem Ananiev
Hi, Anthony, On 2/28/2012 2:47 AM, Anthony Petrov wrote: Hi Artem, I believe you've clicked the wrong link. My webrev at yes, it really sounds like I looked into another webrev... http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ contains changes to the awt_LoadLibrar

Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Sean Mullan
On 2/28/12 11:21 AM, Chris Hegarty wrote: > [cc'ing security-dev@o.j.n, they may be able to suggest a suitable > alternative, supported, API to use]. I would recommend they implement the functionality entirely in the OpenDS product. X500Signer is a very simple class and can be implemented using t

Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Chris Hegarty
[cc'ing security-dev@o.j.n, they may be able to suggest a suitable alternative, supported, API to use]. -Chris. On 02/28/12 04:22 PM, Seán Coffey wrote: The issue would lie with the OpenDS team then. They need to update their code and use supported JDK APIs. regards, Sean. On 28/02/2012 16:1

Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Seán Coffey
The issue would lie with the OpenDS team then. They need to update their code and use supported JDK APIs. regards, Sean. On 28/02/2012 16:10, Lindner, Bärbel wrote: sun.security.x509.x500Signer is used from OpenDS (our version is v2.2.0). That is one reason that OpenDS is not runnable with JR

Re: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Seán Coffey
See http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6876158 sun.security.x509 package is JRE private and should not be used by 3rd party applications. regards, Sean. On 28/02/2012 15:38, Lindner, Bärbel wrote: Please readd class "sun.security.x509.X500Signer" in rt.jar. The class was a

RE: CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Lindner , Bärbel
sun.security.x509.x500Signer is used from OpenDS (our version is v2.2.0). That is one reason that OpenDS is not runnable with JRE7. Regards Baerbel -Original Message- From: Seán Coffey [mailto:sean.cof...@oracle.com] Sent: Dienstag, 28. Februar 2012 17:07 To: Lindner, Bärbel Cc: jdk7u-d

CR 7149144 - rt.jar: missing sun.security.x509.X500Signer class

2012-02-28 Thread Lindner , Bärbel
Please readd class "sun.security.x509.X500Signer" in rt.jar. The class was available in JRE 1.6 rt.jar. Thanks Baerbel -- Baerbel Lindner Fujitsu Technology Solutions

hg: jdk7u/jdk7u4-dev/jdk: 7132692: [macosx] Class com.apple.eawt not functioning

2012-02-28 Thread anthony . petrov
Changeset: 05e342dd44de Author:anthony Date: 2012-02-28 16:39 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/05e342dd44de 7132692: [macosx] Class com.apple.eawt not functioning Summary: Postpone setting an application delegate until an app is fully initialized Revie

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Alexander Zuev
Anthony, fix looks fine to me. With best regards, Alex On 2/27/12 17:30, Anthony Petrov wrote: Hello, Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7147435 at: http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ This bug is a regression o

Re: [7u4] Review request for 7147435: closed/java/awt/Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh failed since 7u4b11

2012-02-28 Thread Anthony Petrov
Hi Artem, I believe you've clicked the wrong link. My webrev at http://cr.openjdk.java.net/~anthony/7u4-2-headlessTestFailed-7147435.0/ contains changes to the awt_LoadLibrary.c file only. I have provided a link to the webrev for 7124511 as a reference only, and put it in the very end of my m

Re: Dropping 32-bit support (was Branches)

2012-02-28 Thread Michael McMahon
Artem, I don't think we can ignore it in the closed/oracle build. But, I'd agree the default situation could be, when it's not set, to build universal (32 + 64). - Michael. On 27/02/12 23:09, Artem Ananiev wrote: Alternatively, we can completely ignore ARCH_DATA_MODEL on Mac and always bu

Re: OS X preview only installs on Lion?

2012-02-28 Thread Henri Gomez
>>Did you built main branch (jdk7u) or dev branch (jdkudev) ? > > dev branch jdk7u-dev > > see: https://gist.github.com/1904211 Yep I know well your scripts :) Error is still in FreeType 2.3.0 detection. ERROR: FreeType version 2.3.0 or higher is required. /bin/mkdir -p /Users/henri/jenkins/