[7u6] Request for approval for 7104147 - the fix for cr6887286 was not appropriate for backporting

Hi! This is a request to backport a JDK 8 fix into JDK 7u6: [ Bug ID: 7104147 the fix for cr6887286 was not appropriate for backporting ] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7104147 The fix has already been pushed to JDK 8: [ jdk8/2d/jdk / changeset 5127:da54364b140c ] http:/

Re: Review for 7153977

On 3/20/12 2:16 AM, Andrew Hughes wrote: > Is this patch in OpenJDK8? My understanding was that patches had to go there > first. It's possible for a change to go here first. It takes a bit more work, from my POV, since what is often a simple backport from 8 to 7u resulting in the identical ch

hg: jdk7u/jdk7u4-dev/jdk: 2 new changesets

Changeset: 58b19dcdb7fc Author:bpatel Date: 2012-03-21 15:34 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/58b19dcdb7fc 7155419: Remove reference to JRockit and commercial features from java man page Reviewed-by: wetmore, ksrini ! src/linux/doc/man/java.1 ! src/sol

hg: jdk7u/jdk7u4-dev/jdk: 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar.

Changeset: 214f68c9b1a9 Author:alexp Date: 2012-03-22 02:52 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/214f68c9b1a9 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar. Reviewed-by: anthony, dcherepanov ! src/macosx/classes/

[7u4] Request for approval for CR 7155419 - Remove reference to JRockit and commercial features from java man page

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7155419 ( The bug has been files yesterday but does not appear up currently and should be on bugs.sun.com soon.) Webrev: http://cr.openjdk.java.net/~bpatel/7155419/webrev.00/ Review

Re: Review for 7155419

It looks generally good, few comments, can be fixed for the next release. 1. Standardize the terms JVM and HotSpot it seems to be used interchangeably, good idea to fix them correctly for the next release. 2. URLs ending with a "." may not work with some browsers depending on how t

hg: jdk7u/jdk7u4-dev/jdk: 7154072: [macosx] swallowing key events

Changeset: af118cc1bef7 Author:ant Date: 2012-03-22 02:44 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/af118cc1bef7 7154072: [macosx] swallowing key events Reviewed-by: anthony ! src/macosx/native/sun/awt/AWTView.m + test/java/awt/event/KeyEvent/SwallowKeyEvents/S

Re: [7u4] Request for approval for CR 7153977 - Generate English man pages for JDK 7u4

Thanks, Bhavesh, approved. On 3/21/12 11:18 PM, Bhavesh Patel wrote: > Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153977 > Webrev: http://cr.openjdk.java.net/~bpatel/7153977/webrev.00/ > Reviewer: ohair, alanb > > Rationale for inclusion in 7u4: Man pages for 7u4. > > Thanks, > Bha

Re: Review for 7155419

On 3/21/12 5:51 PM, Bhavesh Patel wrote: > Hi, > This is in connection with CR 7153977. The writer has updated the > JRockit reference from the man page in question. This is addressed as a > separate bug. I have generated the updated man page which could be reviewed > at http://cr.openjd

hg: jdk7u/jdk7u4-dev/jaxp: 7150637: No newline emitted after XML decl in XSLT output

Changeset: 35416f31de0a Author:joehw Date: 2012-03-21 15:35 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jaxp/rev/35416f31de0a 7150637: No newline emitted after XML decl in XSLT output Reviewed-by: lancea ! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTrans

[7u4] Request for approval for CR 7153977 - Generate English man pages for JDK 7u4

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153977 Webrev: http://cr.openjdk.java.net/~bpatel/7153977/webrev.00/ Reviewer: ohair, alanb Rationale for inclusion in 7u4: Man pages for 7u4. Thanks, Bhavesh.

Re: Review for 7153977

I didn't review the entire set of changes, since Somwya interrupted me and said it has already been by a couple people. However, I did make a start and had a few comments. Some teams go ahead and update the copyright dates to say "2012," whenever they make changes. Not required, but somethin

Re: Review for 7155419

In the normal JDK workspaces, we try pretty hard to keep to the 80 space/line restriction. http://www.oracle.com/technetwork/java/codeconv-138413.html This makes the code and especially framed webrev's *MUCH* easier to read. Having to slide frames back/forth is not very efficient. I woul

hg: jdk7u/jdk7u4-dev/jdk: 7154516: [macosx] Popup menus have no visible borders

Changeset: 25285b7883d4 Author:dcherepanov Date: 2012-03-22 01:03 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/25285b7883d4 7154516: [macosx] Popup menus have no visible borders Reviewed-by: serb ! src/macosx/classes/com/apple/laf/AquaLookAndFeel.java

jdk7u4-b17: HotSpot

hs23-b18 has been integrated into jdk7u4-b17. http://hg.openjdk.java.net/jdk7u/jdk7u4/rev/89e8d9a0f6f1 http://hg.openjdk.java.net/jdk7u/jdk7u4/corba/rev/e2a9fe67e059 http://hg.openjdk.java.net/jdk7u/jdk7u4/hotspot/rev/e266ffd6a7d7 http://hg.openjdk.java.net/jdk7u/jdk7u4/jaxp/rev/77a453ae863f http

hg: jdk7u/jdk7u4/hotspot: 5 new changesets

Changeset: 16d263c59845 Author:amurillo Date: 2012-03-10 00:52 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4/hotspot/rev/16d263c59845 7150326: new hotspot build - hs23-b18 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1425699d00c2 Author:never Date: 2012-03-

hg: jdk7u/jdk7u4-dev/hotspot: 5 new changesets

Changeset: 16d263c59845 Author:amurillo Date: 2012-03-10 00:52 -0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/hotspot/rev/16d263c59845 7150326: new hotspot build - hs23-b18 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1425699d00c2 Author:never Date: 2012

hg: jdk7u/jdk7u4-dev/hotspot: Added tag jdk7u4-b16 for changeset c6a96f7a781d

Changeset: 376549fed156 Author:katleman Date: 2012-03-16 07:29 -0700 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/hotspot/rev/376549fed156 Added tag jdk7u4-b16 for changeset c6a96f7a781d ! .hgtags

hg: jdk7u/jdk7u4-dev/jdk: 7152952: [macosx] List rows overlap with enlarged font

Changeset: 9b195bfce3eb Author:alexp Date: 2012-03-21 22:02 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/9b195bfce3eb 7152952: [macosx] List rows overlap with enlarged font Reviewed-by: serb ! src/macosx/classes/sun/lwawt/LWListPeer.java

Review for 7155419

Hi, This is in connection with CR 7153977. The writer has updated the JRockit reference from the man page in question. This is addressed as a separate bug. I have generated the updated man page which could be reviewed at http://cr.openjdk.java.net/~bpatel/7155419/webrev.00/ Regards, B

hg: jdk7u/jdk7u4-dev/jdk: 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6

Changeset: 6572dc1873ab Author:leonidr Date: 2012-03-21 20:46 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/6572dc1873ab 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6 Summary: Refactored printable character check out of the performAction

hg: jdk7u/jdk7u4-dev/jdk: 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

Changeset: ec390d13b0b3 Author:ant Date: 2012-03-21 20:31 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/ec390d13b0b3 7145768: [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest Reviewed-by: art ! src/macosx/classes/sun/lwawt/LWComponentPeer.java ! s

hg: jdk7u/jdk7u4-dev/jdk: 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application

Changeset: fdd008c3ef5a Author:anthony Date: 2012-03-21 20:22 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/fdd008c3ef5a 7149085: [macosx] Quit with QuitStrategy CLOSE_ALL_WINDOWS does terminate application Summary: Don't terminate the event loop. System.exit() wil

hg: jdk7u/jdk7u4-dev/jdk: 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows

Changeset: 0b7acd016f8c Author:anthony Date: 2012-03-21 20:17 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/0b7acd016f8c 7124428: [macosx] Frame.setExtendedState() doesn't work for undecorated windows Summary: Emulate -zoom request for undecorated windows Reviewed-b

hg: jdk7u/jdk7u4-dev/jdk: 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window

Changeset: 28cf821cd6a1 Author:anthony Date: 2012-03-21 20:10 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/28cf821cd6a1 7154177: [macosx] An invisible owner frame becomes visible upon clicking a child window Summary: Only visible frames must participate in the par

Re: [7u4] Request for phase 2 approval for CR 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar.

On Mar 21, 2012, at 7:38 AM, Alexander Potochkin wrote: > Bug:7149005 > (not visible via bus.sun.com, please use bugster) > > Webrev:http://cr.openjdk.java.net/~alexp/7149005/webrev.00/ > Reviewer: Anthony Petrov, Dmitry Cherepanov > > Rationale for inclusion in 7u4: > > This bug heavily affec

hg: jdk7u/jdk7u4-dev/jdk: 7149005: [macosx] Orphaned Choice popup window

Changeset: 875951474ebd Author:alexp Date: 2012-03-21 19:26 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/875951474ebd 7149005: [macosx] Orphaned Choice popup window Reviewed-by: ant ! src/macosx/classes/sun/lwawt/LWChoicePeer.java

[7u4] Request for phase 2 approval for CR 7149005: [macosx] Java Control Panel's UI controls are distorted when draging scroll bar.

Bug:7149005 (not visible via bus.sun.com, please use bugster) Webrev:http://cr.openjdk.java.net/~alexp/7149005/webrev.00/ Reviewer: Anthony Petrov, Dmitry Cherepanov Rationale for inclusion in 7u4: This bug heavily affects painting of the Java Control Panel application which is very visible by

[7u6] Request approval CR 7074616: java.lang.management.ManagementFactory.getPlatformManagementInterfaces fails

CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7074616 Webrev: http://cr.openjdk.java.net/~fparain/7074616/webrev.01/ Technical Review: http://mail.openjdk.java.net/pipermail/serviceability-dev/2012-March/005455.html Reviewers: David Holmes, Staffan Larsen Testing: The fix is the same

hg: jdk7u/jdk7u4-dev/jdk: 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed

Changeset: 3470e0ad6cc0 Author:kizune Date: 2012-03-21 17:14 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jdk/rev/3470e0ad6cc0 7144063: [macosx] Swing JMenu mnemonic doesn't work; hint misleading; cross symbol typed Reviewed-by: leonidr, skovatch, swingler ! src/macosx/n

[7u4] Request for phase 2 approval for CR 7124286: [macosx] Option modifier should work like AltGr as in Apple jdk 6

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7124286 Webrev: http://cr.openjdk.java.net/~leonidr/7124286/webrev.00/ Reviewer: swingler, alexp Rationale for inclusion in 7u4: the ability to enter characters from the extended characters set via option+letter combo is a basic functionali

[7u4] Request for phase 2 approval for CR 7154516: [macosx] Popup menus have no visible borders

Bug: http://bugs.sun.com/view_bug.do?bug_id=7154516 Webrev: http://cr.openjdk.java.net/~dcherepanov/7154516/webrev.0/ Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003642.html Reviewer: Sergey Bylokhov (serb) Rationale for inclusion in 7u4: This is a very visi

Re: [7u4] Request for phase 2 approval for CR 7145768 [macosx] Regression: failure in b11 of ModalDialogInFocusEventTest

I've added a subcr for 8. Thanks, Anton. On 20.03.2012 22:23, Artem Ananiev wrote: On 3/20/2012 8:46 PM, Edvard Wendelin wrote: Forgot to add that you should create a sub-CR for JDK 8 as well (or push it if the fix applies straight away). Even if the fix is absolutely the same for different

[7u4] Request for phase 2 approval for CR 7154072 [macosx] swallowing key events

Bug: http://bugs.sun.com/view_bug.do?bug_id=7154072 Webrev: http://cr.openjdk.java.net/~ant/7154072/webrev.1 Review thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2012-March/003653.html Reviewer: Anthony Petrov (anthony) Rationale for inclusion in 7u4: Key events typed with modif