Re: RFR: 7175331 - Remove FDS files from embedded JRE images

2012-06-08 Thread Kelly O'Hair
Looks fine. -kto On Jun 8, 2012, at 3:19 PM, David Holmes wrote: > cc'ing build-dev for a review by a 7u Reviewer. > > Thanks, > David > > On 8/06/2012 11:01 AM, David Holmes wrote: >> This is a simple fix that only applies to 7u and is targeted for 7u6. >> >> We need to update the embedded i

[7u6] Request for approval for bulk integration of hs23.2-b05

2012-06-08 Thread Alejandro E Murillo
Requesting approval to integrate hs23.2-b05 into jdk7u6-b14. A webrev is available at: http://cr.openjdk.java.net/~amurillo/7u6/hs23.2-b05-jdk7u6-b14.webrev/ Pre-integration testing is in progress; the integration will proceed only after SQE has analyzed the results and approved. The fixes in

Re: RFR: 7175331 - Remove FDS files from embedded JRE images

2012-06-08 Thread Daniel D. Daugherty
On 6/7/12 7:01 PM, David Holmes wrote: This is a simple fix that only applies to 7u and is targeted for 7u6. We need to update the embedded image target in Release-embedded.gmk to remove the FDS related files that now get created. This obviously only impacts embedded builds. http://cr.openjd

Re: [7u6] Request for approval for CR 7174645 Could not enable access bridge in Win XP - 32 bit

2012-06-08 Thread Ragini Prasad
Resending for approval with updated webrev with /MD flag. http://cr.openjdk.java.net/~raginip/7174645/webrev.01/ Thanks, Ragini. On 6/8/2012 10:22 AM, Ragini Prasad wrote: Thanks for pointing it out. It has dawned on me that I was using the debug version to link with. I'll modify the Makefil

Re: RFR: 7175331 - Remove FDS files from embedded JRE images

2012-06-08 Thread David Holmes
cc'ing build-dev for a review by a 7u Reviewer. Thanks, David On 8/06/2012 11:01 AM, David Holmes wrote: This is a simple fix that only applies to 7u and is targeted for 7u6. We need to update the embedded image target in Release-embedded.gmk to remove the FDS related files that now get create

Re: [7u6] Request for Approval - 716347: Licensee source bundle build failed around jrockit.jfr (7u4)

2012-06-08 Thread Edvard Wendelin
Approved. On Jun 8, 2012, at 4:33 PM, Nils Loodin wrote: > Bug: http://bugs.sun.com/view_bug.do?bug_id=716347 > fix: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c89018e3f3b6 > Review thread: > http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-June/003809.html > > /Nils Loodin

[7u6] request for approval (JAXP) : 7157608: One feature is not recognized.

2012-06-08 Thread Joe Wang
Hi, This is a request for approval to fix 7157608, adding feature http://apache.org/xml/features/standard-uri-conformant into the recognized list. webrev:http://cr.openjdk.java.net/~joehw/7u6/7157608/webrev/ reviewed by: Paul Sandoz I've committed the change into jdk8. Thanks, Joe

Request for approval: 7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true

2012-06-08 Thread Rob McKenna
Apologies, subject altered accordingly. -Rob On 08/06/12 18:24, Rob McKenna wrote: Hi folks, Fix is identical to 8: http://cr.openjdk.java.net/~robm/7161881/webrev.02/ -Rob

7161881: (dc) DatagramChannel.bind(null) fails if IPv4 socket and running with preferIPv6Addresses=true

2012-06-08 Thread Rob McKenna
Hi folks, Fix is identical to 8: http://cr.openjdk.java.net/~robm/7161881/webrev.02/ -Rob

Re: [7u6] Request for approval for CR 7174645 Could not enable access bridge in Win XP - 32 bit

2012-06-08 Thread Ragini Prasad
Thanks for pointing it out. It has dawned on me that I was using the debug version to link with. I'll modify the Makefile to use flag /MD instead of /MDd and I realize that I wont need the /MT. Will resend for code review approval. Ragini. On 6/8/2012 10:02 AM, Kelly O'Hair wrote: We ship

Re: [7u6] Request for approval for CR 7174645 Could not enable access bridge in Win XP - 32 bit

2012-06-08 Thread Kelly O'Hair
We ship the msvcr100.dll with the jdk. Artem is right, we never use the debug runtime msvcr100d.dll because we can't redistribute it, and we don't statically link any runtimes for lots of reasons. We should be using the /MD and rely on msvcr100.dll shipped with the jdk/jre unless there is a

Re: [7u6] Request for approval for CR 7174645 Could not enable access bridge in Win XP - 32 bit

2012-06-08 Thread Ragini Prasad
Hi Artem, /MT flag links the MSVC***.dll statically. This is the Makefile (open) for utility (in closed) we added Registry manipulation which needs the MSVC*** dll to be present on the host machine, as this dll may not be present, hence the need to do the static linking. Thanks, Ragini. On 6/

[7u6] Request for Approval - 716347: Licensee source bundle build failed around jrockit.jfr (7u4)

2012-06-08 Thread Nils Loodin
Bug: http://bugs.sun.com/view_bug.do?bug_id=716347 fix: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c89018e3f3b6 Review thread: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2012-June/003809.html /Nils Loodin

Re: JDK 7u6 - Release timeline

2012-06-08 Thread Edvard Wendelin
Hi, I wanted to remind you about the upcoming months for 7u6. Most of the feature work is now completed and work is now focused on bug fixing. In mid June the inflow of fixes will be restricted to only include P1-P3 bugs. After the first week of July all fixes will require release team appro

Re: [7u6] Request for approval for CR 7174645 Could not enable access bridge in Win XP - 32 bit

2012-06-08 Thread Artem Ananiev
Hi, Ragini, Pete, as far as I understand, the fix is to replace /MDd with /MT, so we don't link to debug version of MS runtime, correct? Could you provide more details, why you link to the static version of the runtime (/MT), instead of dynamic one (/MD)? The only place in JDK where we use tha