[7u] Request for review and approval/backport: 6512101: Incorrect encoding in NetworkInterface.getDisplayName()

2013-01-08 Thread Frank Ding
Hi all, I'd like to request for approval to push the following change into 7u11. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6512101 Changeset in jdk8 http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/883feced1cdd Reviewed by chegar, dsamersoff Webrev for 7u http://cr.openjdk.java.net

Re: Approval request for 8004316

2013-01-08 Thread Seán Coffey
Phil, Yes - people "should" cc relevant parties when such backports are taking place. Not mandatory though. Rule 5 in code review guidelines : http://openjdk.java.net/projects/jdk7u/codereview.html It's probably a good time to remind OpenJDK 7u contributors to carry out such checks where appl

Re: Approval request for 8004316

2013-01-08 Thread Phil Race
I believe the process on requesting a backport is that the 8 code approvers need to be CC'd and that the 7 release managers should be enforcing this. In this email there's basically no justification of the need for a backport and I heartily disapprove of backporting 8004316. Its not that importa

Re: Approval request for 8004316

2013-01-08 Thread Sean Chou
Hi Jayashree, Committed, please verify: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d6c538499353 On Mon, Jan 7, 2013 at 10:43 PM, jayashree viswanathan < jvisw...@linux.vnet.ibm.com> wrote: > Hi, > > Would like to get approval for back-porting the fix for 8004316, on JDK 7 > . The patch

hg: jdk7u/jdk7u-dev/jdk: 8004316: Printer - tempfile having incorrect extension

2013-01-08 Thread zhouyx
Changeset: d6c538499353 Author:jviswana Date: 2012-12-12 13:28 +0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d6c538499353 8004316: Printer - tempfile having incorrect extension Reviewed-by: bae, jgodinez ! src/solaris/classes/sun/print/UnixPrintJob.java

Re: [7u12] Request for approval: 8004211: Remove unused dlinfo local variable in launcher code

2013-01-08 Thread Sean Chou
Hi Shi Jun, Committed. http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/11093adbb875 Please verify. On Mon, Jan 7, 2013 at 8:08 PM, Edvard Wendelin wrote: > Approved. > > On 01/07/2013 08:45 AM, Shi Jun wrote: > >> Hi all, >> >> I'd like to request for approval to push the following change

hg: jdk7u/jdk7u-dev/jdk: 8004211: Remove unused dlinfo local variable in launcher code

2013-01-08 Thread zhouyx
Changeset: 11093adbb875 Author:zhangshj Date: 2012-11-30 17:24 +0800 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/11093adbb875 8004211: Remove unused dlinfo local variable in launcher code Reviewed-by: alanb ! src/solaris/bin/java_md_solinux.c