Request for approval to backport 8005290: remove -showversion from RMI test library subprocess mechanism

2013-02-04 Thread Stuart Marks
Hi all, Requesting to backport this cleanup of RMI's test subprocess mechanism. Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005290 Review: http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-December/013149.html Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/60a

[7u-dev] Request for approval to backport 8004317 & 8006534: RMI TestLibrary.getUnusedRandomPort fixes

2013-02-04 Thread Stuart Marks
Hi all, This is a request to backport two RMI test library changes. They're closely related so I want to push them in at the same time. 8004317 TestLibrary.getUnusedRandomPort() fails intermittently, but exception not reported Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=800431

Re: [7u] Request for review and approval/backport: 7183373: URLClassloader.close() does not close JAR files loaded via getResource()

2013-02-04 Thread Frank Ding
Hi Alan and Edvard, Thank you for your reply. Let's wait several weeks then. Best regards, Frank On 2/4/2013 7:04 PM, Alan Bateman wrote: This is an area where issues (performance for example) have tended to show up with real world usage. For that reason, I wonder if it would be safer to

Re: CFV: New JDK7u Committer: David Buck

2013-02-04 Thread Dalibor Topic
Vote: Yes! On 2/1/13 6:34 PM, Alexander Potochkin wrote: > I hereby nominate David Buck to jdk7u Committer. > > Buck has been a member of the Java SE sustaining team for two years now. > He has spent most of that time working on JRockit, > but is also responsible for working on client and HotSpot

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread David Holmes
On 5/02/2013 12:06 AM, Erik Joelsson wrote: CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris directory for linux. I changed to at least use CLOSED_SRC instead. Verified on both solaris and linux, open and closed. Thanks. David - http://cr.openjdk.java.net/~er

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread Kelly O'Hair
Looks ok to me too. -kto On Feb 4, 2013, at 6:06 AM, Erik Joelsson wrote: > CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris > directory for linux. I changed to at least use CLOSED_SRC instead. Verified > on both solaris and linux, open and closed. > > http://cr.o

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread Tim Bell
Hi Erik: CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris directory for linux. I changed to at least use CLOSED_SRC instead. Verified on both solaris and linux, open and closed. http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.02/ Looks good. Tim /Erik O

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread Erik Joelsson
CLOSED_PLATFORM_SRC can't be used in this case since it points to the solaris directory for linux. I changed to at least use CLOSED_SRC instead. Verified on both solaris and linux, open and closed. http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.02/ /Erik On 2013-02-04 12:57, David Holme

Re: CFV: New JDK7u Committer: David Buck

2013-02-04 Thread Staffan Larsen
Vote: yes. On 1 feb 2013, at 18:34, Alexander Potochkin wrote: > I hereby nominate David Buck to jdk7u Committer. > > Buck has been a member of the Java SE sustaining team for two years now. > He has spent most of that time working on JRockit, > but is also responsible for working on client a

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread David Holmes
Hi Erik, Can you use $(CLOSED_PLATFORM_SOURCE) instead of hardwiring src/closed/? In theory it should be possible to relocate the "closed" repo and still have things work (by changing one definition). David On 4/02/2013 9:42 PM, Erik Joelsson wrote: Open part of this review: The docs team

Re: Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread Erik Joelsson
I should add that this is for jdk7u, what used to be 14. On 2013-02-04 12:42, Erik Joelsson wrote: Open part of this review: The docs team will start producing separate man pages for openjdk and oraclejdk. Here are the necessary changes to the makefiles to support this. http://cr.openjdk.ja

Review Request: 8007450: Add build support for different man pages for OpenJDK and OracleJDK

2013-02-04 Thread Erik Joelsson
Open part of this review: The docs team will start producing separate man pages for openjdk and oraclejdk. Here are the necessary changes to the makefiles to support this. http://cr.openjdk.java.net/~erikj/8007450/webrev.jdk.01/ /Erik

Re: [7u] Request for review and approval/backport: 7183373: URLClassloader.close() does not close JAR files loaded via getResource()

2013-02-04 Thread Alan Bateman
This is an area where issues (performance for example) have tended to show up with real world usage. For that reason, I wonder if it would be safer to wait a bit (a few weeks away) to see if issues emerge. At it stands, the jdk8 fix hasn't even got to a promoted build so it probably hasn't h

Re: [7u] Request for review and approval/backport: 7183373: URLClassloader.close() does not close JAR files loaded via getResource()

2013-02-04 Thread Edvard Wendelin
Approved. On Feb 4, 2013, at 10:36 AM, Frank Ding wrote: > Hi all, > > I'd like to request for approval to push the following change into 7u. > > Bug: should be but not accessible now > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183373 > > Changeset in jdk8 > http://hg.openjdk.java

Re: CFV: New JDK7u Committer: David Buck

2013-02-04 Thread Jesper Wilhelmsson
Vote: yes /Jesper On 2013-02-01 18:34, Alexander Potochkin wrote: I hereby nominate David Buck to jdk7u Committer. Buck has been a member of the Java SE sustaining team for two years now. He has spent most of that time working on JRockit, but is also responsible for working on client and HotSp

[7u] Request for review and approval/backport: 7183373: URLClassloader.close() does not close JAR files loaded via getResource()

2013-02-04 Thread Frank Ding
Hi all, I'd like to request for approval to push the following change into 7u. Bug: should be but not accessible now http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7183373 Changeset in jdk8 http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4c9fcb5cbc07 Reviewed by chegar Webrev for 7u http:/