hg: jdk7u/jdk7u-dev/corba: 8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases

2013-04-29 Thread dmitry . degrave
Changeset: 2f38ced3bea8 Author:dmeetry Date: 2013-04-29 16:51 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/2f38ced3bea8 8011986: [corba] idlj generates read/write union helper methods that throw wrong exception in some cases Reviewed-by: lancea ! src/share/class

hg: jdk7u/jdk7u-dev/corba: 4504275: CORBA boolean type unions do not generate compilable code from idlj

2013-04-29 Thread dmitry . degrave
Changeset: 583e454e0813 Author:dmeetry Date: 2013-04-29 16:44 +0400 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/corba/rev/583e454e0813 4504275: CORBA boolean type unions do not generate compilable code from idlj Summary: JLS doesn't allow boolean type in switch statement, hence

hg: jdk7u/jdk7u-dev/jdk: 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win)

2013-04-29 Thread rob . mckenna
Changeset: 05420e655463 Author:alanb Date: 2013-04-17 16:11 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/05420e655463 8012019: (fc) Thread.interrupt triggers hang in FileChannelImpl.pread (win) Reviewed-by: chegar ! src/share/classes/sun/nio/ch/DatagramChannelImpl.

Re: [7u40] Request for approval for 4504275, 8011986 - two issues with generated code

2013-04-29 Thread Seán Coffey
Approved. regards, Sean. On 29/04/13 15:58, Dmeetry Degrave wrote: Requesting approval to push two Corba fixes to 7u-dev, identical to jdk8. 4504275: CORBA boolean type unions do not generate compilable code from idlj bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4504275 fix: http:

Re: [7u] Request for approval: 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

2013-04-29 Thread Seán Coffey
Mikhail, This is a new method you're proposing to introduce in a public API for an update release. Granted, it's an override. cc'ing Joe Darcy here to confirm that it's OK and that it doesn't introduce a source/binary compatibility concern. - Joe - can you comment if this change is OK for 7u

Re: Request for approval: JDK-7179050 [macosx] Make LWAWT be able to run on AppKit thread

2013-04-29 Thread Seán Coffey
Approved. Please add an appropriate "noreg-[]" label to the bug. regards, Sean. On 29/04/13 14:15, Petr Pchelko wrote: Hello This is a request to backport the fix for JDK-7179050 from 8 to 7u-dev. The bug: http://bugs.sun.com/view_bug.do?bug_id=7179050 The changeset: http://hg.openjdk.java.ne

[7u40] Request for approval for 4504275, 8011986 - two issues with generated code

2013-04-29 Thread Dmeetry Degrave
Requesting approval to push two Corba fixes to 7u-dev, identical to jdk8. 4504275: CORBA boolean type unions do not generate compilable code from idlj bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4504275 fix: http://hg.openjdk.java.net/jdk8/tl/corba/rev/8f0a461776a9 8011986: [corba] i

[7u] Request for approval: 8012004: JINTERNALFRAME NOT BEING FINALIZED AFTER CLOSING

2013-04-29 Thread mikhail cherkasov
Hello All, Requesting approval to push a fix to 7u-dev, it absolutely the same as for jdk8: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/2b8bd577257c http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012004 Thanks, Mikhail.

Re: [7u] Review Request for JDK-8006634 Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler

2013-04-29 Thread Sergey Bylokhov
Hi, Petr. Fix looks good. On 29.04.2013 17:56, Petr Pchelko wrote: Hello, AWT Team. Please, review the back-port of the fix for JDK-8006634 to the JDK7u. I am sending it as a separate review request because the code changes are different in the patches. The bug: http://bugs.sun.com/view_bug.

[7u] Review Request for JDK-8006634 Unify LWCToolkit.invokeAndWait() and sun.awt.datatransfer.ToolkitThreadBlockedHandler

2013-04-29 Thread Petr Pchelko
Hello, AWT Team. Please, review the back-port of the fix for JDK-8006634 to the JDK7u. I am sending it as a separate review request because the code changes are different in the patches. The bug: http://bugs.sun.com/view_bug.do?bug_id=8006634 The webrev for JDK7-u: http://cr.openjdk.java.net/~p

Request for approval: JDK-7179050 [macosx] Make LWAWT be able to run on AppKit thread

2013-04-29 Thread Petr Pchelko
Hello This is a request to backport the fix for JDK-7179050 from 8 to 7u-dev. The bug: http://bugs.sun.com/view_bug.do?bug_id=7179050 The changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/5309fed435b5 The review thread: http://mail.openjdk.java.net/pipermail/awt-dev/2013-January/004095.html