Requesting approval to integrate hs24-b48 into jdk7u40-b29.
A webrev is available at:
http://cr.openjdk.java.net/~amurillo/7u40/hs24-b48-jdk7u40-b29.webrev/
Pre-integration testing is in progress; the integration will proceed
only after SQE has analyzed the results and approved.
The fixes in t
Hi folks,
Straight backports of the following two: (the latter caused by an
omission in the former)
7038105: File.isHidden() should return true for pagefile.sys and
hiberfil.sys
8016063: getFinalAttributes should use FindClose
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7038105
Hello,
This is a straight backport from 8, the changes are identical.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015016
Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017746.html
Changeset: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c2957e596bee
Will do, thanks.
-DrD-
> David,
>
> didn't see a reason on why this isn't fixed in jdk8 first. The review thread
> explains :
> http://mail.openjdk.java.net/pipermail/awt-dev/2013-June/004957.html
>
> Can you log a jdk8 backport record so that this isn't forgotten ?
>
> Also - please add a n
Amy,
Andrew has reported an issue against the 8006120 fix for OpenJDK build.
I've logged 8016094 to track it.
A question around when 8006120 will be ported to JDK8 has also been
asked. Have you information on that ?
regards,
Sean.
On 06/06/2013 20:16, Andrew Hughes wrote:
- Original M
David,
didn't see a reason on why this isn't fixed in jdk8 first. The review
thread explains :
http://mail.openjdk.java.net/pipermail/awt-dev/2013-June/004957.html
Can you log a jdk8 backport record so that this isn't forgotten ?
Also - please add a noreg-* label to the bug report.
Approved.
- Original Message -
> Andrew,
>
> the Server JRE work was carried out for the 7u21 CPU release and can
> also been seen in the 7u21/7u-dev sync webrev :
>
> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-April/006126.html
>
> The particular changeset you reference was incorrectly
- Original Message -
> Andrew,
>
> the Server JRE work was carried out for the 7u21 CPU release and can
> also been seen in the 7u21/7u-dev sync webrev :
>
> http://mail.openjdk.java.net/pipermail/jdk7u-dev/2013-April/006126.html
>
> The particular changeset you reference was incorrectly
Bug: http://bugs.sun.com/view_bug.do?bug_id=7181710
Review threads:
http://mail.openjdk.java.net/pipermail/macosx-port-dev/2013-May/005692.html
http://mail.openjdk.java.net/pipermail/awt-dev/2013-June/004951.html
Changeset: http://cr.openjdk.java.net/~ddehaven/7181710/jdk.0/
Reviewed by: Anthon
On 06/06/2013 07:35 PM, Seán Coffey wrote:
> Approved for jdk7u-dev then. Aleksey - I can help push this to 7u-dev if
> you don't have a committer lined up already.
Thanks Sean, I don't have the committer/sponsor for this change. Let me
know if you want something done on my side to ease the integr
I only saw the 7u backport request thread on core-libs-dev after
replying to the earlier mail. Thanks for getting back Chris.
Approved for jdk7u-dev then. Aleksey - I can help push this to 7u-dev if
you don't have a committer lined up already.
regards,
Sean.
On 06/06/2013 16:12, Chris Hegart
On 06-Jun-13 19:17, Alan Bateman wrote:
On 06/06/2013 16:02, Konstantin Shefov wrote:
There are a lot of test pairs (.java + .html) in JDK repo where both
files contain jtreg tags, although only one file contains @test tag.
I think it is not necessary to remove other tags, because they show
th
On 06/06/2013 16:02, Konstantin Shefov wrote:
There are a lot of test pairs (.java + .html) in JDK repo where both
files contain jtreg tags, although only one file contains @test tag.
I think it is not necessary to remove other tags, because they show
that the given file is a part of the given t
Changeset: 9a93f4d2eb5c
Author:darcy
Date: 2013-04-25 09:37 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/9a93f4d2eb5c
8012044: Give more information about self-suppression from
Throwable.addSuppressed
Reviewed-by: alanb, dholmes
! src/share/classes/java/lang/Throw
Changeset: 3c100c6c3923
Author:alanb
Date: 2013-05-10 14:53 +0100
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3c100c6c3923
8011128: (fs) Files.createDirectory fails if the resolved path is exactly 248
characters long
Reviewed-by: khazra, chegar
! src/windows/classes/su
I am not aware of any specific issues that would prevent this change
from being backported. The snipped you sited is for private
implementation, and as Aleksey said, is a corner case and should be ok.
-Chris
On 06/06/2013 02:39 PM, Seán Coffey wrote:
Aleksey,
The code comments indicate that
There are a lot of test pairs (.java + .html) in JDK repo where both
files contain jtreg tags, although only one file contains @test tag.
I think it is not necessary to remove other tags, because they show that
the given file is a part of the given test for @bug and its author, etc.
Konstantin
Great, thanks Anthony!
-DrD-
> Thanks Artem.
>
> David: I can push the fix as soon as you get a release team approval for this
> fix to go to 7u-dev.
>
> --
> best regards,
> Anthony
>
> On 06/06/13 17:10, Artem Ananiev wrote:
>>
>> The changes looks fine to me. For JDK8, the fix can be sim
Good, I'd hoped I could do that :)
-DrD-
>
> The changes looks fine to me. For JDK8, the fix can be simplified by removing
> X11-specific part of jawt_md.h on Mac, since we're going to remove XAWT
> support on that platform in JDK8 anyway.
>
> Thanks,
>
> Artem
>
> On 6/6/2013 4:40 PM, Ant
Approved.
regards,
Sean.
On 06/06/2013 14:59, Rob McKenna wrote:
Hi folks,
Straight backport from 8:
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011128
Review thread:
http://mail.openjdk.java.net/pipermail/nio-dev/2013-May/002162.html
Changeset: http://hg.openjdk.java.net/jdk8/
Approved.
regards,
Sean.
On 06/06/2013 15:10, Rob McKenna wrote:
Hi folks,
Straight backport from 8:
Bug: bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012044
Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/015947.html
Changeset: http://hg.openjdk.java.net/jdk8
I didn't look into sources of jtreg stuff!
Basically, I understand that our test is either one or
several files, and only one of them should have @test tag inside.
Simplest example, .java and .html pair for running in appletviewer:
@test should be in .html only.
Now, I always thought that a line
Changeset: 61d0911d5bd8
Author:dmarkov
Date: 2013-06-06 18:14 +0400
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/61d0911d5bd8
8015375: Edits to text components hang for clipboard access
Reviewed-by: anthony, art
! src/solaris/native/sun/xawt/XlibWrapper.c
Hi folks,
Straight backport from 8:
Bug: bugs.sun.com/bugdatabase/view_bug.do?bug_id=8012044
Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-April/015947.html
Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/4da1d43f5843
Thanks,
-Rob
Hi folks,
Straight backport from 8:
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8011128
Review thread:
http://mail.openjdk.java.net/pipermail/nio-dev/2013-May/002162.html
Changeset: http://hg.openjdk.java.net/jdk8/jdk8/jdk/rev/09a3b08c986f
Thanks,
-Rob
You should add 7109977 to the @bug tag.
Approved.
regards,
Sean.
On 06/06/2013 14:17, Konstantin Shefov wrote:
Hello,
Please approve a direct backport from jdk 8 fix for the issue:
7109977 [macosx] MixingInHwPanel.java test fails on Mac trying to
click in the reserved corner
Test bug fix
Thanks Sean,
On 06/06/2013 05:39 PM, Seán Coffey wrote:
> The code comments indicate that some behavioural change may be present
> with this fix :
>> + * Revision notes: This differs from previous versions of this
>> + * class that relied on AbstractQueuedSynchronizer, mainly to
>> + * avoid surpr
Aleksey,
The code comments indicate that some behavioural change may be present
with this fix :
+ * Revision notes: This differs from previous versions of this
+ * class that relied on AbstractQueuedSynchronizer, mainly to
+ * avoid surprising users about retaining interrupt status during
+ * c
Approved.
regards,
Sean.
On 06/06/2013 14:06, dmitry markov wrote:
Hello,
Could you approve a back-port to jdk7u-dev of the fix for 8015375,
please? The changes are identical.
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015375
webrev for jdk7u-dev:
http://cr.openjdk.java.net/~
On 06/06/2013 14:13, Konstantin Shefov wrote:
Hello,
Please approve a direct backport from jdk 8 fix for the issue:
8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have
conflicting test descriptions
Test bug fix
http://bugs.sun.com/view_bug.do?bug_id=8015976
The webrev is:http://c
Yuri, what do you think about it?
-Konstantin
On 06-Jun-13 17:29, Alan Bateman wrote:
On 06/06/2013 14:26, Konstantin Shefov wrote:
No, it is not necessary
Maybe I'm missing something but when you remove the @test then aren't
the rest of the tags orphaned?
-Alan.
On 06/06/2013 14:26, Konstantin Shefov wrote:
No, it is not necessary
Maybe I'm missing something but when you remove the @test then aren't
the rest of the tags orphaned?
-Alan.
No, it is not necessary
On 06-Jun-13 17:24, Alan Bateman wrote:
On 06/06/2013 14:13, Konstantin Shefov wrote:
Hello,
Please approve a direct backport from jdk 8 fix for the issue:
8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have
conflicting test descriptions
Test bug fix
http:
Thanks Artem.
David: I can push the fix as soon as you get a release team approval for
this fix to go to 7u-dev.
--
best regards,
Anthony
On 06/06/13 17:10, Artem Ananiev wrote:
The changes looks fine to me. For JDK8, the fix can be simplified by
removing X11-specific part of jawt_md.h on M
Hello,
Please approve a direct backport from jdk 8 fix for the issue:
7109977 [macosx] MixingInHwPanel.java test fails on Mac trying to click
in the reserved corner
Test bug fix
http://bugs.sun.com/view_bug.do?bug_id=7109977
The webrev is:http://cr.openjdk.java.net/~kshefov/7109977/webrev.0
Hello,
Please approve a direct backport from jdk 8 fix for the issue:
8015976 OpenJDK part of bug JDK-8015812 [TEST_BUG] Tests have
conflicting test descriptions
Test bug fix
http://bugs.sun.com/view_bug.do?bug_id=8015976
The webrev is:http://cr.openjdk.java.net/~kshefov/8015976/webrev.00
The changes looks fine to me. For JDK8, the fix can be simplified by
removing X11-specific part of jawt_md.h on Mac, since we're going to
remove XAWT support on that platform in JDK8 anyway.
Thanks,
Artem
On 6/6/2013 4:40 PM, Anthony Petrov wrote:
I've already reviewed this fix, and it loo
Hello,
Could you approve a back-port to jdk7u-dev of the fix for 8015375,
please? The changes are identical.
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015375
webrev for jdk7u-dev:
http://cr.openjdk.java.net/~dmarkov/8015375/webrev.00/
jdk8 changeset: http://hg.openjdk.java.net
I've already reviewed this fix, and it looks fine to me. We still need
another reviewer. Adding awt-dev@.
Anyone please?
--
best regards,
Anthony
On 06/05/13 20:52, David DeHaven wrote:
Proposed fix for getting the correct jawt_md.h header in the JDK. I reused the
XAWT flag to enable the X1
Hi,
Could you please approve the backport of CR 7132378 to 7u?
External bug:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7132378
The fix was in JDK 8 for more than a year already:
http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f9fb8c4b4550
Testing:
- "hg import" applies cleanly to jdk7u
40 matches
Mail list logo