Looks good.
David
On 23/05/2014 6:13 AM, Mikael Vidstedt wrote:
Please review the following change, destined for jdk7u-dev. The zip
implementation in unpack200 depends on _BIG_ENDIAN being defined on big
endian platforms, and the define is missing on the linux/sparc platform(s).
Note that in
AFAICT PPC already has the define:
199 CFLAGS_REQUIRED_ppc += -fsigned-char -D_BIG_ENDIAN
Cheers,
Mikael
On 2014-05-22 13:31, Kumar Srinivasan wrote:
Looks good but IIRC PPC also needs this.
Kumar
On 5/22/2014 1:13 PM, Mikael Vidstedt wrote:
Please review the following change, destin
Looks good but IIRC PPC also needs this.
Kumar
On 5/22/2014 1:13 PM, Mikael Vidstedt wrote:
Please review the following change, destined for jdk7u-dev. The zip
implementation in unpack200 depends on _BIG_ENDIAN being defined on
big endian platforms, and the define is missing on the linux/spa
As the work on 7u60 is quickly coming to a conclusion, the release
is progressing according to plan. [1] The plan calls for a release in
May. So 7u60 should be released by the end of the month, which happens
to be next week - but as always, please note that these plans are
preliminary and subject
Please review the following change, destined for jdk7u-dev. The zip
implementation in unpack200 depends on _BIG_ENDIAN being defined on big
endian platforms, and the define is missing on the linux/sparc platform(s).
Note that in the new build system (jdk8+) the relevant logic was
rewritten,
Hi Anton,
Though this particular case seems straightforward enough, the OpenJDK
maintainers feel that there is scope for subtle bugs in lambda
conversions and would prefer it if you had official reviewer sign-off on
the change.
A general rule of thumb: if the code requires changes, it should
Hello,
I would like to request for approval to push a backport of the fix from
JDK 8 to JDK 7. The backport fix is the same with the original fix,
except for the regression test
"test/javax/swing/JPopupMenu/7160604/bug7160604.java", where the
original lambda expression
50 SwingUtili
Changeset: 7060b13cb6cc
Author:alitvinov
Date: 2014-05-22 16:16 +0400
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7060b13cb6cc
7172865: PropertyDescriptor fails to work with setter method name if setter is
non-void
Reviewed-by: malenkov, alexsch
! src/share/classes/jav
Approved.
-Rob
On 22/05/14 12:34, Anton Litvinov wrote:
Hello,
I would like to request for approval to push a backport of the fix
from JDK 8 to JDK 7. The backport fix is identical to the original fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-7172865
Webrev: http://cr.openjdk.java.
Hi,
Bengt:
Right, that should be enough, thanks.
Mikael:
Can I use you as a reviewer for this latest version as well?
Regards,
Andreas
On 2014-05-22 13:02, Bengt Rutisson wrote:
Hi Andreas,
This is a HotSpot change and for JDK7 HotSpot was developed in the hsx
project. I am a Reviewer in
Hello,
I would like to request for approval to push a backport of the fix from
JDK 8 to JDK 7. The backport fix is identical to the original fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-7172865
Webrev: http://cr.openjdk.java.net/~alitvinov/7172865/jdk7/webrev.00
Review thread:
Approv
Hi Andreas,
This is a HotSpot change and for JDK7 HotSpot was developed in the hsx
project. I am a Reviewer in the hsx project
(http://openjdk.java.net/census#brutisso) isn't that enough to review
this change?
Anyway, last webrev looks good. Thanks for fixing the test!
Bengt
On 5/22/14 10
Hi,
Adding jdk7u-dev.
Could I have a jdk7u Reviewer look at this as well please? This is a
jdk7 only fix.
(There is a related problem in jdk8 and jdk9, where an assert can fail
because of this problem. I have logged another bug for this.)
Description:
Due to the marking cleanup reclaiming em
13 matches
Mail list logo
