Re: [7u-dev] Request for Approval: 8065674: javac generates incorrect LVT table for trivial cases

Approved and yes. Thanks Vicente. -Rob On 25/11/14 01:41, Vicente-Arturo Romero-Zaldivar wrote: Please approve the push of the fix for: JDK-8065674: javac generates incorrect LVT table for trivial cases JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.open

Re: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases

On 11/24/2014 05:32 PM, Jonathan Gibbons wrote: JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ Thanks for the approval, Vicente

[7u-dev] Request for Approval: 8065674: javac generates incorrect LVT table for trivial cases

Please approve the push of the fix for: JDK-8065674: javac generates incorrect LVT table for trivial cases JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ Approval mail: http://mail.openjdk.java.net/pipermail/jdk7u-d

Re: [7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases

Looks OK to me. -- Jon On 11/24/2014 11:16 AM, Vicente-Arturo Romero-Zaldivar wrote: Please review the proposed fix for the bug in the subject. Details below: JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ This p

[7u-dev] Request for Review: JDK-8065674: javac generates incorrect LVT table for trivial cases

Please review the proposed fix for the bug in the subject. Details below: JDK7 bug entry: https://bugs.openjdk.java.net/browse/JDK-8065674 Webrev: http://cr.openjdk.java.net/~vromero/8065674/webrev.00/ This patch should fix several issues with LVT generation in JDK7. Please see the code at the

Re: RFR: 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

I wasn't sure if this was a review or approval request Kevin. Change looks fine to me in any case. Approved. regards, Sean. On 24/11/14 11:43, KEVIN WALLS wrote: Hi, I'd like to request approval to push this small proactive change to a test into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/

Re: [7u80] Request for Approval : JDK-8026865 : [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions

Approved. regards, Sean. On 24/11/14 12:34, shobhit gupta wrote: Please approve backport ofJDK-8026865 to 7u80. Bug: https://bugs.openjdk.java.net/browse/JDK-8026865 Webrev:http://cr.openjdk.java.net/~kshefov/8026865/webrev.00/ Review thread

[7u80] Request for Approval : JDK-8026865 : [TESTBUG] 'compiler/print/PrintInlining.java' should specify -XX:+UnlockDiagnosticVMOptions

Please approve backport ofJDK-8026865 to 7u80. Bug: https://bugs.openjdk.java.net/browse/JDK-8026865 Webrev:http://cr.openjdk.java.net/~kshefov/8026865/webrev.00/ Review thread: http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2013

hg: jdk7u/jdk7u-dev/hotspot: 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8

Changeset: f49c3e79b676 Author:igerasim Date: 2014-11-24 16:33 +0300 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot/rev/f49c3e79b676 8064667: Add -XX:+CheckEndorsedAndExtDirs flag to JDK 8 Reviewed-by: coleenp, ccheung ! src/share/vm/runtime/arguments.cpp ! src/share/vm/ru

RFR: 8061785: [TEST_BUG] serviceability/sa/jmap-hashcode/Test8028623.java has utf8 character corrupted by earlier merge

Hi, I'd like to request approval to push this small proactive change to a test into http://hg.openjdk.java.net/jdk7u/jdk7u-dev/hotspot The test contains an embedded utf8 character, to test a jmap/SA heap dumping fix. The test is not broken here in 7u-dev, but in another clone I saw this c

Re: [7u-dev] Request for approval: 8001633: Wrong alt processing during switching between windows.

Thanks for following up with the approval request. Approved. regards, Sean. On 24/11/14 09:59, mikhail cherkasov wrote: Hello all, I would like to request for an approval to push a backport of the fix from JDK 8 to JDK 7. The backport was changed, the original testcase was replaced with a n

[7u-dev] Request for approval: 8001633: Wrong alt processing during switching between windows.

Hello all, I would like to request for an approval to push a backport of the fix from JDK 8 to JDK 7. The backport was changed, the original testcase was replaced with a new one. Bug: https://bugs.openjdk.java.net/browse/JDK-8001633 Review: http://mail.openjdk.java.net/pipermail/awt-dev/2014-