Re: CFV: New OpenJDK 7 Committer: Andrew Dinn

Vote: yes best regards, -- daniel On 13/09/2018 04:30, Andrew Hughes wrote: I hereby nominate Andrew Dinn (adinn) [0] to OpenJDK 7 Committer. Andrew co-wrote the original AArch64 port [1] and is the the author of 32 patches in the OpenJDK sources [2]. He is already a reviewer for OpenJDK 9+.

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

On 25/09/14 12:26, Ivan Gerasimov wrote: On 25.09.2014 14:18, Daniel Fuchs wrote: Hi Ivan, Should 'usage' also be redirected? This would be inconsistent with other command line utilities. They usually print help/usage to stdout. Right. I suspected something like that. This

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

Hi Ivan, Should 'usage' also be redirected? best regards, -- daniel On 25/09/14 12:12, Ivan Gerasimov wrote: Thank you Daniel for the comments! On 25.09.2014 13:49, Daniel Fuchs wrote: Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if

Re: RFR [9] 8059101: unshuffle_patch.sh should be able to deal with stdin/stdout

Hi Ivan, When setting output & input, I wonder if it would be simpler to use an 'if else if' construct in order to avoid the '-a' in the 'if' that follows. something like this (pseudo code) might be easier to read: if "x$output" is "x-" then substitute - with /dev/stdout else if $output file

Re: [7u-dev] Request for approval (and review) - 8030192, 8031068 - java.util.logging testcase improvements

Hi Seán, This looks good! best regards, -- daniel On 7/1/14 6:45 PM, Seán Coffey wrote: Looking for approval to backport 8030192 and 8031068 to jdk7u-dev. https://bugs.openjdk.java.net/browse/JDK-8030192 -- review thread : http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-December

Re: CFV: New JDK 7u Committer: Ivan Gerasimov

vote: yes On 04/10/2014 10:45 PM, Seán Coffey wrote: I hereby nominate Ivan Gerasimov (igerasim) to JDK 7u Committer. Ivan is a member of the Java SE Sustaining team and works on all issues connected to the JDK core libraries. He's already a committer in the JDK 9 Project. His JDK 7u contribut

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

Changeset: 6a3fd236165c Author:dfuchs Date: 2014-01-22 14:11 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/6a3fd236165c 8029281: Synchronization issues in Logger and LogManager Summary: Fixes several race conditions in logging which have been at the root cause of in

[7u60] request approval to backport 8029281: Synchronization issues in Logger and LogManager

Hi, This is a request to backport [1] 8029281: Synchronization issues in Logger and LogManager from jdk8 to 7u60, as well as to backport a companion changeset (test only) which contains a better test: [2] 8031980: Add new j.u.l deadlock test for JDK-8027670 and JDK-8029281 from j

hg: jdk7u/jdk7u-dev/jdk: 2 new changesets

Changeset: aaa6b578707e Author:dfuchs Date: 2014-01-15 20:25 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/aaa6b578707e 8019853: Break logging and AWT circular dependency Summary: Break logging and AWT circular dependency, which was at the root cause for 8023258 - L

[7u60] Request for approval for 8019853: Break logging and AWT circular dependency

Hi, This is a request for approval to backport two fixes from JDK 8 to 7u60: [1] 8019853: Break logging and AWT circular dependency [2] 8026404: Logging in Applet can trigger ACE: access denied ("java.lang.RuntimePermission" "modifyThreadGroup") (the second fix is a fix of the first fix

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

On 12/10/13 10:41 AM, Jaroslav Bachorik wrote: Hi Daniel, On 9.12.2013 14:46, Daniel Fuchs wrote: Hi, This is a request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled webrev: http://cr.openjdk.java.net/~df

Re: [7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

ect of the call to SunToolkit.createNewAppContext(); I will log a bug in JIRA to ask for the forward port of the test. -- daniel As for 7u60, what you have is good enough and no change is needed. Mandy On 12/9/2013 5:46 AM, Daniel Fuchs wrote: Hi, This is a request for review & approval fo

hg: jdk7u/jdk7u-dev/jdk: 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

Changeset: 3ba8d15adade Author:dfuchs Date: 2013-12-10 10:36 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/3ba8d15adade 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled Summary: Logger.setParent needed a check to guard against man

[7u60] Request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled

Hi, This is a request for review & approval for 8025512: NPE with logging while launching webstart on jre7u40 if logging is disabled webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8025512/webrev.00/ bugid: https://bugs.openjdk.java.net/browse/JDK-8025512 In some circumstances, an NP

Re: [7u]: patches for the jdk jtreg tests for non US locale

Hi Francis, The first change in the first patch looks very suspect to me: It looks as if you're reverting a change I made a few weeks ago, namely changing "Severe" back into "SEVERE". http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/ffd0a74b30d6 The localization bundles are supposed to contain "S

hg: jdk7u/jdk7u-dev/jdk: 8016127: NLS: logging.properties translatability recommendation; ...

Changeset: ffd0a74b30d6 Author:dfuchs Date: 2013-09-04 20:50 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ffd0a74b30d6 8016127: NLS: logging.properties translatability recommendation 8024131: Issues with cached localizedLevelName in java.util.logging.Level Summary:

[7u60] Request for approval for CR 8016127 - NLS: logging.properties translatability recommendation

Hi, This is a request for review & approval for backporting the fix for 8016127 - NLS: logging.properties translatability recommendation which was pushed in JDK 8 [1] to JDK 7u-dev. Here is the JDK 7 webrev: Differences com

hg: jdk7u/jdk7u-dev/jdk: 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently

Changeset: 0ea0a4afa5fd Author:dfuchs Date: 2013-08-14 20:53 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/0ea0a4afa5fd 8019948: java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently Reviewed-by: mchung ! test/java/util/logging/bund

[7u-dev] Request for approval for CR 8019948 java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently

Hi, I would like to obtain approval to push the fix for: 8019948 java/util/logging/bundlesearch/ResourceBundleSearchTest.java is failing intermittently in the jdk7u-dev workspace. This is a test bug - involving only changes in 1 test file. This is a straightforward port of the fix pushed toda

Result: New JDK 7 Updates Committer: Jaroslav Bachorik

223.html> On 7/22/13 3:42 PM, Daniel Fuchs wrote: I hereby nominate Jaroslav Bachorik to JDK 7 Updates Committer. Jaroslav is already a JDK 8 committer and has contributed several changes to JDK 7 Updates: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/d76eee9b4820 http://hg.openjdk.java.net

Re: [7u40] Request for phase 2 approval for 8021946: Disabling sun.reflect.Reflection.getCallerCaller(int) by default breaks several frameworks and libraries

Hi Alan, If it's not too late you might want to add a testcase in the test for: @run main/othervm -Djdk.logging.allowStackWalkSearch=true GetCallerClass since that is supposed to switch allowGetCallerClass on. best regards, -- daniel On 7/31/13 10:44 PM, Alan Bateman wrote: A few weeks ago

CFV: New JDK 7 Updates Committer: Jaroslav Bachorik

to this mailing list. For Lazy Consensus voting instructions, see [2]. Daniel Fuchs [1]http://openjdk.java.net/census [2]http://openjdk.java.net/projects/#committer-vote

hg: jdk7u/jdk7u40-dev/jdk: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

Changeset: 51b0cc3d5102 Author:dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/51b0cc3d5102 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext inst

7u40 Request for approval for CR: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

Hi, This is a request to backport 8017174 to 7u40 [1]. This is a regression from 7u25 causing applets calling Logger.getAnonymousLogger() to fail. This fix has been resolved in jdk7u-dev and jdk8. WLS and GlassFish has done some preliminary testing with the 7u engineering build with this fix

hg: jdk7u/jdk7u-dev/jdk: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

Changeset: 7064285022a0 Author:dfuchs Date: 2013-07-02 11:30 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7064285022a0 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger Summary: This patch makes sure that LoggerContext instan

7u-dev Request for approval for CR: 8017174: NPE when using Logger.getAnonymousLogger or LogManager.getLogManager().getLogger

Hi, This is a request to backport 8017174 to 7u-dev [1]. Open review thread: http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018518.html The JDK 8 changeset is here: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/020f023f87d1 It applies cleanly to the jdk7u-dev source base (hg expor

Re: 7u40: Request for approval for CR 8013434 - Xalan and Xerces internal ObjectFactory need rework

? Hi Seán, If Joe is OK - when would be the deadline for this to get integrated? -- daniel regards, Sean. On 11/06/2013 10:10, Daniel Fuchs wrote: Hi Seán, On 6/11/13 10:31 AM, Seán Coffey wrote: Thanks for the background information Joe. Can you run this by the CCC team then ? (log a req

Re: 7u40: Request for approval for CR 8013434 - Xalan and Xerces internal ObjectFactory need rework

Sean. On 10/06/13 10:56, Daniel Fuchs wrote: Hi, This is a request for approval to backport JDK-8013434 to jdk7u-dev. With this changeset, DTMManager and XSLTCDTMManager will always use their own default implementation. JDK 8 Review thread: <http://mail.openjdk.java.net/pipermail/core-libs-de

7u40: Request for approval for CR 8013434 - Xalan and Xerces internal ObjectFactory need rework

Hi, This is a request for approval to backport JDK-8013434 to jdk7u-dev. With this changeset, DTMManager and XSLTCDTMManager will always use their own default implementation. JDK 8 Review thread: Bug URL:

hg: jdk7u/jdk7u-dev/jdk: 8013900: More warnings compiling jaxp.

Changeset: b5393be7f815 Author:dfuchs Date: 2013-06-03 15:35 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/b5393be7f815 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode(

hg: jdk7u/jdk7u-dev/jaxp: 8013900: More warnings compiling jaxp.

Changeset: fd1d63d3617b Author:dfuchs Date: 2013-06-03 11:29 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/fd1d63d3617b 8013900: More warnings compiling jaxp. Summary: Some internal implementation classes in Jaxp were redefining equals() without redefining hashCode

hg: jdk7u/jdk7u-dev/jdk: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently

Changeset: df33fcb65568 Author:dfuchs Date: 2013-05-31 16:30 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/df33fcb65568 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java someti

hg: jdk7u/jdk7u-dev/jaxp: 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently

Changeset: d6d20248f406 Author:dfuchs Date: 2013-05-31 16:30 +0200 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/d6d20248f406 8008738: Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently Summary: Encodings.java somet

7u40 Request for approval for CR 8013900: More warnings compiling jaxp.

Hi, This is a request for approval to backport The fix adds several hashCode() methods to classes that were redefining equals without redefining hashCode(). The changeset for jdk7u-dev [1] had to be altered on one count compared to the changes pus

7u40 Request for approval for CR 8008738 - Issue in com.sun.org.apache.xml.internal.serializer.Encodings causes some JCK tests to fail intermittently

Hi, This is a request for approval to backport the changes for: The review for the original fix happened for jdk8 on the core-libs-dev list, in these two thread: