Re: [7u-dev] Request for approval for 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-13 Thread David DeHaven
Thanks, Sean! -DrD- > I'll push this changeset for you David. > > regards, > Sean. > > On 12/08/2013 21:15, Dalibor Topic wrote: >> On 8/12/13 8:18 PM, David DeHaven wrote: >>> Build system fix for Mac OS X, j2sdk-server-image was not being deleted >&

[7u-dev] Request for approval for 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-12 Thread David DeHaven
Build system fix for Mac OS X, j2sdk-server-image was not being deleted like the other two images causing build failures when attempting to rebuild the JDK. Link: http://bugs.sun.com/view_bug.do?bug_id=8022734 Proposed changeset: http://cr.openjdk.java.net/~ddehaven/8022734/jdk.final/ Discussi

Re: RFR: 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-12 Thread David DeHaven
, I didn't realize that. I'll update the patch. > > -DrD- > >> Hi David, >> >> The other *setup targets just do $(RM) -r (since RM is already defined as rm >> -f). Would look better to follow the same pattern. Otherwise, thanks for >> fixing it. >

Re: RFR: 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-12 Thread David DeHaven
Ah, I didn't realize that. I'll update the patch. -DrD- > Hi David, > > The other *setup targets just do $(RM) -r (since RM is already defined as rm > -f). Would look better to follow the same pattern. Otherwise, thanks for > fixing it. > > /Erik > &g

RFR: 8022734: [macosx] Rebuilding jdk 7u on mac almost always fails

2013-08-09 Thread David DeHaven
This issue has been annoying me for some time, I finally got frustrated enough to fix it. Synopsis: Running make when a build has already completed will fail when it tries to symlink libjli.dylib, then (if that's fixed by using "ln -sf") when it tries to copy the sdk image to j2sdk-server-bund

Re: [7u40] Request for approval for CR 7181710 - [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread David DeHaven
forgotten ? > > Also - please add a noreg-* label to the bug report. > > Approved. > > regards, > Sean. > > On 06/06/2013 20:12, David DeHaven wrote: >> Bug: http://bugs.sun.com/view_bug.do?bug_id=7181710 >> >> Review threads: >&

[7u40] Request for approval for CR 7181710 - [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread David DeHaven
Bug: http://bugs.sun.com/view_bug.do?bug_id=7181710 Review threads: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2013-May/005692.html http://mail.openjdk.java.net/pipermail/awt-dev/2013-June/004951.html Changeset: http://cr.openjdk.java.net/~ddehaven/7181710/jdk.0/ Reviewed by: Anthon

Re: RFR: JDK-7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread David DeHaven
nthony Petrov wrote: >>> I've already reviewed this fix, and it looks fine to me. We still need >>> another reviewer. Adding awt-dev@. >>> >>> Anyone please? >>> >>> -- >>> best regards, >>> Anthony >>> >>> On

Re: RFR: JDK-7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-06 Thread David DeHaven
gt; Artem > > On 6/6/2013 4:40 PM, Anthony Petrov wrote: >> I've already reviewed this fix, and it looks fine to me. We still need >> another reviewer. Adding awt-dev@. >> >> Anyone please? >> >> -- >> best regards, >> Anthony >>

RFR: JDK-7181710: [macosx] jawt_md.h shipped with jdk is outdated

2013-06-05 Thread David DeHaven
Proposed fix for getting the correct jawt_md.h header in the JDK. I reused the XAWT flag to enable the X11 drawing surface struct. It is disabled by default as just about every application running on Mac will use the Cocoa interface. Apparently the X11 interface is still operable on Mac and it'