Re: [7u8] Request for approval: 7168172: (fs) Files.isReadable slow on Windows

2012-08-27 Thread Ulf Zibis
reviewed by Alan Bateman, Ulf Zibis and Zhong Yu(zhong.j...@gmail.com). [1] This fix has been pushed into jdk8 [2]. The fix for 7u8 is identical. Thanks, Kurchi [1]http://mail.openjdk.java.net/pipermail/nio-dev/2012-August/001847.html [2]http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd91a601265c

Re: Review Request CR#7118743 : Alternative Hashing for String with Hash-based Maps

2012-05-28 Thread Ulf Zibis
Am 23.05.2012 07:16, schrieb Mike Duigou: Webrevs for the Java 7u6 and 8 changes are available for download at [2] and [3] for your review. There are some important differences between the Java 7 and 8 implementations of this enhancement. Most specifically in the Java 8 implementation alternat

Re: Request for Review : CR#6924259: Remove String.count/String.offset

2012-05-25 Thread Ulf Zibis
Am 25.05.2012 01:11, schrieb Mike Duigou: On May 24 2012, at 15:56 , Ulf Zibis wrote: Am 24.05.2012 22:45, schrieb Mike Duigou: A patch of the changes to java.lang.String for JDK 8 are at<http://cr.openjdk.java.net/~mduigou/6924259/0/webrev/>. The changes for JDK 7 have only super

Re: Request for Review : CR#6924259: Remove String.count/String.offset

2012-05-25 Thread Ulf Zibis
Am 24.05.2012 22:45, schrieb Mike Duigou: A patch of the changes to java.lang.String for JDK 8 are at. The changes for JDK 7 have only superficial differences (line offsets in the patch). Correct Copyright date. 157 public String(Str