Changeset: ae26ea897101
Author:joehw
Date: 2013-11-05 13:25 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/ae26ea897101
8027860: [TEST_BUG] File not closed in
javax/xml/jaxp/parsers/8022548/XOMParserTest.java
Reviewed-by: alanb
! test/javax/xml/jaxp/parsers/8022548/
re-submit your 7u-dev approval request with corrected
information and subject.
regards,
Sean.
On 05/11/13 20:05, huizhe wang wrote:
Hi,
I'd like to request for approval to backport 8027860 to 7u-dev/7u60.
This is a quick fix to make sure files opened in the test are closed
Hi,
I'd like to request for approval to backport 8027860 to 7u-dev/7u60.
This is a quick fix to make sure files opened in the test are closed
properly.
Here's the bug:
https://bugs.openjdk.java.net/browse/JDK-8027860
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8027860/webrev/
Link to rev
Changeset: c45d0b1afbeb
Author:joehw
Date: 2013-10-31 20:36 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/c45d0b1afbeb
8024876: [TEST_BUG] javax/xml/jaxp/parsers/8022548/XOMParserTest.java failed
when testbase dir has read only permissions
Reviewed-by: chegar
! tes
Changeset: bcf1da5504d1
Author:joehw
Date: 2013-10-31 20:45 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/bcf1da5504d1
8004476: XSLT Extension Functions Don't Work in WebStart
Reviewed-by: dfuchs, lancea, alanb
+ test/javax/xml/jaxp/transform/jdk8004476/SecureProces
Changeset: ad39e88c5039
Author:joehw
Date: 2013-10-31 20:43 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/ad39e88c5039
8004476: XSLT Extension Functions Don't Work in WebStart
Reviewed-by: dfuchs, lancea, alanb
! src/com/sun/org/apache/xalan/internal/XalanConstants
Thanks Jeff!
Joe
On 10/31/2013 3:07 PM, Jeff Dinkins wrote:
Hi Joe,
Fixing tests is a good thing!
Approved for 7u-dev.
-jeff
On Oct 31, 2013, at 2:28 PM, huizhe wang wrote:
Hi,
I'd like to request for approval to backport 8024876 to 7u-dev/7u60. This is a
quick fix to a tes
Hi,
I'd like to request for approval to backport 8024876 to 7u-dev/7u60.
This is a quick fix to a test for 8022548.
Here's the bug:
https://bugs.openjdk.java.net/browse/JDK-8024876
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8024876/webrev/
Link to review thread :
http://mail.openjdk.java
Hi,
I'd like to request for approval to backport 8004476 to 7u60. This is a
fix to a regression that affected 6u32 and 7.
Here's the bug:
https://bugs.openjdk.java.net/browse/JDK-8004476
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8004476/webrev/
Link to review thread :
http://mail.openjd
Changeset: c0727f8c3ea8
Author:joehw
Date: 2013-10-19 16:15 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/c0727f8c3ea8
8016500: Unlocalized warnings.
Reviewed-by: lancea
! src/com/sun/org/apache/xerces/internal/jaxp/DefaultValidationErrorHandler.java
! src/com/sun/
Hi,
I'd like to request for approval to backport 8016500 to 7u60. This
change has been verified by i18n team.
Here's the bug:
https://jbs.oracle.com/bugs/browse/JDK-8016500
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8016500/webrev/
Link to review thread :
http://mail.openjdk.java.net/pip
Hi,
I'd like to request for approval to backport 8016500 to 7u60. This
change has been verified by i18n team.
Here's the bug:
https://jbs.oracle.com/bugs/browse/JDK-8016500
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8016500/webrev/
Link to review thread :
http://mail.openjdk.java.net/pip
Changeset: e0e3b791ec9d
Author:joehw
Date: 2013-10-17 17:00 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/e0e3b791ec9d
8015243: SchemaFactory does not catch enum. value that is not in the value
space of the base type, anyURI
Reviewed-by: lancea
+ test/javax/xml/jax
Changeset: e200ce7cc24b
Author:joehw
Date: 2013-10-17 16:59 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/e200ce7cc24b
8015243: SchemaFactory does not catch enum. value that is not in the value
space of the base type, anyURI
Reviewed-by: lancea
! src/com/sun/org/a
Thanks Rob. I think that indeed meant a codereview approval :)
-Joe
On 10/17/2013 3:51 PM, Rob McKenna wrote:
Approved, on the assumption that Lance's "+1" constituted a codereview
approval :)
-Rob
On 17/10/13 20:08, huizhe wang wrote:
Hi,
I'd like to request for
Hi,
I'd like to request for approval to backport 8015243 to 7u60.
Here's the bug:
https://jbs.oracle.com/bugs/browse/JDK-8015243
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8015243/webrev/
Link to review thread :
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022203.html
Changeset: cfd96c6d47c6
Author:joehw
Date: 2013-10-15 12:55 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/cfd96c6d47c6
8015092: SchemaFactory cannot parse schema if whitespace added within patterns
in Selector XPath expression
Reviewed-by: lancea, alanb
+ test/java
Changeset: fa4bc4681f57
Author:joehw
Date: 2013-10-15 12:34 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/fa4bc4681f57
8015092: SchemaFactory cannot parse schema if whitespace added within patterns
in Selector XPath expression
Reviewed-by: lancea, alanb
! src/com/
Hi,
I'd like to request for approval to backport 8015092 to 7u60.
Here's the bug:
https://jbs.oracle.com/bugs/browse/JDK-8015092
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8015092/webrev/
Link to review thread :
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-October/022062.html
Changeset: 5ea5b94af7d7
Author:joehw
Date: 2013-10-14 16:26 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/5ea5b94af7d7
8003262: reverse translation required changes in xalan resource bundles
Reviewed-by: lancea, dfuchs
! src/com/sun/org/apache/xalan/internal/res/XS
Hi,
I'd like to request for approval to backport 8003262 to 7u60.
Here's the bug:
https://jbs.oracle.com/bugs/browse/JDK-8003262
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8003262/webrev/
The fix was already pushed to jdk8:
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/b76629725522
The co
Changeset: a9f9a58b21cc
Author:joehw
Date: 2013-08-09 13:57 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/a9f9a58b21cc
8022548: SPECJVM2008 has errors introduced in 7u40-b34
Reviewed-by: chegar, lancea
! src/com/sun/org/apache/xerces/internal/parsers/DTDConfigura
Changeset: 5e2ce096b9e5
Author:joehw
Date: 2013-08-09 14:00 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/5e2ce096b9e5
8022548: SPECJVM2008 has errors introduced in 7u40-b34
Reviewed-by: chegar, lancea
+ test/javax/xml/jaxp/parsers/8022548/JDK8022548.xml
+ test/ja
Thanks!
On 8/9/2013 1:15 PM, Jeff Dinkins wrote:
Approved for 7u40
On Aug 9, 2013, at 12:55 PM, huizhe wang wrote:
Hi,
I'd like to request approval to backport the following fix to jdk7u40. This is
to allow 3rd party parser XOM to continue using the internal JAXP parser.
The bug:
Hi,
I'd like to request approval to backport the following fix to jdk7u40.
This is to allow 3rd party parser XOM to continue using the internal
JAXP parser.
The bug:
http://bugs.sun.com/view_bug.do?bug_id=8022548
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8022548/webrev/
Review:
http://
Changeset: 07024f18376c
Author:joehw
Date: 2013-07-25 18:10 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/07024f18376c
8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)
Reviewed-by: chegar, lancea, dfuchs
! src/com/sun/org/apache/xerces/internal/jaxp/SAXPars
Changeset: cd7a4d0b218f
Author:joehw
Date: 2013-07-25 18:13 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/cd7a4d0b218f
8021148: Regression in SAXParserImpl in 7u40 b34 (NPE)
Reviewed-by: chegar, lancea, dfuchs
+ test/javax/xml/jaxp/parsers/8021148/JAXPSAXParserTes
Hi,
I'd like to request approval to backport the following fix to jdk7u40.
This is to allow applications such as NetBeans to continue using the
internal JAXP parser.
The bug:
http://bugs.sun.com/view_bug.do?bug_id=8021148
Webrev:
http://cr.openjdk.java.net/~joehw/7u40/8021148/webrev/
Review
Changeset: 98d9339ffaa3
Author:joehw
Date: 2013-07-12 15:08 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jdk/rev/98d9339ffaa3
8020430: NullPointerException in xml sqe nightly result on 2013-07-12
Reviewed-by: chegar, lancea
+ test/javax/xml/jaxp/common/8020430/JAXP15RegT
Changeset: 0a6c9143f0b6
Author:joehw
Date: 2013-07-12 15:01 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/0a6c9143f0b6
8020430: NullPointerException in xml sqe nightly result on 2013-07-12
Reviewed-by: chegar, lancea
! src/com/sun/org/apache/xerces/internal/impl/
Hi,
I'd like to backport this change to 7u40. The code change is identical
to that for jdk8 where a null-value check is added for the new jaxp 1.5
property manager.
bug report: http://bugs.sun.com/view_bug.do?bug_id=8020430
jdk8 review:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2
Changeset: 4149e4abea17
Author:joehw
Date: 2013-07-10 15:08 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/4149e4abea17
8016648: FEATURE_SECURE_PROCESSING set to true or false causes
SAXParseException to be thrown
Summary: jaxp 1.5 feature update
Reviewed-by: alan
Hello.
I'd like to request approval to backport the following fix to jdk7u40.
This is an update to jaxp 1.5 in 7u40.
The bug:
http://bugs.sun.com/view_bug.do?bug_id=8016648
Webrev:
http://cr.openjdk.java.net/~joehw/jdk8/8016648/webrev/
Review:
http://mail.openjdk.java.net/pipermail/core-libs
Changeset: 5ede168e9229
Author:joehw
Date: 2013-07-02 16:39 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/5ede168e9229
8016133: Regression: diff. behavior with user-defined SAXParser
Reviewed-by: chegar, dfuchs, alanb
! src/org/xml/sax/helpers/XMLReaderFactory.ja
Sean.
On 02/07/2013 05:56, huizhe wang wrote:
Hello.
I'd like to request approval to backport the following fix to
jdk7u40. This is a quick fix on a regression caused by a previous
patch. It is a recovery of code that was accidentally removed.
The bug:
http://bugs.sun.com/view_bug
Hello.
I'd like to request approval to backport the following fix to jdk7u40. This is
a quick fix on a regression caused by a previous patch. It is a recovery of
code that was accidentally removed.
The bug:
http://bugs.sun.com/view_bug.do?bug_id=8016133
Webrev:
http://cr.openjdk.java.net/~joe
Changeset: e0d70a8119e8
Author:joehw
Date: 2013-06-11 14:22 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/e0d70a8119e8
8016153: Property http://javax.xml.XMLConstants/property/accessExternalDTD is
not recognized.
Reviewed-by: lancea, dfuchs
! src/com/sun/org/apach
nning.html
Maybe noreg-external is more appropriate for your case.
regards,
Sean.
On 11/06/2013 18:14, huizhe wang wrote:
I can add noreg-sqe. But I attached a test that can be run manually
since it requires a 3rd party jar file (e.g. Xerces). Would you think
reg-manual is correct?
Regards,
Jo
noreg-sqe label with a comment to that effect ?
regards,
Sean.
On 10/06/2013 22:50, huizhe wang wrote:
Hi,
This is a request for approval to backport 8016153 to JDK7. This is a
fix to the JAXP 1.5 upgrade so that 3rd party impls that do not
support jaxp 1.5 can continue working as usual.
Hi Sean,
It was on my request that Daniel took the trouble to make the backports
on this and several of his previous JDK8 changes. Past experience with
6u during jdk7 development showed that it was very beneficial keeping
the two in sync.
For this particular one, the behavioral change exists
Hi,
This is a request for approval to backport 8016153 to JDK7. This is a
fix to the JAXP 1.5 upgrade so that 3rd party impls that do not support
jaxp 1.5 can continue working as usual.
The change is identical to that in JDK8.
JDK8 changeset:
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5c84
Changeset: 8c0300415567
Author:joehw
Date: 2013-06-07 10:01 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/8c0300415567
8015016: Improve JAXP 1.5 error message
Reviewed-by: lancea
! src/com/sun/org/apache/xalan/internal/xsltc/compiler/util/ErrorMessages.java
! src/c
Hello,
This is a straight backport from 8, the changes are identical.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015016
Review thread:
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/017746.html
Changeset: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/c2957e596bee
Changeset: 3e1a31ba199f
Author:joehw
Date: 2013-05-21 12:07 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3e1a31ba199f
8014891: Redundant setting of external access properties in setFeatures
Reviewed-by: lancea
! src/com/sun/org/apache/xerces/internal/jaxp/Document
) I've changed that to
noreg-sqe.
Regards,
Joe
regards,
Sean.
http://openjdk.java.net/projects/jdk7u/approval-template.html
On 21/05/2013 17:24, huizhe wang wrote:
JDK8 changeset:
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682
On 5/20/2013 4:16 PM, huizhe wang wrote:
Hi,
I
Changeset: bb6ff7d1deb7
Author:joehw
Date: 2013-05-21 09:22 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/bb6ff7d1deb7
8012683: Remove unused, obsolete ObjectFactory classes
Reviewed-by: lancea
- src/com/sun/org/apache/xerces/internal/xinclude/ObjectFactory.java
-
,
Sean.
On 21/05/2013 08:33, huizhe wang wrote:
Hi,
I'd like to ask approval to backport the change into 7u40. This is a
quick fix to remove a couple of obsolete ObjectFactory classes. They
should have been removed in a previous consolidation work (7053556)
but were mistakenly kept in the
JDK8 changeset:
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/a7cec93e4682
On 5/20/2013 4:16 PM, huizhe wang wrote:
Hi,
I'd like to backport JDK-8014891 to 7u40, removing redundant setting
of access properties from the setFeatures method. This is a fix to the
previous jaxp 1.5 patch
Hi,
I'd like to ask approval to backport the change into 7u40. This is a
quick fix to remove a couple of obsolete ObjectFactory classes. They
should have been removed in a previous consolidation work (7053556) but
were mistakenly kept in the repo.
webrev:
http://cr.openjdk.java.net/~joehw/j
Hi,
I'd like to backport JDK-8014891 to 7u40, removing redundant setting of
access properties from the setFeatures method. This is a fix to the
previous jaxp 1.5 patch. The change is identical to that in JDK8.
Bug: https://jbs.oracle.com/bugs/browse/JDK-8014891
webrevs:
http://cr.openjdk.jav
Changeset: 52bcce690998
Author:joehw
Date: 2013-05-13 12:25 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/52bcce690998
8011653: Upgrade to JAXP 1.5
Summary: backport jdk8 changes into 7u40
Reviewed-by: alanb, lancea, dfuchs
! src/com/sun/org/apache/xalan/internal/X
Yes. The code detects the JDK version and set the default differently.
Joe
On 5/10/2013 12:01 AM, Alan Bateman wrote:
Joe - aren't the defaults for jdk7u different?
On 09/05/2013 23:32, huizhe wang wrote:
Hello,
I'd like to backport the following changes from JDK8 to 7u40:
Hello,
I'd like to backport the following changes from JDK8 to 7u40:
8011653 - Upgrade JDK8 to JAXP 1.5
http://bugs.sun.com/view_bug.do?bug_id=8011653
The JDK8 changeset is at
http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/1e8d98012ab8
The changeset applies to jdk7u-dev repository withou
Changeset: ac66e6701b65
Author:joehw
Date: 2012-12-19 13:13 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/ac66e6701b65
8003261: static field is public but not final
Summary: add final to fVersion field, and make it a non-compile time constant.
Reviewed-by: hawtin, l
Changeset: f7a0897308d5
Author:joehw
Date: 2012-12-17 22:54 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/f7a0897308d5
8003260: [findbug] some fields should be package protected
Summary: change public or protected mutable static fields to private or package
private
Changeset: 15813656f07f
Author:joehw
Date: 2012-10-12 23:39 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/15813656f07f
8000664: 2 SAX features does not work properly
Summary: When external dtd is not loaded, skippedEntity event should be
reported for entity referen
Changeset: f9292d14967a
Author:joehw
Date: 2012-08-17 10:53 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/f9292d14967a
7191547: XMLEventFactory.newFactory(String factoryId, ClassLoader loader) does
not work as expected
Summary: similar to the patch for 6756677 for
Changeset: 3558d0eaa379
Author:joehw
Date: 2012-07-13 09:46 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3558d0eaa379
7166896: DocumentBuilder.parse(String uri) is not IPv6 enabled. It throws
MalformedURLException
Summary: removing the hack of using escapeNonUSAsc
Changeset: 7adc0347cb95
Author:joehw
Date: 2012-06-12 11:03 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/7adc0347cb95
7157610: NullPointerException occurs when parsing XML doc
Summary: recovers what was the original disallow-doctype-decl, reporting error
when disa
Changeset: 0a1789d9f5be
Author:joehw
Date: 2012-06-12 11:00 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/0a1789d9f5be
7144423: StAX EventReader swallows the cause of error
Summary: make sure the cause of the error is properly reported
Reviewed-by: lancea, psandoz
Changeset: 9d758706c294
Author:joehw
Date: 2012-06-11 11:45 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/9d758706c294
7157608: One feature is not recognized.
Summary: adding feature standard-uri-conformant into the recognized list
Reviewed-by: psandoz
! src/com/su
Changeset: b9e2634b02d0
Author:joehw
Date: 2012-06-07 15:00 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/b9e2634b02d0
7151118: Regressions on 7u4 b11 comp. 7u4 b06 on specjvm2008.xml.transform
subbenchmark
Summary: roll back XalanJ-2271 that caused the regression
Changeset: 3c16346aac50
Author:joehw
Date: 2012-04-16 16:48 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3c16346aac50
7161105: unused classes in jdk7u repository
Summary: In the patch for 7053556, the ObjectFactory/SecuritySupport classes
that were duplicated in m
Changeset: 3d640f609068
Author:joehw
Date: 2012-04-02 11:07 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/3d640f609068
7151484: NullPointerException caused by a bug in XMLDocumentFragmentScannerImpl
Reviewed-by: lancea
!
src/com/sun/org/apache/xerces/internal/impl
Changeset: 35416f31de0a
Author:joehw
Date: 2012-03-21 15:35 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jaxp/rev/35416f31de0a
7150637: No newline emitted after XML decl in XSLT output
Reviewed-by: lancea
! src/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTrans
Changeset: b519b554f589
Author:joehw
Date: 2012-03-06 09:52 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u4-dev/jaxp/rev/b519b554f589
7147666: High lock time for
com.sun.org.apache.xerces.internal.impl.dv.DTDDVFactory.getInstance()
Reviewed-by: andrew, alanb, lancea
! src/com/s
Changeset: 341a97befe0f
Author:joehw
Date: 2012-02-14 09:25 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/341a97befe0f
7143711: Feature added by 7053556 should not override what's set by the
constructor in secure mode
Reviewed-by: hawtin
! src/com/sun/org/apache/x
Changeset: 4a61ac055189
Author:joehw
Date: 2012-01-31 20:20 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/4a61ac055189
7133220: Additional patches to JAXP 1.4.5 update 1 for 7u4
Reviewed-by: alanb
! src/com/sun/org/apache/xalan/internal/lib/ExsltDatetime.java
! src
Changeset: 24f4c1185305
Author:joehw
Date: 2011-11-22 12:05 -0800
URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jaxp/rev/24f4c1185305
777: test my configuration
Reviewed-by: asaha
! jaxp.properties
69 matches
Mail list logo
