Short version: Approved.
Slightly longer version: Sean Coffey has been reviewing these changes over the
last several weeks and he feels they’re in good order. Approving on Sean's
behalf while he’s OOTO.
-jeff
On Apr 15, 2014, at 1:01 PM, Abhijit Saha wrote:
> 7u55 was released earlier tod
:06 PM, Jeff Dinkins wrote:
>
>>
>> I might have missed it in the bug, but - where is the review (and who are
>> the review approvers?)
>
> No, you did not miss it; I forgot to paste the link. Here is the review
> thread:
>
> http://mail.openjdk.java.net
I might have missed it in the bug, but - where is the review (and who are the
review approvers?)
thanks,
-jeff
On Feb 12, 2014, at 1:53 PM, Christian Thalinger
wrote:
> This change was intended to end up in 7u40 but for some reason we missed it.
> The original bug which went into 8 is:
>
Approved for 7u.
On Jan 14, 2014, at 2:33 PM, Abhijit Saha (Oracle) wrote:
> 7u51 was released earlier today [1]. Requesting approval to sync up the
> changes into the jdk7u forest.
>
> webrev : http://cr.openjdk.java.net/~asaha/openJDK.7u51.sync/webrev/
>
> Thanks
> Abhijit
>
>
> [1] http:
Hi Sean,
Approved for 7u60.
-jeff
On Nov 7, 2013, at 6:03 AM, Seán Coffey wrote:
> JDK-8027837 is a recent bug reported by release engineering team. It's not
> public due to it containing some internal links.
>
> The recent JDK-8021257 fix means that some com.sun.corba.se.impl classes get
Hi Joe,
Fixing tests is a good thing!
Approved for 7u-dev.
-jeff
On Oct 31, 2013, at 2:28 PM, huizhe wang wrote:
> Hi,
>
> I'd like to request for approval to backport 8024876 to 7u-dev/7u60. This is
> a quick fix to a test for 8022548.
>
> Here's the bug:
> https://bugs.openjdk.java.net/
Hi Joe -
Approved for 7u-dev
-jeff
On Oct 31, 2013, at 9:46 AM, huizhe wang wrote:
> Hi,
>
> I'd like to request for approval to backport 8004476 to 7u60. This is a fix
> to a regression that affected 6u32 and 7.
>
> Here's the bug:
> https://bugs.openjdk.java.net/browse/JDK-8004476
>
> W
Hi Ivan - looks good!
Approved for 7u-dev
-jeff
On Oct 28, 2013, at 6:51 AM, Ivan Gerasimov wrote:
> Hello!
>
> Would you please approve a backport of a simple doc fix into 7u-dev?
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8016018
> JDK8 Change: http://hg.openjdk.java.net/jdk8/jdk8/
Hi Sean,
Approved for 7udev.
-jeff
On Oct 25, 2013, at 12:10 PM, Seán Coffey wrote:
> I'd like to backport this patch from jdk8 to jdk7u-dev.
>
> The patch is identical except for some line offsets in the java.security
> files which I had to adjust. Some internal glassfish testing hasn't sho
Hi Johnny -
Approved for 7u-dev.
Note: code reviewed by Phil Race
On Oct 16, 2013, at 2:28 PM, Johnny Chen wrote:
> Requesting approval to backport this one from JDK8 with 10.9 releasing soon.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8024461
> webrev: http://cr.openjdk.java.net/~jch
Hi Aleksej,
Looks good. Approved for 7u-dev
Note: Reviewed-by: okutsu, mfang
On Oct 16, 2013, at 2:12 PM, Aleksej Efimov wrote:
> Hi,
> This is a backport of the following JDK 8 bug [1] to 7u-dev.
>
> The fix [2] is almost identical to the JDK 8 [3] except the following items:
> 1. No update
Hi Aleksej,
Looks good - approved for 7-dev
-jeff
On Oct 15, 2013, at 3:54 AM, Aleksej Efimov wrote:
> Hi,
>
> This is a request for a straightforward backport of JDK 8 fix for bug 8008733
> to JDK 7u-dev.
> The changes are identical to JDK 8.
>
> JDK8 changesets:
> http://hg.openjdk.java.
Hi Joe,
Approved for 7u-dev (aka 7u60)
-jeff
On Oct 14, 2013, at 10:36 PM, huizhe wang wrote:
> Hi,
>
> I'd like to request for approval to backport 8015092 to 7u60.
>
> Here's the bug:
> https://jbs.oracle.com/bugs/browse/JDK-8015092
>
> Webrev:
> http://cr.openjdk.java.net/~joehw/jdk8/80
7u60 is quite a ways out, is it ok to bake in 7u-dev?
On Oct 9, 2013, at 7:27 AM, Rob McKenna wrote:
> I'm conflicted.
>
> It seems that quite a few Mac developers are running into this problem. The
> fact that this code has been effectively transplanted from Apple's JDK gives
> me a high de
Hi Rob,
Looks good. Approved for 7u-dev.
-jeff
On Oct 8, 2013, at 4:20 PM, Rob McKenna wrote:
> Hi folks,
>
> 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on
> OSX webbugs
> http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419
> https://bugs.openjdk.java.net/b
Hi Sean,
Approved for 7u-dev.
-jeff
On Oct 8, 2013, at 11:57 AM, Seán Coffey wrote:
> I'd like to backport this to jdk7u-dev. The change applies cleanly.
>
> jdk8 changeset : http://hg.openjdk.java.net/jdk8/tl/jdk/rev/368172cb6dc5
>
> review thread :
> http://mail.openjdk.java.net/pipermai
Heya Sean - sounds like this is pulled from the upstream jax-ws repos? Just
wanted to double check on who the reviewers were/their approvals. Other than
that, looks good.
Approved for 7u-dev
-jeff
On Oct 8, 2013, at 11:48 AM, Seán Coffey wrote:
> I'd like to backport this to jdk7u-dev. The
(aside: I changing the title to 7u60)
Approved for 7u-dev.
-jeff
On Oct 8, 2013, at 11:12 AM, Xueming Shen wrote:
> Hi, please help approve
>
> JDK-8022868: missing codepage Cp290 at java runtime
>
> This is the backport of #6614237 [1]. The 7u-dev change is slightly
> different for the IBM
Hi Alejandro,
Approved for 7u-dev
-jeff
On Oct 4, 2013, at 12:45 PM, Alejandro E Murillo
wrote:
> Requesting approval to integrate hs24.60-b01 into jdk7u60-b01.
>
> A webrev is available at:
>
> http://cr.openjdk.java.net/~amurillo/7u60/hs24.60-b01-jdk7u60-b01.webrev/
>
> Pre-integration
Hi Miroslaw:
At least one of these comes up blank:
http://cr.openjdk.java.net/%7Emkos/8025713/webrev-jaxws.00/src/share/jaxws_classes/com/sun/xml/internal/bind/v2/model/impl/ModelBuilder.java.sdiff.html
Is that ok?
And this one seems to be changing the copyright from 2013 to 2012 - is that
Hi Dmitry,
Approved for 7u-dev.
-jeff
On Oct 2, 2013, at 6:34 AM, dmitry markov wrote:
> Hello,
>
> Could you approve a back-port to jdk7u-dev of the fix for 7129133, please?
>
> bug: http://bugs.sun.com/view_bug.do?bug_id=7129133
> webrev for jdk7u: http://cr.openjdk.java.net/~dmarkov/71291
Hi Séan,
Looks good.
Approved for 7u-dev.
-jeff
On Sep 19, 2013, at 1:28 PM, Seán Coffey wrote:
> Hi,
>
> I'd like to backport this to jdk7u-dev forest. Changes apply cleanly.
>
> JDK 8 changesets :
> http://hg.openjdk.java.net/jdk8/tl/corba/rev/af8e5bc3a150
> http://hg.openjdk.java.net/jdk
Thanks Mikhail,
Approved for 7u-dev.
-jeff
On Sep 18, 2013, at 1:47 PM, mikhail cherkasov
wrote:
> Hi Jeff,
>
> On 18.09.2013 22:50, Jeff Dinkins wrote:
>> Is there a public link to the JDK8 review?
> http://mail.openjdk.java.net/pipermail/swing-dev/2013-September/00295
Hi Mikhail,
Is there a public link to the JDK8 review?
thanks
jeff
On Sep 18, 2013, at 4:19 AM, mikhail cherkasov
wrote:
> Hello all,
> I need to push exactly the same changes that were done for jdk8 to jdk7:
>
> bug: http://bugs.sun.com/view_bug.do?bug_id=8016746
> Webrev: http://cr.openj
Hi Brian,
Approved for 7u-dev.
-jeff
On Sep 16, 2013, at 4:56 PM, Brian Burkhalter
wrote:
> This is a request for a partial backport from JDK 8. The code in question was
> part of a large patch which has been integrated now for about three months.
>
> Issue:
> http://bugs.s
Hi Max,
Approved for 7u-dev.
-jeff
On Sep 10, 2013, at 4:38 AM, Weijun Wang wrote:
> Hi All
>
> This is a request to backport two related jdk8 fixes into jdk7u.
>
> 8021788: JarInputStream doesn't provide certificates for some file under
> META-INF
> 8022761: regression: SecurityExcept
Hi Anton,
Approved for 7u-dev
-jeff
On Sep 5, 2013, at 5:10 AM, anton nashatyrev
wrote:
> Hello,
>
>please approve the fix backport from jdk8 to jdk7u-dev. The patch was
> applied almost without modifications.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8023392
> Webrev for JDK8
Hi Daniel,
Approved for 7u-dev.
-jeff
On Sep 4, 2013, at 3:12 AM, Daniel Fuchs wrote:
> Hi,
>
> This is a request for review & approval for backporting the fix for
>
> 8016127 - NLS: logging.properties translatability recommendation
>
> which was pushed in JDK 8 [1] to JDK 7u-dev.
>
> He
Hi Sean -
Approved for 7u-dev.
On Sep 3, 2013, at 11:05 AM, Seán Coffey wrote:
> Requesting approval to push this fix to jdk7u-dev. The fix is not applicable
> to jdk8 as changes being made there at moment mean this is a non-issue for
> that release.
>
> review thread :
> http://mail.open
Hi Shanliang,
Approved for 7u-dev.
thanks,
jeff
On Aug 30, 2013, at 7:47 AM, shanliang wrote:
> This is a simple export/import backport for
> 6566891: RMIConnector: map value referencing map key in WeakHashMap
> prevents map entry to be removed
>
> bug: https://bugs.openjdk.java.net/brow
Approved for 7u-dev. Still pending reviewer (I don't have that role).
On Aug 29, 2013, at 8:19 AM, Seán Coffey wrote:
> Simple testcase ignore request. This test causes issue for systems if run as
> root. It's already been excluded in JDK 8 via a problemlist update (7081813).
> Would like to
Hi Staffan,
Approved for jdk7u-dev (aka 7u60).
-jeff
On Aug 16, 2013, at 9:44 AM, Staffan Larsen wrote:
> This is a request for backporting the two following related bugs:
>
> JDK-8009397: test/com/sun/jdi/PrivateTransportTest.sh: ERROR: transport
> library missing onLoad entry: private_dt_
Hi Ivan,
Looks good.
Approved for jdk7u-dev.
-jeff
On Aug 15, 2013, at 8:22 AM, Ivan Gerasimov wrote:
> Request for approval to backport 8022584
>
> This is a fix of copy/paste error that led to a non necessary allocation in a
> native code.
>
> Bug: http://bugs.sun.com/bugdatabase/view_
Looks good.
Approved for jdk7u-dev.
On Aug 13, 2013, at 9:42 AM, Daniel Fuchs wrote:
> Hi,
>
> I would like to obtain approval to push the fix for:
> 8019948 java/util/logging/bundlesearch/ResourceBundleSearchTest.java is
> failing intermittently
> in the jdk7u-dev workspace.
>
> This is a
Approved for 7u40
On Aug 9, 2013, at 12:55 PM, huizhe wang wrote:
> Hi,
>
> I'd like to request approval to backport the following fix to jdk7u40. This
> is to allow 3rd party parser XOM to continue using the internal JAXP parser.
>
> The bug:
> http://bugs.sun.com/view_bug.do?bug_id=8022548
Looks good.
Approved for jdk7u-dev.
On Aug 8, 2013, at 6:40 PM, Weijun Wang wrote:
> Hi All
>
> This is a request to backport a jdk8 fix into jdk7u-dev.
>
> 7151062: [macosx] SCDynamicStore prints error messages to stderr
>
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151062
>
>
Approved for jdk7u-dev.
Link to review:
http://mail.openjdk.java.net/pipermail/awt-dev/2013-July/005209.html
-jeff
On Aug 8, 2013, at 1:52 PM, Leonid Romanov wrote:
> Hello,
> Requesting an approval to push the fix for 8021815 into jdk7u-dev. The fix
> has already been pushed into JDK 8.
>
Approved for jdk7u-dev.
Record keeping:
Reviewers: many in review thread below, but I believe Alan Bateman and Chris
Hegarty are the ones on record as approving.
On Aug 1, 2013, at 4:41 PM, Ivan Gerasimov wrote:
> Here's a request for approval to backport 8020669 into 7u-dev repository.
>
>
Approved for jdk7u40-dev.
On Jul 31, 2013, at 1:44 PM, Alan Bateman wrote:
>
> A few weeks ago we pushed a change that "disables" the JDK private method
> sun.reflect.Reflection.getCallerClass(int). Those that have been following
> the effort to check the usages of caller sensitive methods i
Approved for jdk7u-dev
On Jul 29, 2013, at 12:46 PM, Leonid Romanov wrote:
> Hello,
> Requesting approval to push the fix for 8007267: [macosx]
> com.apple.eawt.Application.setDefaultMenuBar is not working into 7u-dev. The
> fix has already been pushed into 8.
>
> Bug: http://bugs.sun.com/vie
Changeset: 2e2cdadf9515
Author:jeff
Date: 2013-07-25 12:31 -0700
URL:
http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/langtools/rev/2e2cdadf9515
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Changeset: 9efad07b0a1e
Author:jeff
Date: 2013-07-25 12:30 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxws/rev/9efad07b0a1e
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Changeset: 704518b26725
Author:jeff
Date: 2013-07-25 12:30 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/jaxp/rev/704518b26725
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Changeset: b5c3f432e953
Author:jeff
Date: 2013-07-25 12:30 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/hotspot/rev/b5c3f432e953
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Changeset: 3eaff5b0cd97
Author:jeff
Date: 2013-07-25 12:29 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/corba/rev/3eaff5b0cd97
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Changeset: 53fe3334f0b3
Author:jeff
Date: 2013-07-25 12:20 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/rev/53fe3334f0b3
8014850: Third Party License Readme updates for 7u40
Reviewed-by: lana, tbell
! THIRD_PARTY_README
Note: this is not a backport of the JDK8 Third Party README, so there's no link
to a JDK8 changeset included.
BugID: 8014850
Synopsis: 7u40 THIRDPARTY License Readme Update
JDK 7 webrev: http://cr.openjdk.java.net/~jeff/8014850
Reviewers:
Lana Steuck, Tim Bell
thanks,
jeff
> On 08:50 Wed 02 Nov , Dan Smith wrote:
>> I'd appreciate something like this:
>>
>> Subject: [7u2 CR] 7099XXX - Duke's nose is the wrong Pantone shade of red
Edvard, Dalibor: what needs to be done to make this official and put into
practice?
thanks,
jeff
On Nov 7, 2011, at 3:31 PM,
e.g. change this:
Subject: Request for approval for 7099XXX - Duke's nose is the wrong Pantone
shade of red
to this:
Subject: 7u2 - Request for approval for 7099XXX - Duke's nose is the wrong
Pantone shade of red
thoughts?
-jeff
Changeset: c27b7bf33e44
Author:jeff
Date: 2011-10-31 12:35 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/corba/rev/c27b7bf33e44
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: 5905d153e9fc
Author:jeff
Date: 2011-10-31 12:38 -0700
URL:
http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/langtools/rev/5905d153e9fc
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: 65724337b28c
Author:jeff
Date: 2011-10-31 12:37 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/jdk/rev/65724337b28c
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: 2b9c72e743b2
Author:jeff
Date: 2011-10-31 12:37 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/jaxws/rev/2b9c72e743b2
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: db5034845265
Author:jeff
Date: 2011-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/jaxp/rev/db5034845265
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: 68d4d1b6829a
Author:jeff
Date: 2011-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/hotspot/rev/68d4d1b6829a
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Changeset: 844a1d316d93
Author:jeff
Date: 2011-10-31 12:34 -0700
URL: http://hg.openjdk.java.net/jdk7u/jdk7u2-dev/rev/844a1d316d93
7102337: Third Party License Readme updates for 7u2
Reviewed-by: lana, ohair
! THIRD_PARTY_README
Uploaded here:
http://cr.openjdk.java.net/~jeff/7102337
Sorry for the prior noise. :-)
jeff
> Note that since 7 & 8's 3rd party license files diverge, this copy of the
> license readme is not a backport from 8.
>
> Bug description:
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=71
didn't make it into the email :) Can you attach it
> again?
>
> Cheers,
> Edvard
>
> On Oct 24, 2011, at 6:44 PM, Jeff Dinkins wrote:
>
>>
>> Note that since 7 & 8's 3rd party license files diverge, this copy of the
>> license rea
Note that since 7 & 8's 3rd party license files diverge, this copy of the
license readme is not a backport from 8.
Bug description:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7102337
Webrev:
sdiff attached, if people need any of the other formats webrev generates, let
me know and I'
59 matches
Mail list logo
