Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

' line of code has been simply removed from the code but "src" folder was temporarily created using 'mkdir src' in the Driver.sh code so I believe it should be removed if its created after use. Please suggest further . Regards, Pooja On 1/22/2015 7:05 PM, Maurizio Cimad

Re: [7u] Review Request: JDK-8064454 Fix type in langtools for tools/javac/innerClassFile/Driver.sh

It seems like the problematic rm in the last line has been removed i.e. in JDK 8? http://hg.openjdk.java.net/jdk8u/jdk8u-dev/langtools/file/2d2b2be57c78/test/tools/javac/innerClassFile/Driver.sh Perhaps, instead of tweaking permission, we should just do things the JDK 8 way? Maurizio On 12/

Re: [7u-dev] Request for Review to Backport: 6695379: Copy method annotations and parameter annotations to synthetic bridge methods

Looks good to me. Maurizio On 10/12/14 17:59, Vicente-Arturo Romero-Zaldivar wrote: Hi, Please review the backport of JDK-6695379 from 9 repo to JDK7u-dev. The patch is mainly the same. Main differences are related to different definitions for annotations in both repos and because of tests

hg: jdk7u/jdk7u40-dev/langtools: 8015668: overload resolution: performance regression in JDK 7

Changeset: 06285eb8d755 Author:vromero Date: 2013-06-26 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u40-dev/langtools/rev/06285eb8d755 8015668: overload resolution: performance regression in JDK 7 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Resolve.java

hg: jdk7u/jdk7u-dev/langtools: 7179353: try-with-resources fails to compile with generic exception parameters

Changeset: 028d81ce5e5b Author:vromero Date: 2013-06-02 20:35 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/028d81ce5e5b 7179353: try-with-resources fails to compile with generic exception parameters Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/j

hg: jdk7u/jdk7u-dev/langtools: 7160084: javac fails to compile an apparently valid class/interface combination

Changeset: 7e2c650b86bc Author:mcimadamore Date: 2013-05-29 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/7e2c650b86bc 7160084: javac fails to compile an apparently valid class/interface combination Summary: javac generates wrong syntetized trees for nest

[7u-dev] Request for approval to backport 7160084: javac fails to compile an apparently valid class/interface combination

Request for approval to backport 7160084 Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160084 JDK 8 Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37dc15c68760 backport review: http://mail.openjdk.java.net/pipermail/compiler-dev/2013-May/006313.html Thanks, Maurizio

[7u-dev] Request for approval to backport 8011234: Performance regression with ftp protocol when uploading in image mode

Request for approval to backport 7160084 Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7160084 JDK 8 Changeset: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/37dc15c68760 backport review: http://mail.openjdk.java.net/pipermail/compiler-dev/2013-May/006313.html Thanks, Maurizio

Re: [7u4] Request for approval for CR 7123100 - javac fails with java.lang.StackOverflowError

On 15-Jan-12 11:18 AM, Dmeetry Degrave wrote: Hi, This is a request for jdk7 update 4. The changes in 7u4 are identical to jdk8. cr: http://bugs.sun.com/view_bug.do?bug_id=7123100 fix: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/133744729455 thanks, dmeetry Approved. Maurizio

hg: jdk7u/jdk7u-dev/langtools: 3 new changesets

Changeset: e296280b4e77 Author:mcimadamore Date: 2011-07-27 19:00 +0100 URL: http://hg.openjdk.java.net/jdk7u/jdk7u-dev/langtools/rev/e296280b4e77 7062745: Regression: difference in overload resolution when two methods are maximally specific Summary: Fix most specific when two meth